* [PATCH] Provider/rxe: Remove printf()
@ 2021-09-29 21:42 Bob Pearson
2021-09-30 5:18 ` Leon Romanovsky
0 siblings, 1 reply; 3+ messages in thread
From: Bob Pearson @ 2021-09-29 21:42 UTC (permalink / raw)
To: linux-rdma, zyjzyj2000, jgg; +Cc: Bob Pearson
Currently the rxe provider issues a print statement if it detects
an invalid work request and also returns an error. A recently
added python test case triggers such a message which is expected
since the test is deliberately constructing invalid work requests.
This patch removes the print statement which has no practical use.
Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com>
---
providers/rxe/rxe.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/providers/rxe/rxe.c b/providers/rxe/rxe.c
index 3533a325..42fc447c 100644
--- a/providers/rxe/rxe.c
+++ b/providers/rxe/rxe.c
@@ -1513,10 +1513,8 @@ static int post_one_send(struct rxe_qp *qp, struct rxe_wq *sq,
length += ibwr->sg_list[i].length;
err = validate_send_wr(qp, ibwr, length);
- if (err) {
- printf("validate send failed\n");
+ if (err)
return err;
- }
wqe = (struct rxe_send_wqe *)producer_addr(sq->queue);
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Provider/rxe: Remove printf()
2021-09-29 21:42 [PATCH] Provider/rxe: Remove printf() Bob Pearson
@ 2021-09-30 5:18 ` Leon Romanovsky
2021-09-30 20:05 ` Bob Pearson
0 siblings, 1 reply; 3+ messages in thread
From: Leon Romanovsky @ 2021-09-30 5:18 UTC (permalink / raw)
To: Bob Pearson; +Cc: linux-rdma, zyjzyj2000, jgg
On Wed, Sep 29, 2021 at 04:42:15PM -0500, Bob Pearson wrote:
> Currently the rxe provider issues a print statement if it detects
> an invalid work request and also returns an error. A recently
> added python test case triggers such a message which is expected
> since the test is deliberately constructing invalid work requests.
>
> This patch removes the print statement which has no practical use.
>
> Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com>
> ---
> providers/rxe/rxe.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Please remove this "fprintf(stderr, "rxe: Failed to query sgid.\n");"
line too.
Thanks
>
> diff --git a/providers/rxe/rxe.c b/providers/rxe/rxe.c
> index 3533a325..42fc447c 100644
> --- a/providers/rxe/rxe.c
> +++ b/providers/rxe/rxe.c
> @@ -1513,10 +1513,8 @@ static int post_one_send(struct rxe_qp *qp, struct rxe_wq *sq,
> length += ibwr->sg_list[i].length;
>
> err = validate_send_wr(qp, ibwr, length);
> - if (err) {
> - printf("validate send failed\n");
> + if (err)
> return err;
> - }
>
> wqe = (struct rxe_send_wqe *)producer_addr(sq->queue);
>
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Provider/rxe: Remove printf()
2021-09-30 5:18 ` Leon Romanovsky
@ 2021-09-30 20:05 ` Bob Pearson
0 siblings, 0 replies; 3+ messages in thread
From: Bob Pearson @ 2021-09-30 20:05 UTC (permalink / raw)
To: Leon Romanovsky; +Cc: linux-rdma, zyjzyj2000, jgg
On 9/30/21 12:18 AM, Leon Romanovsky wrote:
> On Wed, Sep 29, 2021 at 04:42:15PM -0500, Bob Pearson wrote:
>> Currently the rxe provider issues a print statement if it detects
>> an invalid work request and also returns an error. A recently
>> added python test case triggers such a message which is expected
>> since the test is deliberately constructing invalid work requests.
>>
>> This patch removes the print statement which has no practical use.
>>
>> Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com>
>> ---
>> providers/rxe/rxe.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> Please remove this "fprintf(stderr, "rxe: Failed to query sgid.\n");"
> line too.
>
> Thanks
>
NP
>>
>> diff --git a/providers/rxe/rxe.c b/providers/rxe/rxe.c
>> index 3533a325..42fc447c 100644
>> --- a/providers/rxe/rxe.c
>> +++ b/providers/rxe/rxe.c
>> @@ -1513,10 +1513,8 @@ static int post_one_send(struct rxe_qp *qp, struct rxe_wq *sq,
>> length += ibwr->sg_list[i].length;
>>
>> err = validate_send_wr(qp, ibwr, length);
>> - if (err) {
>> - printf("validate send failed\n");
>> + if (err)
>> return err;
>> - }
>>
>> wqe = (struct rxe_send_wqe *)producer_addr(sq->queue);
>>
>> --
>> 2.30.2
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-30 20:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-29 21:42 [PATCH] Provider/rxe: Remove printf() Bob Pearson
2021-09-30 5:18 ` Leon Romanovsky
2021-09-30 20:05 ` Bob Pearson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).