[PATCH 0/2] Loopback prevention support

[PATCH 0/2] Loopback prevention support

[Eli Cohen]

Hi Doug,

This two patch series adds support for loopback prevention in mlx5_ib for
userspace consumers.

Eli

*** Resending since may have had some problem with my subscription so the
*** patchest did not make it to the rdma list

Eli Cohen (2):
  IB/mlx5: Add debug print to signify if block multicast is used
  IB/mlx5: Publish mlx5 driver support for extended create QP

 drivers/infiniband/hw/mlx5/main.c |    3 ++-
 drivers/infiniband/hw/mlx5/qp.c   |    4 ++++
 2 files changed, 6 insertions(+), 1 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/2] IB/mlx5: Add debug print to signify if block multicast is used

[Eli Cohen]

Signed-off-by: Eli Cohen <eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
 drivers/infiniband/hw/mlx5/qp.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
index 6f521a3..b80b2bd 100644
--- a/drivers/infiniband/hw/mlx5/qp.c
+++ b/drivers/infiniband/hw/mlx5/qp.c
@@ -1033,6 +1033,10 @@ static int create_qp_common(struct mlx5_ib_dev *dev, struct ib_pd *pd,
 
 	qp->mqp.event = mlx5_ib_qp_event;
 
+	/* QP related debug prints go here */
+	if (qp->flags & MLX5_IB_QP_BLOCK_MULTICAST_LOOPBACK)
+		mlx5_ib_dbg(dev, "QP 0x%x will block multicast\n", qp->mqp.qpn);
+
 	return 0;
 
 err_create:
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] IB/mlx5: Publish mlx5 driver support for extended create QP

[Eli Cohen]

Signed-off-by: Eli Cohen <eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
 drivers/infiniband/hw/mlx5/main.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
index f1ccd40..634de84 100644
--- a/drivers/infiniband/hw/mlx5/main.c
+++ b/drivers/infiniband/hw/mlx5/main.c
@@ -1385,7 +1385,8 @@ static void *mlx5_ib_add(struct mlx5_core_dev *mdev)
 		(1ull << IB_USER_VERBS_CMD_CREATE_XSRQ)		|
 		(1ull << IB_USER_VERBS_CMD_OPEN_QP);
 	dev->ib_dev.uverbs_ex_cmd_mask =
-		(1ull << IB_USER_VERBS_EX_CMD_QUERY_DEVICE);
+		(1ull << IB_USER_VERBS_EX_CMD_QUERY_DEVICE)	|
+		(1ull << IB_USER_VERBS_EX_CMD_CREATE_QP);
 
 	dev->ib_dev.query_device	= mlx5_ib_query_device;
 	dev->ib_dev.query_port		= mlx5_ib_query_port;
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] IB/mlx5: Publish mlx5 driver support for extended create QP

[Jason Gunthorpe]

On Wed, Oct 28, 2015 at 02:58:35AM +0200, Eli Cohen wrote:
> Signed-off-by: Eli Cohen <eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>  drivers/infiniband/hw/mlx5/main.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
> index f1ccd40..634de84 100644
> +++ b/drivers/infiniband/hw/mlx5/main.c
> @@ -1385,7 +1385,8 @@ static void *mlx5_ib_add(struct mlx5_core_dev *mdev)
>  		(1ull << IB_USER_VERBS_CMD_CREATE_XSRQ)		|
>  		(1ull << IB_USER_VERBS_CMD_OPEN_QP);
>  	dev->ib_dev.uverbs_ex_cmd_mask =
> -		(1ull << IB_USER_VERBS_EX_CMD_QUERY_DEVICE);
> +		(1ull << IB_USER_VERBS_EX_CMD_QUERY_DEVICE)	|
> +		(1ull << IB_USER_VERBS_EX_CMD_CREATE_QP);

Same comment as last time.

http://thread.gmane.org/gmane.linux.drivers.rdma/26110/focus=26163

This still hasn't been fixed.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 2/2] IB/mlx5: Publish mlx5 driver support for extended create QP

[Eli Cohen]

> Same comment as last time.
>
> http://thread.gmane.org/gmane.linux.drivers.rdma/26110/focus=26163
>
>This still hasn't been fixed.

Jason,

The relevant IB core patches have been accepted. Can you elaborate more on
what your comments against this are?

https://github.com/dledford/linux/commit/6d8a74972b7115b41d4d17a4444c026755ca24be


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] IB/mlx5: Publish mlx5 driver support for extended create QP

[Jason Gunthorpe]

On Wed, Oct 28, 2015 at 06:18:27PM +0000, Eli Cohen wrote:
> > Same comment as last time.
> >
> > http://thread.gmane.org/gmane.linux.drivers.rdma/26110/focus=26163
> >
> >This still hasn't been fixed.
> 
> Jason,
> 
> The relevant IB core patches have been accepted. Can you elaborate more on
> what your comments against this are?

Did you read the above thread?

Don't set uverbs_ex_cmd_mask in drivers.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 2/2] IB/mlx5: Publish mlx5 driver support for extended create QP

[Eli Cohen]

> Did you read the above thread?
>
> Don't set uverbs_ex_cmd_mask in drivers.

But that's not how it is currently. IB core does not set any of the extended verbs flags for all the devices.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] IB/mlx5: Publish mlx5 driver support for extended create QP

[Jason Gunthorpe]

On Wed, Oct 28, 2015 at 06:44:05PM +0000, Eli Cohen wrote:
> > Did you read the above thread?
> >
> > Don't set uverbs_ex_cmd_mask in drivers.
> 
> But that's not how it is currently. IB core does not set any of the
> extended verbs flags for all the devices.

We agreed it would be fixed as a follow up patch so the timestamp
stuff could move forward. That patch never came, and now it is needed
before more stuff does this wrong.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 2/2] IB/mlx5: Publish mlx5 driver support for extended create QP

[Eli Cohen]

Following this email is another one with the fix.

-----Original Message-----
From: Jason Gunthorpe [mailto:jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org] 
Sent: Wednesday, October 28, 2015 2:20 PM
To: Eli Cohen <eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org; linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>; Eran Ben Elisha <eranbe-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>; cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH 2/2] IB/mlx5: Publish mlx5 driver support for extended create QP

On Wed, Oct 28, 2015 at 06:44:05PM +0000, Eli Cohen wrote:
> > Did you read the above thread?
> >
> > Don't set uverbs_ex_cmd_mask in drivers.
> 
> But that's not how it is currently. IB core does not set any of the 
> extended verbs flags for all the devices.

We agreed it would be fixed as a follow up patch so the timestamp stuff could move forward. That patch never came, and now it is needed before more stuff does this wrong.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html