From: dennis.dalessandro@cornelisnetworks.com
To: dledford@redhat.com, jgg@ziepe.ca
Cc: linux-rdma@vger.kernel.org, Kaike Wan <kaike.wan@intel.com>,
<stable@vger.kernel.org>,
Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Subject: [PATCH for-rc 1/4] IB/hfi1: Call xa_destroy before freeing dummy_netdev
Date: Mon, 29 Mar 2021 09:48:17 -0400 [thread overview]
Message-ID: <1617025700-31865-2-git-send-email-dennis.dalessandro@cornelisnetworks.com> (raw)
In-Reply-To: <1617025700-31865-1-git-send-email-dennis.dalessandro@cornelisnetworks.com>
From: Kaike Wan <kaike.wan@intel.com>
Before the dummy_netdev is freeed, xa_destroy() should be called to
free any internal objects to avoid potential memory leak.
Fixes: 06bde82c72d5 ("IB/hfi1: Add rx functions for dummy netdev")
Cc: <stable@vger.kernel.org>
Reviewed-by: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
Signed-off-by: Kaike Wan <kaike.wan@intel.com>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
---
drivers/infiniband/hw/hfi1/netdev_rx.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/infiniband/hw/hfi1/netdev_rx.c b/drivers/infiniband/hw/hfi1/netdev_rx.c
index 2c8bc02..cec02e8 100644
--- a/drivers/infiniband/hw/hfi1/netdev_rx.c
+++ b/drivers/infiniband/hw/hfi1/netdev_rx.c
@@ -372,7 +372,11 @@ int hfi1_netdev_alloc(struct hfi1_devdata *dd)
void hfi1_netdev_free(struct hfi1_devdata *dd)
{
if (dd->dummy_netdev) {
+ struct hfi1_netdev_priv *priv =
+ hfi1_netdev_priv(dd->dummy_netdev);
+
dd_dev_info(dd, "hfi1 netdev freed\n");
+ xa_destroy(&priv->dev_tbl);
kfree(dd->dummy_netdev);
dd->dummy_netdev = NULL;
}
--
1.8.3.1
next prev parent reply other threads:[~2021-03-29 13:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 13:48 [PATCH for-rc 0/4] hfi fixes dennis.dalessandro
2021-03-29 13:48 ` dennis.dalessandro [this message]
2021-03-29 14:09 ` [PATCH for-rc 1/4] IB/hfi1: Call xa_destroy before freeing dummy_netdev Jason Gunthorpe
2021-03-31 19:36 ` Dennis Dalessandro
2021-04-01 6:06 ` Greg KH
2021-04-01 14:02 ` Dennis Dalessandro
2021-04-01 14:12 ` Greg KH
2021-04-01 15:00 ` Dennis Dalessandro
2021-04-01 12:33 ` Jason Gunthorpe
2021-04-01 13:42 ` Wan, Kaike
2021-04-01 13:48 ` Jason Gunthorpe
2021-03-29 13:48 ` [PATCH for-rc 2/4] IB/hfi1: Call xa_destroy before unloading the module dennis.dalessandro
2021-03-29 14:11 ` Jason Gunthorpe
2021-04-08 13:30 ` Dennis Dalessandro
2021-03-29 13:48 ` [PATCH for-rc 3/4] IB/hfi1: Fix probe time panic when AIP is enabled with a buggy BIOS dennis.dalessandro
2021-04-07 23:04 ` Jason Gunthorpe
2021-03-29 13:48 ` [PATCH for-rc 4/4] IB/hfi1: Fix regressions in security fix dennis.dalessandro
2021-03-29 18:36 ` Ira Weiny
2021-04-07 18:33 ` Jason Gunthorpe
2021-04-07 20:20 ` Dennis Dalessandro
2021-04-13 22:55 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1617025700-31865-2-git-send-email-dennis.dalessandro@cornelisnetworks.com \
--to=dennis.dalessandro@cornelisnetworks.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kaike.wan@intel.com \
--cc=linux-rdma@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).