From: Jason Gunthorpe <jgg@ziepe.ca>
To: dennis.dalessandro@cornelisnetworks.com
Cc: dledford@redhat.com, linux-rdma@vger.kernel.org,
Kaike Wan <kaike.wan@intel.com>,
stable@vger.kernel.org
Subject: Re: [PATCH for-rc 2/4] IB/hfi1: Call xa_destroy before unloading the module
Date: Mon, 29 Mar 2021 11:11:23 -0300 [thread overview]
Message-ID: <20210329141123.GQ2710221@ziepe.ca> (raw)
In-Reply-To: <1617025700-31865-3-git-send-email-dennis.dalessandro@cornelisnetworks.com>
On Mon, Mar 29, 2021 at 09:48:18AM -0400, dennis.dalessandro@cornelisnetworks.com wrote:
> From: Kaike Wan <kaike.wan@intel.com>
>
> Call xa_destroy for hfi1_dev_table before unloading the module to avoid
> a potential memory leak.
Do you hit the WARN_ON or not?
Is this all just mindless?
If the xarray is supposed to be empty because everything was erased
then you don't need it, the WARN_ON is correct. An empty xarray needs
no further destruction.
Jason
next prev parent reply other threads:[~2021-03-29 14:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 13:48 [PATCH for-rc 0/4] hfi fixes dennis.dalessandro
2021-03-29 13:48 ` [PATCH for-rc 1/4] IB/hfi1: Call xa_destroy before freeing dummy_netdev dennis.dalessandro
2021-03-29 14:09 ` Jason Gunthorpe
2021-03-31 19:36 ` Dennis Dalessandro
2021-04-01 6:06 ` Greg KH
2021-04-01 14:02 ` Dennis Dalessandro
2021-04-01 14:12 ` Greg KH
2021-04-01 15:00 ` Dennis Dalessandro
2021-04-01 12:33 ` Jason Gunthorpe
2021-04-01 13:42 ` Wan, Kaike
2021-04-01 13:48 ` Jason Gunthorpe
2021-03-29 13:48 ` [PATCH for-rc 2/4] IB/hfi1: Call xa_destroy before unloading the module dennis.dalessandro
2021-03-29 14:11 ` Jason Gunthorpe [this message]
2021-04-08 13:30 ` Dennis Dalessandro
2021-03-29 13:48 ` [PATCH for-rc 3/4] IB/hfi1: Fix probe time panic when AIP is enabled with a buggy BIOS dennis.dalessandro
2021-04-07 23:04 ` Jason Gunthorpe
2021-03-29 13:48 ` [PATCH for-rc 4/4] IB/hfi1: Fix regressions in security fix dennis.dalessandro
2021-03-29 18:36 ` Ira Weiny
2021-04-07 18:33 ` Jason Gunthorpe
2021-04-07 20:20 ` Dennis Dalessandro
2021-04-13 22:55 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210329141123.GQ2710221@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=dledford@redhat.com \
--cc=kaike.wan@intel.com \
--cc=linux-rdma@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).