RE: [PATCH] infiniband:core:Fix assumation that the function ib_send_cm_drep never fails in rdma_disconnect

* RE: [PATCH] infiniband:core:Fix assumation that the function ib_send_cm_drep never fails in rdma_disconnect
       [not found] ` <1441747679-10898-1-git-send-email-xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2015-09-08 21:32   ` Hefty, Sean
  0 siblings, 0 replies; only message in thread
From: Hefty, Sean @ 2015-09-08 21:32 UTC (permalink / raw)
  To: Nicholas Krause, dledford-H+wXaHxf7aLQT0dZR+AlfA
  Cc: hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w,
	jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/,
	Weiny, Ira, yun.wang-EIkl63zCoXaH+58JC4qpiA,
	sagig-VPRAkNaXOzVWk0Htik3J/w,
	swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW,
	Matt-goXnUAHYgFxWk0Htik3J/w, linux-rdma-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

> This fixes the incorrect assumation that the function ib_send_cm_drep
> always runs successfully and never fails in the function rdma_disconnect
> by making this call be assigned the variable used to return to callers
> of rdma_disconnect in order to make sure that a error code is returned
> if a failure occurs with this call in order for the caller to handle.

It's not assuming that it doesn't fail.  It's saying that it doesn't care that it does.  The call to send a DREP is optimistic and correct in most circumstances.  The app is done at this point, and the connection has been disconnected.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] only message in thread