From: Gal Pressman <galpress@amazon.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Doug Ledford <dledford@redhat.com>, <linux-rdma@vger.kernel.org>,
Alexander Matushevsky <matua@amazon.com>,
Firas JahJah <firasj@amazon.com>,
Yossi Leybovich <sleybo@amazon.com>
Subject: Re: [PATCH for-next v2 1/2] RDMA/efa: Fix setting of wrong bit in get/set_feature commands
Date: Wed, 20 May 2020 11:03:00 +0300 [thread overview]
Message-ID: <1a80d736-3fde-0aca-f04a-d416742bf3ff@amazon.com> (raw)
In-Reply-To: <20200520000428.GA6797@ziepe.ca>
On 20/05/2020 3:04, Jason Gunthorpe wrote:
> On Tue, May 12, 2020 at 06:22:03PM +0300, Gal Pressman wrote:
>> When using a control buffer the ctrl_data bit should be set in order to
>> indicate the control buffer address is valid, not ctrl_data_indirect
>> which is used when the control buffer itself is indirect.
>>
>> Reviewed-by: Firas JahJah <firasj@amazon.com>
>> Reviewed-by: Yossi Leybovich <sleybo@amazon.com>
>> Signed-off-by: Gal Pressman <galpress@amazon.com>
>> ---
>> drivers/infiniband/hw/efa/efa_com_cmd.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> No fixes line??
The reason I didn't add a fixes line (and sent it to for-next) is that it turns
out this is the first set feature command to use a control buffer so nothing was
broken, but this is necessary for patch #2 to work.
next prev parent reply other threads:[~2020-05-20 8:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 15:22 [PATCH for-next v2 0/2] EFA host information Gal Pressman
2020-05-12 15:22 ` [PATCH for-next v2 1/2] RDMA/efa: Fix setting of wrong bit in get/set_feature commands Gal Pressman
2020-05-20 0:04 ` Jason Gunthorpe
2020-05-20 8:03 ` Gal Pressman [this message]
2020-05-21 13:57 ` Jason Gunthorpe
2020-05-21 14:06 ` Gal Pressman
2020-05-21 14:11 ` Jason Gunthorpe
2020-05-12 15:22 ` [PATCH for-next v2 2/2] RDMA/efa: Report host information to the device Gal Pressman
2020-05-20 0:07 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a80d736-3fde-0aca-f04a-d416742bf3ff@amazon.com \
--to=galpress@amazon.com \
--cc=dledford@redhat.com \
--cc=firasj@amazon.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=matua@amazon.com \
--cc=sleybo@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).