* [PATCH 2/3] iw_cxgb4: drop listen destroy replies if no ep found
@ 2017-09-05 18:52 Steve Wise
2017-09-15 16:46 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Steve Wise @ 2017-09-05 18:52 UTC (permalink / raw)
To: dledford; +Cc: linux-rdma, stable
If the thread waiting for a CLOSE_LISTSRV_RPL times out and bails,
then we need to handle a subsequent CPL if it arrives and the stid has
been released. In this case silently drop it.
Signed-off-by: Steve Wise <swise@opengridcomputing.com>
---
drivers/infiniband/hw/cxgb4/cm.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index 6d85a5d..d76bfe3 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband/hw/cxgb4/cm.c
@@ -2333,9 +2333,14 @@ static int close_listsrv_rpl(struct c4iw_dev *dev, struct sk_buff *skb)
unsigned int stid = GET_TID(rpl);
struct c4iw_listen_ep *ep = get_ep_from_stid(dev, stid);
+ if (!ep) {
+ pr_debug("%s stid %d lookup failure!\n", __func__, stid);
+ goto out;
+ }
pr_debug("%s ep %p\n", __func__, ep);
c4iw_wake_up(&ep->com.wr_wait, status2errno(rpl->status));
c4iw_put_ep(&ep->com);
+out:
return 0;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/3] iw_cxgb4: drop listen destroy replies if no ep found
2017-09-05 18:52 [PATCH 2/3] iw_cxgb4: drop listen destroy replies if no ep found Steve Wise
@ 2017-09-15 16:46 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2017-09-15 16:46 UTC (permalink / raw)
To: Steve Wise; +Cc: dledford, linux-rdma, stable
On Tue, Sep 05, 2017 at 11:52:33AM -0700, Steve Wise wrote:
> If the thread waiting for a CLOSE_LISTSRV_RPL times out and bails,
> then we need to handle a subsequent CPL if it arrives and the stid has
> been released. In this case silently drop it.
>
> Signed-off-by: Steve Wise <swise@opengridcomputing.com>
> ---
> drivers/infiniband/hw/cxgb4/cm.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
> index 6d85a5d..d76bfe3 100644
> --- a/drivers/infiniband/hw/cxgb4/cm.c
> +++ b/drivers/infiniband/hw/cxgb4/cm.c
> @@ -2333,9 +2333,14 @@ static int close_listsrv_rpl(struct c4iw_dev *dev, struct sk_buff *skb)
> unsigned int stid = GET_TID(rpl);
> struct c4iw_listen_ep *ep = get_ep_from_stid(dev, stid);
>
> + if (!ep) {
> + pr_debug("%s stid %d lookup failure!\n", __func__, stid);
> + goto out;
> + }
> pr_debug("%s ep %p\n", __func__, ep);
> c4iw_wake_up(&ep->com.wr_wait, status2errno(rpl->status));
> c4iw_put_ep(&ep->com);
> +out:
> return 0;
> }
>
> --
> 1.8.3.1
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-15 16:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-05 18:52 [PATCH 2/3] iw_cxgb4: drop listen destroy replies if no ep found Steve Wise
2017-09-15 16:46 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).