linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: 'Greg KH' <gregkh@linuxfoundation.org>
To: Steve Wise <swise@opengridcomputing.com>
Cc: dledford@redhat.com, linux-rdma@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 3/3] iw_cxgb4: remove the stid on listen create failure
Date: Fri, 15 Sep 2017 11:59:05 -0700	[thread overview]
Message-ID: <20170915185905.GA22953@kroah.com> (raw)
In-Reply-To: <019a01d32e53$9ccadc60$d6609520$@opengridcomputing.com>

On Fri, Sep 15, 2017 at 01:51:17PM -0500, Steve Wise wrote:
> > Subject: Re: [PATCH 3/3] iw_cxgb4: remove the stid on listen create failure
> > 
> > On Tue, Sep 05, 2017 at 11:52:34AM -0700, Steve Wise wrote:
> > > Signed-off-by: Steve Wise <swise@opengridcomputing.com>
> > > ---
> > >  drivers/infiniband/hw/cxgb4/cm.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > I know I sure don't take patches without changelog text, and for sure
> > that could never go into a stable tree...
> 
> I thought the one line commit log was sufficient.  I'll be more verbose.

All you are saying in the subject was _what_ you did, which does nothing
to explain _why_ you did it.  Especially for something you feel needs to
be fixed in older kernels you need to explain why it is all needed.

Changelog descriptions are hard, usually harder than writing the
original patch.  Welcome to good software engineering practices :)

thanks,

greg k-h

      reply	other threads:[~2017-09-15 18:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-05 18:52 [PATCH 3/3] iw_cxgb4: remove the stid on listen create failure Steve Wise
2017-09-15 16:46 ` Greg KH
2017-09-15 18:51   ` Steve Wise
2017-09-15 18:59     ` 'Greg KH' [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170915185905.GA22953@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dledford@redhat.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=swise@opengridcomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).