[PATCH 3/3] iw_cxgb4: remove the stid on listen create failure

[PATCH 3/3] iw_cxgb4: remove the stid on listen create failure

[Steve Wise]

Signed-off-by: Steve Wise <swise@opengridcomputing.com>
---
 drivers/infiniband/hw/cxgb4/cm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index d76bfe3..ca846fb 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband/hw/cxgb4/cm.c
@@ -3463,7 +3463,7 @@ int c4iw_create_listen(struct iw_cm_id *cm_id, int backlog)
 		cm_id->provider_data = ep;
 		goto out;
 	}
-
+	remove_handle(ep->com.dev, &ep->com.dev->stid_idr, ep->stid);
 	cxgb4_free_stid(ep->com.dev->rdev.lldi.tids, ep->stid,
 			ep->com.local_addr.ss_family);
 fail2:
-- 
1.8.3.1

Re: [PATCH 3/3] iw_cxgb4: remove the stid on listen create failure

[Greg KH]

On Tue, Sep 05, 2017 at 11:52:34AM -0700, Steve Wise wrote:
> Signed-off-by: Steve Wise <swise@opengridcomputing.com>
> ---
>  drivers/infiniband/hw/cxgb4/cm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I know I sure don't take patches without changelog text, and for sure
that could never go into a stable tree...

RE: [PATCH 3/3] iw_cxgb4: remove the stid on listen create failure

[Steve Wise]

> Subject: Re: [PATCH 3/3] iw_cxgb4: remove the stid on listen create failure
> 
> On Tue, Sep 05, 2017 at 11:52:34AM -0700, Steve Wise wrote:
> > Signed-off-by: Steve Wise <swise@opengridcomputing.com>
> > ---
> >  drivers/infiniband/hw/cxgb4/cm.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> I know I sure don't take patches without changelog text, and for sure
> that could never go into a stable tree...

I thought the one line commit log was sufficient.  I'll be more verbose.

Thanks,

Steve.

Re: [PATCH 3/3] iw_cxgb4: remove the stid on listen create failure

['Greg KH']

On Fri, Sep 15, 2017 at 01:51:17PM -0500, Steve Wise wrote:
> > Subject: Re: [PATCH 3/3] iw_cxgb4: remove the stid on listen create failure
> > 
> > On Tue, Sep 05, 2017 at 11:52:34AM -0700, Steve Wise wrote:
> > > Signed-off-by: Steve Wise <swise@opengridcomputing.com>
> > > ---
> > >  drivers/infiniband/hw/cxgb4/cm.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > I know I sure don't take patches without changelog text, and for sure
> > that could never go into a stable tree...
> 
> I thought the one line commit log was sufficient.  I'll be more verbose.

All you are saying in the subject was _what_ you did, which does nothing
to explain _why_ you did it.  Especially for something you feel needs to
be fixed in older kernels you need to explain why it is all needed.

Changelog descriptions are hard, usually harder than writing the
original patch.  Welcome to good software engineering practices :)

thanks,

greg k-h