Re: [PATCH rdma-core 07/10] providers: Use the new common PCI matching infrastructure

From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: "Amrani, Ram" <Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Devesh Sharma
	<Devesh.sharma-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
	Mike Marciniszyn
	<mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Dennis Dalessandro
	<dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Tatyana Nikolova
	<Tatyana.E.Nikolova-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Yishai Hadas <yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Vladimir Sokolovsky
	<vlad-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	"Elior,
	Ariel" <Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>,
	Adit Ranadive <aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>,
	"pv-drivers-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org"
	<pv-drivers-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH rdma-core 07/10] providers: Use the new common PCI matching infrastructure
Date: Sun, 24 Sep 2017 09:58:45 -0600	[thread overview]
Message-ID: <20170924155845.GB14796@obsidianresearch.com> (raw)
In-Reply-To: <BN3PR07MB2578333789DA041401297EC0F8650-EldUQEzkDQfpW3VS/XPqkOFPX92sqiQdvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>

On Sun, Sep 24, 2017 at 01:29:09PM +0000, Amrani, Ram wrote:
> >  static struct verbs_device *qedr_device_alloc(struct verbs_sysfs_dev *sysfs_dev)
> >  {
> >  	struct qelr_device *dev;
> > @@ -269,7 +238,7 @@ static const struct verbs_device_ops qelr_dev_ops = {
> >  	.name = "qelr",
> 
> Should this be the driver name or the library name?
> The driver name is qedr and the library name is libqedr. It is usually abbreviated to qelr.
> I reckon that this should be the driver name (otherwise auto-load will fail?!).

I will fix all the names, it is confusing as all the other drivers use
their lib name as prefix..

The above string is only used for diagnostic prints.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html