From: Leon Romanovsky <leon@kernel.org>
To: David Ahern <dsahern@gmail.com>
Cc: Steve Wise <swise@opengridcomputing.com>,
stephen@networkplumber.org, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes
Date: Sun, 13 May 2018 16:10:04 +0300 [thread overview]
Message-ID: <20180513131004.GD10381@mtr-leonro.mtl.com> (raw)
In-Reply-To: <06d8cb88-21e0-b7cc-10e2-efa453d9adc9@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1585 bytes --]
On Thu, May 10, 2018 at 08:20:51AM -0600, David Ahern wrote:
> On 5/10/18 8:19 AM, Steve Wise wrote:
> >
> > On 5/9/2018 11:08 PM, David Ahern wrote:
> >> On 5/7/18 9:53 AM, Steve Wise wrote:
> >>> @@ -152,7 +153,10 @@ int main(int argc, char **argv)
> >>> pretty_output = true;
> >>> break;
> >>> case 'd':
> >>> - show_details = true;
> >>> + if (show_details)
> >>> + show_driver_details = true;
> >>> + else
> >>> + show_details = true;
> >>> break;
> >>> case 'j':
> >>> json_output = true;
> >> The above change should be reflected in the man page.
> >
> > I did mention it in the man page:
> >
> > -d, --details
> > Output detailed information. Adding a second -d includes
> > driver-specific details.
> >
> > But I wasn't sure how to show it in the syntax. Maybe this?
> >
> > OPTIONS := { -V[ersion] | -d[etails] [-d[etails]] } -j[son] } -p[retty] }
>
> I should have read the second patch before commenting. Didn't it have
> first -d = details, a second -d = driver details? That should be fine.
Yes, our idea is to require "-dd" to print such driver specific
information. The level of nesting is:
* No arguments -> info usable for most of the users
* -d - pre-parsed flags and rarely used information.
* -dd - very detailed output, can be very specific to device.
Thanks
>
> >
> >
> >> Also, the set needs to be respun after I merged master where Stephen
> >> brought in updates to the uapi files.
> >
> > Will do. Thanks for reviewing.
> >
> > Steve.
> >
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2018-05-13 13:10 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 16:06 [PATCH v1 iproute2-next 0/3] RDMA tool driver-specific resource tracking Steve Wise
2018-05-07 15:53 ` [PATCH v1 iproute2-next 1/3] rdma: update rdma_netlink.h to get driver attrs Steve Wise
2018-05-13 13:15 ` Leon Romanovsky
2018-05-14 15:15 ` Steve Wise
2018-05-07 15:53 ` [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes Steve Wise
2018-05-10 4:08 ` David Ahern
2018-05-10 14:19 ` Steve Wise
2018-05-10 14:20 ` David Ahern
2018-05-13 13:10 ` Leon Romanovsky [this message]
2018-05-13 13:24 ` Leon Romanovsky
2018-05-14 14:51 ` Steve Wise
2018-05-15 16:35 ` Doug Ledford
2018-05-15 16:59 ` Leon Romanovsky
2018-05-15 17:51 ` Steve Wise
2018-05-15 18:00 ` Doug Ledford
2018-05-14 20:41 ` Jason Gunthorpe
2018-05-14 22:04 ` Steve Wise
2018-05-15 8:54 ` Leon Romanovsky
2018-05-15 13:04 ` Steve Wise
2018-05-15 13:18 ` Steve Wise
2018-05-15 13:53 ` Jason Gunthorpe
2018-05-15 14:31 ` Steve Wise
2018-05-15 14:44 ` Jason Gunthorpe
2018-05-15 15:02 ` Steve Wise
2018-05-15 15:14 ` Jason Gunthorpe
2018-05-07 15:53 ` [PATCH v1 iproute2-next 3/3] rdma: update man pages Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180513131004.GD10381@mtr-leonro.mtl.com \
--to=leon@kernel.org \
--cc=dsahern@gmail.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).