Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

From: Steve Wise <swise@opengridcomputing.com>
To: David Ahern <dsahern@gmail.com>, leon@kernel.org
Cc: stephen@networkplumber.org, netdev@vger.kernel.org,
	linux-rdma@vger.kernel.org
Subject: Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes
Date: Thu, 10 May 2018 09:19:28 -0500	[thread overview]
Message-ID: <e94d0444-fcda-3a62-3b12-3b9e6ff23119@opengridcomputing.com> (raw)
In-Reply-To: <06375fd7-f241-74ad-70ce-a670100bf060@gmail.com>

On 5/9/2018 11:08 PM, David Ahern wrote:
> On 5/7/18 9:53 AM, Steve Wise wrote:
>> @@ -152,7 +153,10 @@ int main(int argc, char **argv)
>>  			pretty_output = true;
>>  			break;
>>  		case 'd':
>> -			show_details = true;
>> +			if (show_details)
>> +				show_driver_details = true;
>> +			else
>> +				show_details = true;
>>  			break;
>>  		case 'j':
>>  			json_output = true;
> The above change should be reflected in the man page.

I did mention it in the man page:

       -d, --details
              Output detailed information.  Adding a second -d includes
driver-specific details.

But I wasn't sure how to show it in the syntax.  Maybe this?

 OPTIONS := { -V[ersion] | -d[etails] [-d[etails]] } -j[son] } -p[retty] }

> Also, the set needs to be respun after I merged master where Stephen
> brought in updates to the uapi files.

Will do.  Thanks for reviewing.

Steve.