Re: [PATCH rdma-next 2/6] RDMA/umem: Add ODP type indicator within ib_umem_odp

[Leon Romanovsky <leon@kernel.org>]

On Wed, Aug 07, 2019 at 11:44:16AM +0000, Jason Gunthorpe wrote:
> On Wed, Aug 07, 2019 at 01:33:59PM +0300, Leon Romanovsky wrote:
> > From: Erez Alfasi <ereza@mellanox.com>
> >
> > ODP type can be divided into 2 subclasses:
> > Explicit and Implicit ODP.
> >
> > Adding a type enums and an odp type flag within
> > ib_umem_odp will give us an indication whether a
> > given MR is ODP implicit/explicit registered.
> >
> > Signed-off-by: Erez Alfasi <ereza@mellanox.com>
> > Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> > ---
> >  drivers/infiniband/core/umem.c    |  1 +
> >  include/rdma/ib_umem_odp.h        | 14 ++++++++++++++
> >  include/uapi/rdma/ib_user_verbs.h |  5 +++++
> >  3 files changed, 20 insertions(+)
>
> No for this patch, I've got a series cleaning up this
> implicit/explicit nonsense, and the result is much cleaner than this.

It doesn't really clean anything, just stores implicit/explicit information.

>
> This series will have to wait.

The information exposed in this series is already available in uverbs,
so whatever cleanup will come, we still need to expose ODP MR type.

This patch is tiny part of whole series, why should we block whole
series and iproute2?

Thanks

>
> Jason