* [PATCH] RDMA/vmw_pvrdma: Free SRQ only once
@ 2019-09-18 23:08 Adit Ranadive
2019-09-19 22:50 ` Vishnu Dasa
2019-10-01 14:17 ` Jason Gunthorpe
0 siblings, 2 replies; 3+ messages in thread
From: Adit Ranadive @ 2019-09-18 23:08 UTC (permalink / raw)
To: jgg, dledford, linux-rdma; +Cc: Adit Ranadive, Pv-drivers, stable
An extra kfree cleanup was missed since these are now deallocated
by core.
Cc: <stable@vger.kernel.org>
Fixes: 68e326dea1db ("RDMA: Handle SRQ allocations by IB/core")
Signed-off-by: Adit Ranadive <aditr@vmware.com>
---
drivers/infiniband/hw/vmw_pvrdma/pvrdma_srq.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_srq.c b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_srq.c
index 6cac0c88cf39..36cdfbdbd325 100644
--- a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_srq.c
+++ b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_srq.c
@@ -230,8 +230,6 @@ static void pvrdma_free_srq(struct pvrdma_dev *dev, struct pvrdma_srq *srq)
pvrdma_page_dir_cleanup(dev, &srq->pdir);
- kfree(srq);
-
atomic_dec(&dev->num_srqs);
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] RDMA/vmw_pvrdma: Free SRQ only once
2019-09-18 23:08 [PATCH] RDMA/vmw_pvrdma: Free SRQ only once Adit Ranadive
@ 2019-09-19 22:50 ` Vishnu Dasa
2019-10-01 14:17 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Vishnu Dasa @ 2019-09-19 22:50 UTC (permalink / raw)
To: Adit Ranadive, jgg, dledford, linux-rdma; +Cc: Pv-drivers, stable
On 9/18/19, 4:08 PM, "Adit Ranadive" <aditr@vmware.com> wrote:
>An extra kfree cleanup was missed since these are now deallocated
>by core.
>
>Cc: <stable@vger.kernel.org>
>Fixes: 68e326dea1db ("RDMA: Handle SRQ allocations by IB/core")
>Signed-off-by: Adit Ranadive <aditr@vmware.com>
>---
> drivers/infiniband/hw/vmw_pvrdma/pvrdma_srq.c | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_srq.c b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_srq.c
>index 6cac0c88cf39..36cdfbdbd325 100644
>--- a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_srq.c
>+++ b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_srq.c
>@@ -230,8 +230,6 @@ static void pvrdma_free_srq(struct pvrdma_dev *dev, struct pvrdma_srq *srq)
>
> pvrdma_page_dir_cleanup(dev, &srq->pdir);
>
>- kfree(srq);
>-
> atomic_dec(&dev->num_srqs);
> }
Thanks for the fix, looks good to me.
Reviewed-by: Vishnu Dasa <vdasa@vmware.com>
--
vishnu
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] RDMA/vmw_pvrdma: Free SRQ only once
2019-09-18 23:08 [PATCH] RDMA/vmw_pvrdma: Free SRQ only once Adit Ranadive
2019-09-19 22:50 ` Vishnu Dasa
@ 2019-10-01 14:17 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2019-10-01 14:17 UTC (permalink / raw)
To: Adit Ranadive; +Cc: dledford, linux-rdma, Pv-drivers, stable
On Wed, Sep 18, 2019 at 11:08:00PM +0000, Adit Ranadive wrote:
> An extra kfree cleanup was missed since these are now deallocated
> by core.
>
> Cc: <stable@vger.kernel.org>
> Fixes: 68e326dea1db ("RDMA: Handle SRQ allocations by IB/core")
> Signed-off-by: Adit Ranadive <aditr@vmware.com>
> Reviewed-by: Vishnu Dasa <vdasa@vmware.com>
> ---
> drivers/infiniband/hw/vmw_pvrdma/pvrdma_srq.c | 2 --
> 1 file changed, 2 deletions(-)
Applied to for-rc, thanks
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-01 14:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-18 23:08 [PATCH] RDMA/vmw_pvrdma: Free SRQ only once Adit Ranadive
2019-09-19 22:50 ` Vishnu Dasa
2019-10-01 14:17 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).