From: Leon Romanovsky <leon@kernel.org>
To: zhengbin <zhengbin13@huawei.com>
Cc: bmt@zurich.ibm.com, dledford@redhat.com, jgg@ziepe.ca,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH 1/5] RDMA/siw: use true,false for bool variable
Date: Tue, 24 Dec 2019 11:50:49 +0200 [thread overview]
Message-ID: <20191224095049.GE120310@unreal> (raw)
In-Reply-To: <1577176812-2238-2-git-send-email-zhengbin13@huawei.com>
On Tue, Dec 24, 2019 at 04:40:08PM +0800, zhengbin wrote:
> Fixes coccicheck warning:
>
> drivers/infiniband/sw/siw/siw_cm.c:32:18-41: WARNING: Assignment of 0/1 to bool variable
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
> ---
> drivers/infiniband/sw/siw/siw_cm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/sw/siw/siw_cm.c b/drivers/infiniband/sw/siw/siw_cm.c
> index 3bccfef4..0c3f058 100644
> --- a/drivers/infiniband/sw/siw/siw_cm.c
> +++ b/drivers/infiniband/sw/siw/siw_cm.c
> @@ -29,7 +29,7 @@
> * MPA_V2_RDMA_NO_RTR, MPA_V2_RDMA_READ_RTR, MPA_V2_RDMA_WRITE_RTR
> */
> static __be16 rtr_type = MPA_V2_RDMA_READ_RTR | MPA_V2_RDMA_WRITE_RTR;
> -static const bool relaxed_ird_negotiation = 1;
> +static const bool relaxed_ird_negotiation = true;
It is worth to simply delete this variable.
>
> static void siw_cm_llp_state_change(struct sock *s);
> static void siw_cm_llp_data_ready(struct sock *s);
> --
> 2.7.4
>
next prev parent reply other threads:[~2019-12-24 9:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-24 8:40 [PATCH 0/5] RDMA: use true,false for bool variable zhengbin
2019-12-24 8:40 ` [PATCH 1/5] RDMA/siw: " zhengbin
2019-12-24 9:50 ` Leon Romanovsky [this message]
2019-12-24 8:40 ` [PATCH 2/5] IB/hfi1: " zhengbin
2019-12-24 9:48 ` Leon Romanovsky
2019-12-24 8:40 ` [PATCH 3/5] IB/iser: " zhengbin
2019-12-24 8:40 ` [PATCH 4/5] RDMA/mlx4: " zhengbin
2019-12-24 9:48 ` Leon Romanovsky
2019-12-24 8:40 ` [PATCH 5/5] RDMA/mlx5: " zhengbin
2019-12-24 9:48 ` Leon Romanovsky
2020-01-03 23:15 ` [PATCH 0/5] RDMA: " Jason Gunthorpe
2020-01-04 17:25 ` Bernard Metzler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191224095049.GE120310@unreal \
--to=leon@kernel.org \
--cc=bmt@zurich.ibm.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).