From: "Bernard Metzler" <BMT@zurich.ibm.com>
To: "Jason Gunthorpe" <jgg@ziepe.ca>
Cc: "zhengbin" <zhengbin13@huawei.com>,
dledford@redhat.com, linux-rdma@vger.kernel.org
Subject: RE: [PATCH 0/5] RDMA: use true,false for bool variable
Date: Sat, 4 Jan 2020 17:25:07 +0000 [thread overview]
Message-ID: <OF3EA6B761.92B1FEB3-ON002584E5.005F3E03-002584E5.005FAF19@notes.na.collabserv.com> (raw)
In-Reply-To: <20200103231512.GA27516@ziepe.ca>
-----"Jason Gunthorpe" <jgg@ziepe.ca> wrote: -----
>To: "zhengbin" <zhengbin13@huawei.com>
>From: "Jason Gunthorpe" <jgg@ziepe.ca>
>Date: 01/04/2020 12:15AM
>Cc: bmt@zurich.ibm.com, dledford@redhat.com,
>linux-rdma@vger.kernel.org
>Subject: [EXTERNAL] Re: [PATCH 0/5] RDMA: use true,false for bool
>variable
>
>On Tue, Dec 24, 2019 at 04:40:07PM +0800, zhengbin wrote:
>> zhengbin (5):
>> RDMA/siw: use true,false for bool variable
>> IB/hfi1: use true,false for bool variable
>> IB/iser: use true,false for bool variable
>> RDMA/mlx4: use true,false for bool variable
>> RDMA/mlx5: use true,false for bool variable
>
>Applied to for-next, but Leon seems right about the funny
>relaxed_ird_negotiation that is never set, is that debugging or
>something?
>
Sorry for not coming back earlier. I had a quite severe
bicycle accident which has put me completely off for the
last two and a half weeks.
This flag was introduced with a change to the MPA setup
sequence. While siw originally insisted in correct peer
behavior (not sending data in RDMA mode until handshake
completed), this led to issues with another iWarp
implementation, which under certain circumstances brakes
the correct setup sequence. So we allowed that peer behavior,
while it brakes the spec.
If we agree that this 'permissive' behavior to be the only
behavior we want to support, we can simply remove that flag
and related code, maybe just leaving a comment at the right
place stating we are permissive?
Thanks
Bernard.
prev parent reply other threads:[~2020-01-04 17:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-24 8:40 [PATCH 0/5] RDMA: use true,false for bool variable zhengbin
2019-12-24 8:40 ` [PATCH 1/5] RDMA/siw: " zhengbin
2019-12-24 9:50 ` Leon Romanovsky
2019-12-24 8:40 ` [PATCH 2/5] IB/hfi1: " zhengbin
2019-12-24 9:48 ` Leon Romanovsky
2019-12-24 8:40 ` [PATCH 3/5] IB/iser: " zhengbin
2019-12-24 8:40 ` [PATCH 4/5] RDMA/mlx4: " zhengbin
2019-12-24 9:48 ` Leon Romanovsky
2019-12-24 8:40 ` [PATCH 5/5] RDMA/mlx5: " zhengbin
2019-12-24 9:48 ` Leon Romanovsky
2020-01-03 23:15 ` [PATCH 0/5] RDMA: " Jason Gunthorpe
2020-01-04 17:25 ` Bernard Metzler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OF3EA6B761.92B1FEB3-ON002584E5.005F3E03-002584E5.005FAF19@notes.na.collabserv.com \
--to=bmt@zurich.ibm.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).