From: Leon Romanovsky <leon@kernel.org>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: netdev@vger.kernel.org, Shannon Nelson <snelson@pensando.io>,
Jakub Kicinski <kuba@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Michal Kalderon <michal.kalderon@marvell.com>,
RDMA mailing list <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH net-next] net/core: Replace driver version to be kernel version
Date: Mon, 27 Jan 2020 07:18:54 +0200 [thread overview]
Message-ID: <20200127051854.GE3870@unreal> (raw)
In-Reply-To: <20200126222253.GX22304@unicorn.suse.cz>
On Sun, Jan 26, 2020 at 11:22:53PM +0100, Michal Kubecek wrote:
> On Sun, Jan 26, 2020 at 02:12:38PM -0800, Shannon Nelson wrote:
> > On 1/26/20 1:24 PM, Leon Romanovsky wrote:
> > > On Sun, Jan 26, 2020 at 01:17:52PM -0800, Shannon Nelson wrote:
> > > > On 1/26/20 1:08 PM, Leon Romanovsky wrote:
> > > > > The long-standing policy in kernel that we don't really care about
> > > > > out-of-tree code.
> > > > That doesn't mean we need to be aggressively against out-of-tree code. One
> > > > of the positive points about Linux and loadable modules has always been the
> > > > flexibility that allows and encourages innovation, and helps enable more
> > > > work and testing before a driver can become a fully-fledged part of the
> > > > kernel. This move actively discourages part of that flexibility and I think
> > > > it is breaking part of the usefulness of modules.
> > > You are mixing definitions, nothing stops those people to innovate and
> > > develop their code inside kernel and as standalone modules too.
> > >
> > > It just stops them to put useless driver version string inside ethtool.
> > > If they feel that their life can't be without something from 90s, they
> > > have venerable MODULE_VERSION() macro to print anything they want.
> > >
> > Part of the pain of supporting our users is getting them to give us useful
> > information about their problem. The more commands I need them to run to
> > get information about the environment, the less likely I will get anything
> > useful. We've been training our users over the years to use "ethtool -i" to
> > get a good chunk of that info, with the knowledge that the driver version is
> > only a hint, based upon the distro involved. I don't want to lose that
> > hint. If anything, I'd prefer that we added a field for UTS_RELEASE in the
> > ethtool output, but I know that's too much to ask.
>
> At the same time, I've been trying to explain both our L1/L2 support
> guys and our customers that "driver version" information reported by
> "ethtool -i" is almost useless and that if they really want to identify
> driver version, they should rather use srcversion as reported by modinfo
> or sysfs.
We went even farther and wrote simple bash script that collects all
needed information from the system.
Thanks
>
> Michal
next prev parent reply other threads:[~2020-01-27 5:18 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 13:05 [PATCH net-next] net/core: Replace driver version to be kernel version Leon Romanovsky
2020-01-23 14:40 ` Jakub Kicinski
2020-01-23 14:54 ` Leon Romanovsky
2020-01-23 15:17 ` Jakub Kicinski
2020-01-25 9:13 ` David Miller
2020-01-26 18:56 ` Shannon Nelson
2020-01-26 19:41 ` Leon Romanovsky
2020-01-26 20:49 ` Jakub Kicinski
2020-01-26 21:08 ` Leon Romanovsky
2020-01-26 21:17 ` Shannon Nelson
2020-01-26 21:24 ` Leon Romanovsky
2020-01-26 22:12 ` Shannon Nelson
2020-01-26 22:22 ` Michal Kubecek
2020-01-26 22:57 ` Shannon Nelson
2020-01-27 6:08 ` Michal Kubecek
2020-01-27 6:42 ` Leon Romanovsky
2020-01-27 5:18 ` Leon Romanovsky [this message]
2020-01-26 21:33 ` Jakub Kicinski
2020-01-26 22:21 ` Shannon Nelson
2020-01-27 5:34 ` Leon Romanovsky
2020-01-27 6:45 ` Leon Romanovsky
2020-01-27 14:21 ` Jakub Kicinski
2020-01-27 15:39 ` Leon Romanovsky
2020-01-27 5:49 ` Leon Romanovsky
2020-01-27 12:21 ` David Miller
2020-01-27 12:42 ` Leon Romanovsky
2020-01-27 12:47 ` David Miller
2020-01-27 17:57 ` Shannon Nelson
2020-01-26 20:52 ` Shannon Nelson
2020-01-26 21:19 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200127051854.GE3870@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=michal.kalderon@marvell.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=snelson@pensando.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).