From: Leon Romanovsky <leon@kernel.org>
To: Shannon Nelson <snelson@pensando.io>
Cc: Jakub Kicinski <kuba@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Michal Kalderon <michal.kalderon@marvell.com>,
linux-netdev <netdev@vger.kernel.org>,
RDMA mailing list <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH net-next] net/core: Replace driver version to be kernel version
Date: Mon, 27 Jan 2020 08:45:34 +0200 [thread overview]
Message-ID: <20200127064534.GJ3870@unreal> (raw)
In-Reply-To: <20200127053433.GF3870@unreal>
On Mon, Jan 27, 2020 at 07:34:33AM +0200, Leon Romanovsky wrote:
> On Sun, Jan 26, 2020 at 02:21:58PM -0800, Shannon Nelson wrote:
> > On 1/26/20 1:33 PM, Jakub Kicinski wrote
> > > > The long-standing policy in kernel that we don't really care about
> > > > out-of-tree code.
> > > Yeah... we all know it's not that simple :)
> > >
> > > The in-tree driver versions are meaningless and cause annoying churn
> > > when people arbitrarily bump them. If we can get people to stop doing
> > > that we'll be happy, that's all there is to it.
> > >
> > Perhaps it would be helpful if this standard was applied to all the drivers
> > equally? For example, I see that this week's ice driver update from Intel
> > was accepted with no comment on their driver version bump.
>
> Thanks, it is another great example of why trusting driver authors,
> even experienced, on specific topics is not an option.
>
> >
> > Look, if we want to stamp all in-kernel drivers with the kernel version,
> > fine. But let's do it in a way that doesn't break the out-of-tree driver
> > ability to report something else. Can we set up a macro for in-kernel
> > drivers to use in their get_drvinfo callback and require drivers to use that
> > macro? Then the out-of-tree drivers are able to replace that macro with
> > whatever they need. Just don't forcibly bash the value from higher up in
> > the stack.
>
> The thing is that we don't consider in-kernel API as stable one, so
> addition of new field which is not in use in upstream looks sketchy to
> me, but I have an idea how to solve it.
Actually, it looks like my idea is Jakub's and Michal's idea. I will use
this opportunity and remove MODULE_VERSION() too.
Thanks
>
> Thanks
>
> >
> > sln
> >
next prev parent reply other threads:[~2020-01-27 6:46 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 13:05 [PATCH net-next] net/core: Replace driver version to be kernel version Leon Romanovsky
2020-01-23 14:40 ` Jakub Kicinski
2020-01-23 14:54 ` Leon Romanovsky
2020-01-23 15:17 ` Jakub Kicinski
2020-01-25 9:13 ` David Miller
2020-01-26 18:56 ` Shannon Nelson
2020-01-26 19:41 ` Leon Romanovsky
2020-01-26 20:49 ` Jakub Kicinski
2020-01-26 21:08 ` Leon Romanovsky
2020-01-26 21:17 ` Shannon Nelson
2020-01-26 21:24 ` Leon Romanovsky
2020-01-26 22:12 ` Shannon Nelson
2020-01-26 22:22 ` Michal Kubecek
2020-01-26 22:57 ` Shannon Nelson
2020-01-27 6:08 ` Michal Kubecek
2020-01-27 6:42 ` Leon Romanovsky
2020-01-27 5:18 ` Leon Romanovsky
2020-01-26 21:33 ` Jakub Kicinski
2020-01-26 22:21 ` Shannon Nelson
2020-01-27 5:34 ` Leon Romanovsky
2020-01-27 6:45 ` Leon Romanovsky [this message]
2020-01-27 14:21 ` Jakub Kicinski
2020-01-27 15:39 ` Leon Romanovsky
2020-01-27 5:49 ` Leon Romanovsky
2020-01-27 12:21 ` David Miller
2020-01-27 12:42 ` Leon Romanovsky
2020-01-27 12:47 ` David Miller
2020-01-27 17:57 ` Shannon Nelson
2020-01-26 20:52 ` Shannon Nelson
2020-01-26 21:19 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200127064534.GJ3870@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=michal.kalderon@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=snelson@pensando.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).