* [PATCH] IB/core: Fix a bitwise vs logical OR typo
@ 2020-02-18 5:58 Dan Carpenter
2020-02-18 16:41 ` Leon Romanovsky
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2020-02-18 5:58 UTC (permalink / raw)
To: Doug Ledford, Leon Romanovsky
Cc: Jason Gunthorpe, Erez Alfasi, Maor Gottlieb, Mohamad Heib,
linux-rdma, kernel-janitors
This was supposed to be a bitwise | instead of a logical ||.
Fixes: 1dd017882e01 ("RDMA/core: Fix protection fault in get_pkey_idx_qp_list")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/infiniband/core/security.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/core/security.c b/drivers/infiniband/core/security.c
index 2b4d80393bd0..b9a36ea244d4 100644
--- a/drivers/infiniband/core/security.c
+++ b/drivers/infiniband/core/security.c
@@ -348,7 +348,7 @@ static struct ib_ports_pkeys *get_new_pps(const struct ib_qp *qp,
if ((qp_attr_mask & IB_QP_PKEY_INDEX) && (qp_attr_mask & IB_QP_PORT))
new_pps->main.state = IB_PORT_PKEY_VALID;
- if (!(qp_attr_mask & (IB_QP_PKEY_INDEX || IB_QP_PORT)) && qp_pps) {
+ if (!(qp_attr_mask & (IB_QP_PKEY_INDEX | IB_QP_PORT)) && qp_pps) {
new_pps->main.port_num = qp_pps->main.port_num;
new_pps->main.pkey_index = qp_pps->main.pkey_index;
if (qp_pps->main.state != IB_PORT_PKEY_NOT_VALID)
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] IB/core: Fix a bitwise vs logical OR typo
2020-02-18 5:58 [PATCH] IB/core: Fix a bitwise vs logical OR typo Dan Carpenter
@ 2020-02-18 16:41 ` Leon Romanovsky
0 siblings, 0 replies; 2+ messages in thread
From: Leon Romanovsky @ 2020-02-18 16:41 UTC (permalink / raw)
To: Dan Carpenter
Cc: Doug Ledford, Jason Gunthorpe, Erez Alfasi, Maor Gottlieb,
Mohamad Heib, linux-rdma, kernel-janitors
On Tue, Feb 18, 2020 at 08:58:01AM +0300, Dan Carpenter wrote:
> This was supposed to be a bitwise | instead of a logical ||.
>
> Fixes: 1dd017882e01 ("RDMA/core: Fix protection fault in get_pkey_idx_qp_list")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/infiniband/core/security.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Thanks,
There is an extra patch for that.
https://lore.kernel.org/lkml/20200217204318.13609-1-natechancellor@gmail.com
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-18 16:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-18 5:58 [PATCH] IB/core: Fix a bitwise vs logical OR typo Dan Carpenter
2020-02-18 16:41 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).