* [PATCH rdma-rc] RDMA/mlx5: Prevent UMR usage with RO only when we have RO caps
@ 2020-02-27 11:38 Leon Romanovsky
2020-02-28 16:56 ` Jason Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: Leon Romanovsky @ 2020-02-27 11:38 UTC (permalink / raw)
To: Doug Ledford, Jason Gunthorpe
Cc: Michael Guralnik, linux-rdma, Maor Gottlieb, Yishai Hadas
From: Michael Guralnik <michaelgur@mellanox.com>
Relaxed ordering is not supported in UMR so we are disabling UMR usage
when user passes relaxed ordering access flag.
Enable using UMR when user requested relaxed ordering but there are no
relaxed ordering capabilities.
This will prevent user from unnecessarily registering a new mkey.
Fixes: d6de0bb1850f ("RDMA/mlx5: Set relaxed ordering when requested")
Signed-off-by: Michael Guralnik <michaelgur@mellanox.com>
Reviewed-by: Maor Gottlieb <maorg@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
---
drivers/infiniband/hw/mlx5/mlx5_ib.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/mlx5/mlx5_ib.h b/drivers/infiniband/hw/mlx5/mlx5_ib.h
index d9bffcc93587..f21d446249b8 100644
--- a/drivers/infiniband/hw/mlx5/mlx5_ib.h
+++ b/drivers/infiniband/hw/mlx5/mlx5_ib.h
@@ -1532,7 +1532,9 @@ static inline bool mlx5_ib_can_use_umr(struct mlx5_ib_dev *dev,
MLX5_CAP_GEN(dev->mdev, umr_modify_atomic_disabled))
return false;
- if (access_flags & IB_ACCESS_RELAXED_ORDERING)
+ if (access_flags & IB_ACCESS_RELAXED_ORDERING &&
+ (MLX5_CAP_GEN(dev->mdev, relaxed_ordering_write) ||
+ MLX5_CAP_GEN(dev->mdev, relaxed_ordering_read)))
return false;
return true;
--
2.24.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH rdma-rc] RDMA/mlx5: Prevent UMR usage with RO only when we have RO caps
2020-02-27 11:38 [PATCH rdma-rc] RDMA/mlx5: Prevent UMR usage with RO only when we have RO caps Leon Romanovsky
@ 2020-02-28 16:56 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2020-02-28 16:56 UTC (permalink / raw)
To: Leon Romanovsky
Cc: Doug Ledford, Michael Guralnik, linux-rdma, Maor Gottlieb, Yishai Hadas
On Thu, Feb 27, 2020 at 01:38:34PM +0200, Leon Romanovsky wrote:
> From: Michael Guralnik <michaelgur@mellanox.com>
>
> Relaxed ordering is not supported in UMR so we are disabling UMR usage
> when user passes relaxed ordering access flag.
>
> Enable using UMR when user requested relaxed ordering but there are no
> relaxed ordering capabilities.
> This will prevent user from unnecessarily registering a new mkey.
>
> Fixes: d6de0bb1850f ("RDMA/mlx5: Set relaxed ordering when requested")
> Signed-off-by: Michael Guralnik <michaelgur@mellanox.com>
> Reviewed-by: Maor Gottlieb <maorg@mellanox.com>
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---
> drivers/infiniband/hw/mlx5/mlx5_ib.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
This doesn't seem very rc-ish, applied to for-next
Thanks,
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-28 16:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-27 11:38 [PATCH rdma-rc] RDMA/mlx5: Prevent UMR usage with RO only when we have RO caps Leon Romanovsky
2020-02-28 16:56 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).