From: "J. Bruce Fields" <bfields@fieldses.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: linux-nfs@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH v2 00/29] Possible NFSD patches for v5.8
Date: Tue, 19 May 2020 12:11:08 -0400 [thread overview]
Message-ID: <20200519161108.GD25858@fieldses.org> (raw)
In-Reply-To: <20200512211640.5826.77139.stgit@klimt.1015granger.net>
I'm getting a repeatable timeout failure on python 4.0 test WRT15. In
pynfs, run:
./nfs4.0/testserver.py server:/export/path --rundeps --maketree WRT15
Looks like it sends WRITE+GETATTR(FATTR4_SIZE) compounds with write
offset 0 and write length taking on every value from 0 to 8192.
Probably an xdr decoding bug of some kind?
I don't see anything in the server logs.
--b.
On Tue, May 12, 2020 at 05:22:04PM -0400, Chuck Lever wrote:
> Available to view:
> https://git.linux-nfs.org/?p=cel/cel-2.6.git;a=shortlog;h=refs/heads/nfsd-5.8
>
> Pull from:
> git://git.linux-nfs.org/projects/cel/cel-2.6.git nfsd-5.8
>
> Highlights of this series:
> * Remove serialization of sending RPC/RDMA Replies
> * Convert the TCP socket send path to use xdr_buf::bvecs (pre-requisite for RPC-on-TLS)
> * Fix svcrdma backchannel sendto return code
> * Convert a number of dprintk call sites to use tracepoints
> * Fix the "suggest braces around empty body in an ‘else’ statement" warning
>
> Changes since v1:
> * Rebased on v5.7-rc5+
> * Re-organized the series so changes interesting to linux-rdma appear together
> * Addressed sparse warnings found by the kbuild test robot
> * Included an additional minor clean-up: removal of the unused SVCRDMA_DEBUG macro
> * Clarified several patch descriptions
>
> ---
>
> Chuck Lever (29):
> SUNRPC: Move xpt_mutex into socket xpo_sendto methods
> svcrdma: Clean up the tracing for rw_ctx_init errors
> svcrdma: Clean up handling of get_rw_ctx errors
> svcrdma: Trace page overruns when constructing RDMA Reads
> svcrdma: trace undersized Write chunks
> svcrdma: Fix backchannel return code
> svcrdma: Remove backchannel dprintk call sites
> svcrdma: Rename tracepoints that record header decoding errors
> svcrdma: Remove the SVCRDMA_DEBUG macro
> svcrdma: Displayed remote IP address should match stored address
> svcrdma: Add tracepoints to report ->xpo_accept failures
> SUNRPC: Remove kernel memory address from svc_xprt tracepoints
> SUNRPC: Tracepoint to record errors in svc_xpo_create()
> SUNRPC: Trace a few more generic svc_xprt events
> SUNRPC: Remove "#include <trace/events/skb.h>"
> SUNRPC: Add more svcsock tracepoints
> SUNRPC: Replace dprintk call sites in TCP state change callouts
> SUNRPC: Trace server-side rpcbind registration events
> SUNRPC: Rename svc_sock::sk_reclen
> SUNRPC: Restructure svc_tcp_recv_record()
> SUNRPC: Refactor svc_recvfrom()
> SUNRPC: Restructure svc_udp_recvfrom()
> SUNRPC: svc_show_status() macro should have enum definitions
> NFSD: Add tracepoints to NFSD's duplicate reply cache
> NFSD: Add tracepoints to the NFSD state management code
> NFSD: Add tracepoints for monitoring NFSD callbacks
> SUNRPC: Clean up request deferral tracepoints
> NFSD: Squash an annoying compiler warning
> NFSD: Fix improperly-formatted Doxygen comments
>
>
> fs/nfsd/nfs4callback.c | 37 +-
> fs/nfsd/nfs4proc.c | 7 +-
> fs/nfsd/nfs4state.c | 63 ++--
> fs/nfsd/nfscache.c | 57 +--
> fs/nfsd/nfsctl.c | 26 +-
> fs/nfsd/state.h | 7 -
> fs/nfsd/trace.h | 345 ++++++++++++++++++
> include/linux/sunrpc/svc.h | 1 +
> include/linux/sunrpc/svc_rdma.h | 6 +-
> include/linux/sunrpc/svcsock.h | 6 +-
> include/trace/events/rpcrdma.h | 142 ++++++--
> include/trace/events/sunrpc.h | 387 ++++++++++++++++++--
> net/sunrpc/svc.c | 19 +-
> net/sunrpc/svc_xprt.c | 41 +--
> net/sunrpc/svcsock.c | 393 ++++++++++-----------
> net/sunrpc/xprtrdma/svc_rdma_backchannel.c | 86 +----
> net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 21 +-
> net/sunrpc/xprtrdma/svc_rdma_rw.c | 92 ++---
> net/sunrpc/xprtrdma/svc_rdma_transport.c | 55 ++-
> 19 files changed, 1221 insertions(+), 570 deletions(-)
>
> --
> Chuck Lever
next prev parent reply other threads:[~2020-05-19 16:11 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 21:22 [PATCH v2 00/29] Possible NFSD patches for v5.8 Chuck Lever
2020-05-12 21:22 ` [PATCH v2 01/29] SUNRPC: Move xpt_mutex into socket xpo_sendto methods Chuck Lever
2020-05-12 21:22 ` [PATCH v2 02/29] svcrdma: Clean up the tracing for rw_ctx_init errors Chuck Lever
2020-05-12 21:22 ` [PATCH v2 03/29] svcrdma: Clean up handling of get_rw_ctx errors Chuck Lever
2020-05-12 21:22 ` [PATCH v2 04/29] svcrdma: Trace page overruns when constructing RDMA Reads Chuck Lever
2020-05-12 21:22 ` [PATCH v2 05/29] svcrdma: trace undersized Write chunks Chuck Lever
2020-05-12 21:22 ` [PATCH v2 06/29] svcrdma: Fix backchannel return code Chuck Lever
2020-05-12 21:22 ` [PATCH v2 07/29] svcrdma: Remove backchannel dprintk call sites Chuck Lever
2020-05-12 21:22 ` [PATCH v2 08/29] svcrdma: Rename tracepoints that record header decoding errors Chuck Lever
2020-05-12 21:22 ` [PATCH v2 09/29] svcrdma: Remove the SVCRDMA_DEBUG macro Chuck Lever
2020-05-12 21:22 ` [PATCH v2 10/29] svcrdma: Displayed remote IP address should match stored address Chuck Lever
2020-05-12 21:23 ` [PATCH v2 11/29] svcrdma: Add tracepoints to report ->xpo_accept failures Chuck Lever
2020-05-12 21:23 ` [PATCH v2 12/29] SUNRPC: Remove kernel memory address from svc_xprt tracepoints Chuck Lever
2020-05-12 21:23 ` [PATCH v2 13/29] SUNRPC: Tracepoint to record errors in svc_xpo_create() Chuck Lever
2020-05-12 21:23 ` [PATCH v2 14/29] SUNRPC: Trace a few more generic svc_xprt events Chuck Lever
2020-05-12 21:23 ` [PATCH v2 15/29] SUNRPC: Remove "#include <trace/events/skb.h>" Chuck Lever
2020-05-12 21:23 ` [PATCH v2 16/29] SUNRPC: Add more svcsock tracepoints Chuck Lever
2020-05-12 21:23 ` [PATCH v2 17/29] SUNRPC: Replace dprintk call sites in TCP state change callouts Chuck Lever
2020-05-12 21:23 ` [PATCH v2 18/29] SUNRPC: Trace server-side rpcbind registration events Chuck Lever
2020-05-12 21:23 ` [PATCH v2 19/29] SUNRPC: Rename svc_sock::sk_reclen Chuck Lever
2020-05-12 21:23 ` [PATCH v2 20/29] SUNRPC: Restructure svc_tcp_recv_record() Chuck Lever
2020-05-12 21:23 ` [PATCH v2 21/29] SUNRPC: Refactor svc_recvfrom() Chuck Lever
2020-05-12 21:24 ` [PATCH v2 22/29] SUNRPC: Restructure svc_udp_recvfrom() Chuck Lever
2020-05-12 21:24 ` [PATCH v2 23/29] SUNRPC: svc_show_status() macro should have enum definitions Chuck Lever
2020-05-12 21:24 ` [PATCH v2 24/29] NFSD: Add tracepoints to NFSD's duplicate reply cache Chuck Lever
2020-05-12 21:24 ` [PATCH v2 25/29] NFSD: Add tracepoints to the NFSD state management code Chuck Lever
2020-05-12 21:24 ` [PATCH v2 26/29] NFSD: Add tracepoints for monitoring NFSD callbacks Chuck Lever
2020-05-12 21:24 ` [PATCH v2 27/29] SUNRPC: Clean up request deferral tracepoints Chuck Lever
2020-05-12 21:24 ` [PATCH v2 28/29] NFSD: Squash an annoying compiler warning Chuck Lever
2020-05-12 21:24 ` [PATCH v2 29/29] NFSD: Fix improperly-formatted Doxygen comments Chuck Lever
2020-05-19 16:11 ` J. Bruce Fields [this message]
2020-05-19 16:14 ` [PATCH v2 00/29] Possible NFSD patches for v5.8 Chuck Lever
2020-05-19 21:29 ` Bruce Fields
2020-05-19 22:25 ` Chuck Lever
2020-05-19 23:32 ` Chuck Lever
2020-05-20 16:46 ` Bruce Fields
2020-05-20 16:48 ` Chuck Lever
2020-05-20 17:01 ` Bruce Fields
2020-05-20 17:01 ` Calum Mackay
2020-05-20 17:14 ` Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519161108.GD25858@fieldses.org \
--to=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).