* [bug report] net/mlx5: E-switch, Offloads shift ACL programming during enable/disable vport
@ 2020-06-03 10:34 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2020-06-03 10:34 UTC (permalink / raw)
To: vuhuong; +Cc: linux-rdma
Hello Vu Pham,
The patch 748da30b376e: "net/mlx5: E-switch, Offloads shift ACL
programming during enable/disable vport" from Oct 28, 2019, leads to
the following static checker warning:
drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c:1979 esw_create_uplink_offloads_acl_tables()
error: 'vport' dereferencing possible ERR_PTR()
drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
1970 static int esw_create_uplink_offloads_acl_tables(struct mlx5_eswitch *esw)
1971 {
1972 struct mlx5_vport *vport;
1973 int err;
1974
1975 if (esw_use_vport_metadata(esw))
1976 esw->flags |= MLX5_ESWITCH_VPORT_MATCH_METADATA;
1977
1978 vport = mlx5_eswitch_get_vport(esw, MLX5_VPORT_UPLINK);
No error checking.
1979 err = esw_vport_create_offloads_acl_tables(esw, vport);
1980 if (err)
1981 esw->flags &= ~MLX5_ESWITCH_VPORT_MATCH_METADATA;
1982 return err;
1983 }
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-06-03 10:34 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-03 10:34 [bug report] net/mlx5: E-switch, Offloads shift ACL programming during enable/disable vport Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).