linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH rdma-rc] RDMA/mlx5: Fix integrity enabled QP creation
@ 2020-06-17 13:02 Leon Romanovsky
  2020-06-17 14:15 ` Max Gurtovoy
  2020-06-18 18:15 ` Jason Gunthorpe
  0 siblings, 2 replies; 3+ messages in thread
From: Leon Romanovsky @ 2020-06-17 13:02 UTC (permalink / raw)
  To: Doug Ledford, Jason Gunthorpe; +Cc: Max Gurtovoy, linux-rdma, Maor Gottlieb

From: Max Gurtovoy <maxg@mellanox.com>

create_flags checks was refactored and broke the creation on integrity
enabled QPs and actually broke the NVMe/RDMA and iSER ULP's when using
mlx5 driven devices.

Fixes: 2978975ce7f1 ("RDMA/mlx5: Process create QP flags in one place")
Signed-off-by: Max Gurtovoy <maxg@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
---
 drivers/infiniband/hw/mlx5/qp.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
index aff412b513ae..fe6af6bed02d 100644
--- a/drivers/infiniband/hw/mlx5/qp.c
+++ b/drivers/infiniband/hw/mlx5/qp.c
@@ -2668,6 +2668,9 @@ static int process_create_flags(struct mlx5_ib_dev *dev, struct mlx5_ib_qp *qp,
 	if (qp_type == IB_QPT_RAW_PACKET && attr->rwq_ind_tbl)
 		return (create_flags) ? -EINVAL : 0;

+	process_create_flag(dev, &create_flags,
+			    IB_QP_CREATE_INTEGRITY_EN,
+			    MLX5_CAP_GEN(mdev, sho), qp);
 	process_create_flag(dev, &create_flags,
 			    IB_QP_CREATE_BLOCK_MULTICAST_LOOPBACK,
 			    MLX5_CAP_GEN(mdev, block_lb_mc), qp);
--
2.26.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH rdma-rc] RDMA/mlx5: Fix integrity enabled QP creation
  2020-06-17 13:02 [PATCH rdma-rc] RDMA/mlx5: Fix integrity enabled QP creation Leon Romanovsky
@ 2020-06-17 14:15 ` Max Gurtovoy
  2020-06-18 18:15 ` Jason Gunthorpe
  1 sibling, 0 replies; 3+ messages in thread
From: Max Gurtovoy @ 2020-06-17 14:15 UTC (permalink / raw)
  To: Leon Romanovsky, Doug Ledford, Jason Gunthorpe
  Cc: linux-rdma, Maor Gottlieb, Linux-nvme

+ adding the NVMe mailing list in case someone find issues with 
NVMe/RDMA on 5.8-rc1

On 6/17/2020 4:02 PM, Leon Romanovsky wrote:
> From: Max Gurtovoy <maxg@mellanox.com>
>
> create_flags checks was refactored and broke the creation on integrity
> enabled QPs and actually broke the NVMe/RDMA and iSER ULP's when using
> mlx5 driven devices.
>
> Fixes: 2978975ce7f1 ("RDMA/mlx5: Process create QP flags in one place")
> Signed-off-by: Max Gurtovoy <maxg@mellanox.com>
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---
>   drivers/infiniband/hw/mlx5/qp.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
> index aff412b513ae..fe6af6bed02d 100644
> --- a/drivers/infiniband/hw/mlx5/qp.c
> +++ b/drivers/infiniband/hw/mlx5/qp.c
> @@ -2668,6 +2668,9 @@ static int process_create_flags(struct mlx5_ib_dev *dev, struct mlx5_ib_qp *qp,
>   	if (qp_type == IB_QPT_RAW_PACKET && attr->rwq_ind_tbl)
>   		return (create_flags) ? -EINVAL : 0;
>
> +	process_create_flag(dev, &create_flags,
> +			    IB_QP_CREATE_INTEGRITY_EN,
> +			    MLX5_CAP_GEN(mdev, sho), qp);
>   	process_create_flag(dev, &create_flags,
>   			    IB_QP_CREATE_BLOCK_MULTICAST_LOOPBACK,
>   			    MLX5_CAP_GEN(mdev, block_lb_mc), qp);
> --
> 2.26.2
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH rdma-rc] RDMA/mlx5: Fix integrity enabled QP creation
  2020-06-17 13:02 [PATCH rdma-rc] RDMA/mlx5: Fix integrity enabled QP creation Leon Romanovsky
  2020-06-17 14:15 ` Max Gurtovoy
@ 2020-06-18 18:15 ` Jason Gunthorpe
  1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2020-06-18 18:15 UTC (permalink / raw)
  To: Leon Romanovsky; +Cc: Doug Ledford, Max Gurtovoy, linux-rdma, Maor Gottlieb

On Wed, Jun 17, 2020 at 04:02:30PM +0300, Leon Romanovsky wrote:
> From: Max Gurtovoy <maxg@mellanox.com>
> 
> create_flags checks was refactored and broke the creation on integrity
> enabled QPs and actually broke the NVMe/RDMA and iSER ULP's when using
> mlx5 driven devices.
> 
> Fixes: 2978975ce7f1 ("RDMA/mlx5: Process create QP flags in one place")
> Signed-off-by: Max Gurtovoy <maxg@mellanox.com>
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---
>  drivers/infiniband/hw/mlx5/qp.c | 3 +++
>  1 file changed, 3 insertions(+)

Applied to for-rc, thanks

Jason

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-06-18 18:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-17 13:02 [PATCH rdma-rc] RDMA/mlx5: Fix integrity enabled QP creation Leon Romanovsky
2020-06-17 14:15 ` Max Gurtovoy
2020-06-18 18:15 ` Jason Gunthorpe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).