* [PATCH for-rc] RDMA/core: Fix reported speed and width
@ 2020-09-02 12:43 Kamal Heib
2020-09-02 20:03 ` Jason Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: Kamal Heib @ 2020-09-02 12:43 UTC (permalink / raw)
To: linux-rdma; +Cc: Doug Ledford, Jason Gunthorpe, Kamal Heib
When the returned speed from __ethtool_get_link_ksettings() is
SPEED_UNKNOWN this will lead to reporting a wrong speed and width for
providers that uses ib_get_eth_speed(), fix that by defaulting the
netdev_speed to SPEED_1000 in case the returned value from
__ethtool_get_link_ksettings() is SPEED_UNKNOWN.
Fixes: d41861942fc5 ("IB/core: Add generic function to extract IB speed from netdev")
Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
---
drivers/infiniband/core/verbs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c
index 3096e73797b7..307886737646 100644
--- a/drivers/infiniband/core/verbs.c
+++ b/drivers/infiniband/core/verbs.c
@@ -1801,7 +1801,7 @@ int ib_get_eth_speed(struct ib_device *dev, u8 port_num, u8 *speed, u8 *width)
dev_put(netdev);
- if (!rc) {
+ if (!rc && lksettings.base.speed != (u32)SPEED_UNKNOWN) {
netdev_speed = lksettings.base.speed;
} else {
netdev_speed = SPEED_1000;
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH for-rc] RDMA/core: Fix reported speed and width
2020-09-02 12:43 [PATCH for-rc] RDMA/core: Fix reported speed and width Kamal Heib
@ 2020-09-02 20:03 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2020-09-02 20:03 UTC (permalink / raw)
To: Kamal Heib; +Cc: linux-rdma, Doug Ledford
On Wed, Sep 02, 2020 at 03:43:04PM +0300, Kamal Heib wrote:
> When the returned speed from __ethtool_get_link_ksettings() is
> SPEED_UNKNOWN this will lead to reporting a wrong speed and width for
> providers that uses ib_get_eth_speed(), fix that by defaulting the
> netdev_speed to SPEED_1000 in case the returned value from
> __ethtool_get_link_ksettings() is SPEED_UNKNOWN.
>
> Fixes: d41861942fc5 ("IB/core: Add generic function to extract IB speed from netdev")
> Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
> ---
> drivers/infiniband/core/verbs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-rc, thanks
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-02 20:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-02 12:43 [PATCH for-rc] RDMA/core: Fix reported speed and width Kamal Heib
2020-09-02 20:03 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).