* [PATCH rdma-next] overflow: Include header file with SIZE_MAX declaration
@ 2020-09-13 10:29 Leon Romanovsky
2020-10-02 0:31 ` Jason Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: Leon Romanovsky @ 2020-09-13 10:29 UTC (permalink / raw)
To: Doug Ledford, Jason Gunthorpe
Cc: Leon Romanovsky, Kees Cook, linux-kernel, RDMA mailing list
From: Leon Romanovsky <leonro@nvidia.com>
The various array_size functions use SIZE_MAX define, but missed limits.h
causes to failure to compile code that needs overflow.h.
In file included from drivers/infiniband/core/uverbs_std_types_device.c:6:
./include/linux/overflow.h: In function 'array_size':
./include/linux/overflow.h:258:10: error: 'SIZE_MAX' undeclared (first use in this function)
258 | return SIZE_MAX;
| ^~~~~~~~
Fixes: 610b15c50e86 ("overflow.h: Add allocation size calculation helpers")
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
---
include/linux/overflow.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/overflow.h b/include/linux/overflow.h
index 93fcef105061..ff3c48f0abc5 100644
--- a/include/linux/overflow.h
+++ b/include/linux/overflow.h
@@ -3,6 +3,7 @@
#define __LINUX_OVERFLOW_H
#include <linux/compiler.h>
+#include <linux/limits.h>
/*
* In the fallback code below, we need to compute the minimum and
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH rdma-next] overflow: Include header file with SIZE_MAX declaration
2020-09-13 10:29 [PATCH rdma-next] overflow: Include header file with SIZE_MAX declaration Leon Romanovsky
@ 2020-10-02 0:31 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2020-10-02 0:31 UTC (permalink / raw)
To: Leon Romanovsky
Cc: Doug Ledford, Leon Romanovsky, Kees Cook, linux-kernel,
RDMA mailing list
On Sun, Sep 13, 2020 at 01:29:28PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
>
> The various array_size functions use SIZE_MAX define, but missed limits.h
> causes to failure to compile code that needs overflow.h.
>
> In file included from drivers/infiniband/core/uverbs_std_types_device.c:6:
> ./include/linux/overflow.h: In function 'array_size':
> ./include/linux/overflow.h:258:10: error: 'SIZE_MAX' undeclared (first use in this function)
> 258 | return SIZE_MAX;
> | ^~~~~~~~
>
> Fixes: 610b15c50e86 ("overflow.h: Add allocation size calculation helpers")
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> ---
> include/linux/overflow.h | 1 +
> 1 file changed, 1 insertion(+)
Applied to rdma for-next, seems other patches need this. Thanks
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-02 0:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-13 10:29 [PATCH rdma-next] overflow: Include header file with SIZE_MAX declaration Leon Romanovsky
2020-10-02 0:31 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).