* RE: [PATCH 1/1] RDMA/irdma: remove the unused variable local_qp
2021-10-27 17:54 [PATCH 1/1] RDMA/irdma: remove the unused variable local_qp yanjun.zhu
@ 2021-10-27 15:52 ` Saleem, Shiraz
2021-10-27 16:41 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Saleem, Shiraz @ 2021-10-27 15:52 UTC (permalink / raw)
To: yanjun.zhu, Ismail, Mustafa, dledford, jgg, linux-rdma, leonro
> Subject: [PATCH 1/1] RDMA/irdma: remove the unused variable local_qp
>
> From: Zhu Yanjun <yanjun.zhu@linux.dev>
>
> Since the member variable local_qp is not used, remove it.
>
> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> ---
> drivers/infiniband/hw/irdma/type.h | 1 - drivers/infiniband/hw/irdma/verbs.c | 1 -
> 2 files changed, 2 deletions(-)
>
Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] RDMA/irdma: remove the unused variable local_qp
2021-10-27 17:54 [PATCH 1/1] RDMA/irdma: remove the unused variable local_qp yanjun.zhu
2021-10-27 15:52 ` Saleem, Shiraz
@ 2021-10-27 16:41 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2021-10-27 16:41 UTC (permalink / raw)
To: yanjun.zhu; +Cc: mustafa.ismail, shiraz.saleem, dledford, linux-rdma, leonro
On Wed, Oct 27, 2021 at 01:54:57PM -0400, yanjun.zhu@linux.dev wrote:
> From: Zhu Yanjun <yanjun.zhu@linux.dev>
>
> Since the member variable local_qp is not used, remove it.
>
> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
> ---
> drivers/infiniband/hw/irdma/type.h | 1 -
> drivers/infiniband/hw/irdma/verbs.c | 1 -
> 2 files changed, 2 deletions(-)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] RDMA/irdma: remove the unused variable local_qp
@ 2021-10-27 17:54 yanjun.zhu
2021-10-27 15:52 ` Saleem, Shiraz
2021-10-27 16:41 ` Jason Gunthorpe
0 siblings, 2 replies; 3+ messages in thread
From: yanjun.zhu @ 2021-10-27 17:54 UTC (permalink / raw)
To: mustafa.ismail, shiraz.saleem, dledford, jgg, linux-rdma,
yanjun.zhu, leonro
From: Zhu Yanjun <yanjun.zhu@linux.dev>
Since the member variable local_qp is not used, remove it.
Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
---
drivers/infiniband/hw/irdma/type.h | 1 -
drivers/infiniband/hw/irdma/verbs.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/infiniband/hw/irdma/type.h b/drivers/infiniband/hw/irdma/type.h
index 874bc25a938b..bca7bbe5c451 100644
--- a/drivers/infiniband/hw/irdma/type.h
+++ b/drivers/infiniband/hw/irdma/type.h
@@ -852,7 +852,6 @@ struct irdma_roce_offload_info {
u16 err_rq_idx;
u32 qkey;
u32 dest_qp;
- u32 local_qp;
u8 roce_tver;
u8 ack_credits;
u8 err_rq_idx_valid;
diff --git a/drivers/infiniband/hw/irdma/verbs.c b/drivers/infiniband/hw/irdma/verbs.c
index 02ca1f80968e..754e873129a0 100644
--- a/drivers/infiniband/hw/irdma/verbs.c
+++ b/drivers/infiniband/hw/irdma/verbs.c
@@ -1197,7 +1197,6 @@ int irdma_modify_qp_roce(struct ib_qp *ibqp, struct ib_qp_attr *attr,
av->attrs = attr->ah_attr;
rdma_gid2ip((struct sockaddr *)&av->sgid_addr, &sgid_attr->gid);
rdma_gid2ip((struct sockaddr *)&av->dgid_addr, &attr->ah_attr.grh.dgid);
- roce_info->local_qp = ibqp->qp_num;
if (av->sgid_addr.saddr.sa_family == AF_INET6) {
__be32 *daddr =
av->dgid_addr.saddr_in6.sin6_addr.in6_u.u6_addr32;
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-27 16:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-27 17:54 [PATCH 1/1] RDMA/irdma: remove the unused variable local_qp yanjun.zhu
2021-10-27 15:52 ` Saleem, Shiraz
2021-10-27 16:41 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).