* [PATCH net] net/mlx5e: Fix use after free in mlx5e_fs_init()
@ 2022-08-04 14:43 Dan Carpenter
2022-08-04 15:04 ` Tariq Toukan
0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2022-08-04 14:43 UTC (permalink / raw)
To: Saeed Mahameed, Lama Kayal
Cc: Leon Romanovsky, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Tariq Toukan, netdev, linux-rdma, kernel-janitors
Call mlx5e_fs_vlan_free(fs) before kvfree(fs).
Fixes: af8bbf730068 ("net/mlx5e: Convert mlx5e_flow_steering member of mlx5e_priv to pointer")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
This applies to net but I never really understand how mellanox patches
work...
drivers/net/ethernet/mellanox/mlx5/core/en_fs.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_fs.c b/drivers/net/ethernet/mellanox/mlx5/core/en_fs.c
index e2a9b9be5c1f..e0ce5a233d0b 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_fs.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_fs.c
@@ -1395,10 +1395,11 @@ struct mlx5e_flow_steering *mlx5e_fs_init(const struct mlx5e_profile *profile,
}
return fs;
-err_free_fs:
- kvfree(fs);
+
err_free_vlan:
mlx5e_fs_vlan_free(fs);
+err_free_fs:
+ kvfree(fs);
err:
return NULL;
}
--
2.35.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net] net/mlx5e: Fix use after free in mlx5e_fs_init()
2022-08-04 14:43 [PATCH net] net/mlx5e: Fix use after free in mlx5e_fs_init() Dan Carpenter
@ 2022-08-04 15:04 ` Tariq Toukan
2022-08-05 6:21 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: Tariq Toukan @ 2022-08-04 15:04 UTC (permalink / raw)
To: Dan Carpenter
Cc: Leon Romanovsky, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Tariq Toukan, netdev, linux-rdma, kernel-janitors,
Lama Kayal, Saeed Mahameed, Tariq Toukan
On 8/4/2022 5:43 PM, Dan Carpenter wrote:
> Call mlx5e_fs_vlan_free(fs) before kvfree(fs).
>
> Fixes: af8bbf730068 ("net/mlx5e: Convert mlx5e_flow_steering member of mlx5e_priv to pointer")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> This applies to net but I never really understand how mellanox patches
> work...
>
Hi Dan,
This patch belongs to next kernel (6.0).
It seems that net-next (or parts of it) is already merged into net as
we're in the merge window.
> drivers/net/ethernet/mellanox/mlx5/core/en_fs.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_fs.c b/drivers/net/ethernet/mellanox/mlx5/core/en_fs.c
> index e2a9b9be5c1f..e0ce5a233d0b 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_fs.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_fs.c
> @@ -1395,10 +1395,11 @@ struct mlx5e_flow_steering *mlx5e_fs_init(const struct mlx5e_profile *profile,
> }
>
> return fs;
> -err_free_fs:
> - kvfree(fs);
> +
> err_free_vlan:
> mlx5e_fs_vlan_free(fs);
> +err_free_fs:
> + kvfree(fs);
> err:
> return NULL;
> }
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Thanks for your patch!
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net] net/mlx5e: Fix use after free in mlx5e_fs_init()
2022-08-04 15:04 ` Tariq Toukan
@ 2022-08-05 6:21 ` Dan Carpenter
2022-08-05 6:26 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2022-08-05 6:21 UTC (permalink / raw)
To: Tariq Toukan
Cc: Leon Romanovsky, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Tariq Toukan, netdev, linux-rdma, kernel-janitors,
Lama Kayal, Saeed Mahameed
On Thu, Aug 04, 2022 at 06:04:52PM +0300, Tariq Toukan wrote:
>
>
> On 8/4/2022 5:43 PM, Dan Carpenter wrote:
> > Call mlx5e_fs_vlan_free(fs) before kvfree(fs).
> >
> > Fixes: af8bbf730068 ("net/mlx5e: Convert mlx5e_flow_steering member of mlx5e_priv to pointer")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > This applies to net but I never really understand how mellanox patches
> > work...
> >
>
> Hi Dan,
> This patch belongs to next kernel (6.0).
> It seems that net-next (or parts of it) is already merged into net as we're
> in the merge window.
Right. But commit af8bbf730068 was merged by Saeed. I think that went
through his tree and then pulled into one of the networking trees. But
sometimes these patches are pulled directly into a networking tree.
I can't remember how it works, but it's somehow my job to remember this
stuff for 200+ *hundred* different friggin git trees and put the tree
name in the subject. :P (small rant).
>
> Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Thanks!
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net] net/mlx5e: Fix use after free in mlx5e_fs_init()
2022-08-05 6:21 ` Dan Carpenter
@ 2022-08-05 6:26 ` Dan Carpenter
2022-08-06 0:38 ` Jakub Kicinski
0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2022-08-05 6:26 UTC (permalink / raw)
To: Tariq Toukan
Cc: Leon Romanovsky, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Tariq Toukan, netdev, linux-rdma, kernel-janitors,
Lama Kayal, Saeed Mahameed
On Fri, Aug 05, 2022 at 09:21:41AM +0300, Dan Carpenter wrote:
> I can't remember how it works, but it's somehow my job to remember this
> stuff for 200+ *hundred* different friggin git trees and put the tree
> name in the subject. :P (small rant).
>
Huh. It's actuall 360 trees now. Wow.
Anyway, it needs to go into net and not net-next. I've told everyone
else besides networking who asks for something like that in the subject
that they can pound dirt.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net] net/mlx5e: Fix use after free in mlx5e_fs_init()
2022-08-05 6:26 ` Dan Carpenter
@ 2022-08-06 0:38 ` Jakub Kicinski
0 siblings, 0 replies; 5+ messages in thread
From: Jakub Kicinski @ 2022-08-06 0:38 UTC (permalink / raw)
To: Dan Carpenter
Cc: Tariq Toukan, Leon Romanovsky, David S. Miller, Eric Dumazet,
Paolo Abeni, Tariq Toukan, netdev, linux-rdma, kernel-janitors,
Lama Kayal, Saeed Mahameed
On Fri, 5 Aug 2022 09:26:06 +0300 Dan Carpenter wrote:
> Anyway, it needs to go into net and not net-next. I've told everyone
> else besides networking who asks for something like that in the subject
> that they can pound dirt.
We appreciate the special treatment! :]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-08-06 0:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-04 14:43 [PATCH net] net/mlx5e: Fix use after free in mlx5e_fs_init() Dan Carpenter
2022-08-04 15:04 ` Tariq Toukan
2022-08-05 6:21 ` Dan Carpenter
2022-08-05 6:26 ` Dan Carpenter
2022-08-06 0:38 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).