* [patch] IB/core: missing curly braces in ib_find_gid()
@ 2015-08-18 9:22 Dan Carpenter
2015-08-29 1:10 ` ira.weiny
2015-09-03 17:39 ` Doug Ledford
0 siblings, 2 replies; 6+ messages in thread
From: Dan Carpenter @ 2015-08-18 9:22 UTC (permalink / raw)
To: Doug Ledford, Matan Barak
Cc: Sean Hefty, Hal Rosenstock, Ira Weiny, Jason Gunthorpe,
Haggai Eran, Michael Wang, Yotam Kenneth,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
Smatch says that, based on the indenting, we should probably add curly
braces here.
Fixes: 230145ff8124 ('IB/core: Add RoCE GID table management')
Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
index 258b3f7..5d5bbae 100644
--- a/drivers/infiniband/core/device.c
+++ b/drivers/infiniband/core/device.c
@@ -807,9 +807,10 @@ int ib_find_gid(struct ib_device *device, union ib_gid *gid,
for (port = rdma_start_port(device); port <= rdma_end_port(device); ++port) {
if (rdma_cap_roce_gid_table(device, port)) {
if (!ib_cache_gid_find_by_port(device, gid, port,
- NULL, index))
+ NULL, index)) {
*port_num = port;
return 0;
+ }
}
for (i = 0; i < device->port_immutable[port].gid_tbl_len; ++i) {
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [patch] IB/core: missing curly braces in ib_find_gid()
2015-08-18 9:22 [patch] IB/core: missing curly braces in ib_find_gid() Dan Carpenter
@ 2015-08-29 1:10 ` ira.weiny
[not found] ` <20150829011040.GA2713-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2015-09-03 17:39 ` Doug Ledford
1 sibling, 1 reply; 6+ messages in thread
From: ira.weiny @ 2015-08-29 1:10 UTC (permalink / raw)
To: Dan Carpenter
Cc: Doug Ledford, Matan Barak, Sean Hefty, Hal Rosenstock,
Jason Gunthorpe, Haggai Eran, Michael Wang, Yotam Kenneth,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
On Tue, Aug 18, 2015 at 12:22:10PM +0300, Dan Carpenter wrote:
> Smatch says that, based on the indenting, we should probably add curly
> braces here.
>
> Fixes: 230145ff8124 ('IB/core: Add RoCE GID table management')
> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>
Reviewed-by: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>
> diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
> index 258b3f7..5d5bbae 100644
> --- a/drivers/infiniband/core/device.c
> +++ b/drivers/infiniband/core/device.c
> @@ -807,9 +807,10 @@ int ib_find_gid(struct ib_device *device, union ib_gid *gid,
> for (port = rdma_start_port(device); port <= rdma_end_port(device); ++port) {
> if (rdma_cap_roce_gid_table(device, port)) {
> if (!ib_cache_gid_find_by_port(device, gid, port,
> - NULL, index))
> + NULL, index)) {
> *port_num = port;
> return 0;
> + }
> }
>
> for (i = 0; i < device->port_immutable[port].gid_tbl_len; ++i) {
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] IB/core: missing curly braces in ib_find_gid()
[not found] ` <20150829011040.GA2713-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
@ 2015-08-29 4:02 ` Doug Ledford
2015-08-30 4:59 ` Or Gerlitz
0 siblings, 1 reply; 6+ messages in thread
From: Doug Ledford @ 2015-08-29 4:02 UTC (permalink / raw)
To: ira.weiny, Dan Carpenter
Cc: Matan Barak, Sean Hefty, Hal Rosenstock, Jason Gunthorpe,
Haggai Eran, Michael Wang, Yotam Kenneth,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 647 bytes --]
On 08/28/2015 09:10 PM, ira.weiny wrote:
> On Tue, Aug 18, 2015 at 12:22:10PM +0300, Dan Carpenter wrote:
>> Smatch says that, based on the indenting, we should probably add curly
>> braces here.
>>
>> Fixes: 230145ff8124 ('IB/core: Add RoCE GID table management')
>> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>>
>
> Reviewed-by: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
I've picked this patch up (earlier today), so I missed your reviewed-by:
tag. Added.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: 0E572FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] IB/core: missing curly braces in ib_find_gid()
2015-08-29 4:02 ` Doug Ledford
@ 2015-08-30 4:59 ` Or Gerlitz
2015-08-30 22:24 ` Doug Ledford
0 siblings, 1 reply; 6+ messages in thread
From: Or Gerlitz @ 2015-08-30 4:59 UTC (permalink / raw)
To: Doug Ledford
Cc: ira.weiny, Dan Carpenter, Matan Barak, Sean Hefty,
Hal Rosenstock, Jason Gunthorpe, Haggai Eran, Michael Wang,
Yotam Kenneth, linux-rdma, kernel-janitors
On Fri, Aug 28, 2015 at 9:02 PM, Doug Ledford <dledford@redhat.com> wrote:
> On 08/28/2015 09:10 PM, ira.weiny wrote:
>> On Tue, Aug 18, 2015 at 12:22:10PM +0300, Dan Carpenter wrote:
>>> Smatch says that, based on the indenting, we should probably add curly
>>> braces here.
>>>
>>> Fixes: 230145ff8124 ('IB/core: Add RoCE GID table management')
>>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>>
>>
>> Reviewed-by: Ira Weiny <ira.weiny@intel.com>
>
> I've picked this patch up (earlier today), so I missed your reviewed-by:
> tag. Added.
wait, Doug, when the offending patch goes upstream, their commit ID
will not be the one
denoted here, right? I would suggest that you either hold off with
this fix till the other patch
goes upstream in 4,3-rc1 and you have a proper ID or squash it there
now. BTW - the way
net-next is organized/managed, pre-linus-tree commit ID remain the
same also after they land there,
so in that respect and other linux-rdma maintenance related aspects we
discussed during LPC - it
would be good if you can talk to Dave and see how he gets things going
for net-next
Or
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] IB/core: missing curly braces in ib_find_gid()
2015-08-30 4:59 ` Or Gerlitz
@ 2015-08-30 22:24 ` Doug Ledford
0 siblings, 0 replies; 6+ messages in thread
From: Doug Ledford @ 2015-08-30 22:24 UTC (permalink / raw)
To: Or Gerlitz
Cc: ira.weiny, Dan Carpenter, Matan Barak, Sean Hefty,
Hal Rosenstock, Jason Gunthorpe, Haggai Eran, Michael Wang,
Yotam Kenneth, linux-rdma, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1709 bytes --]
On 08/30/2015 12:59 AM, Or Gerlitz wrote:
> On Fri, Aug 28, 2015 at 9:02 PM, Doug Ledford <dledford@redhat.com> wrote:
>> On 08/28/2015 09:10 PM, ira.weiny wrote:
>>> On Tue, Aug 18, 2015 at 12:22:10PM +0300, Dan Carpenter wrote:
>>>> Smatch says that, based on the indenting, we should probably add curly
>>>> braces here.
>>>>
>>>> Fixes: 230145ff8124 ('IB/core: Add RoCE GID table management')
>>>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>>>
>>>
>>> Reviewed-by: Ira Weiny <ira.weiny@intel.com>
>>
>> I've picked this patch up (earlier today), so I missed your reviewed-by:
>> tag. Added.
>
> wait, Doug, when the offending patch goes upstream, their commit ID
> will not be the one
> denoted here, right?
Fair point...
> I would suggest that you either hold off with
> this fix till the other patch
> goes upstream in 4,3-rc1 and you have a proper ID
I have a proper ID now. Since I've put together my final k.o/for-4.3
branch, the ID is fixed.
> or squash it there
> now.
This patch is from someone different than the patch it fixes, so it
wouldn't be right to squash it into their patch. I fixed up the Fixes:
line instead.
> BTW - the way
> net-next is organized/managed, pre-linus-tree commit ID remain the
> same also after they land there,
> so in that respect and other linux-rdma maintenance related aspects we
> discussed during LPC - it
> would be good if you can talk to Dave and see how he gets things going
> for net-next
I'm going to be doing things differently for 4.4. We'll see if that
resolves the issues you are unhappy about.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: 0E572FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] IB/core: missing curly braces in ib_find_gid()
2015-08-18 9:22 [patch] IB/core: missing curly braces in ib_find_gid() Dan Carpenter
2015-08-29 1:10 ` ira.weiny
@ 2015-09-03 17:39 ` Doug Ledford
1 sibling, 0 replies; 6+ messages in thread
From: Doug Ledford @ 2015-09-03 17:39 UTC (permalink / raw)
To: Dan Carpenter, Matan Barak
Cc: Sean Hefty, Hal Rosenstock, Ira Weiny, Jason Gunthorpe,
Haggai Eran, Michael Wang, Yotam Kenneth,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 1111 bytes --]
On 08/18/2015 05:22 AM, Dan Carpenter wrote:
> Smatch says that, based on the indenting, we should probably add curly
> braces here.
>
> Fixes: 230145ff8124 ('IB/core: Add RoCE GID table management')
> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Thanks, applied.
> diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
> index 258b3f7..5d5bbae 100644
> --- a/drivers/infiniband/core/device.c
> +++ b/drivers/infiniband/core/device.c
> @@ -807,9 +807,10 @@ int ib_find_gid(struct ib_device *device, union ib_gid *gid,
> for (port = rdma_start_port(device); port <= rdma_end_port(device); ++port) {
> if (rdma_cap_roce_gid_table(device, port)) {
> if (!ib_cache_gid_find_by_port(device, gid, port,
> - NULL, index))
> + NULL, index)) {
> *port_num = port;
> return 0;
> + }
> }
>
> for (i = 0; i < device->port_immutable[port].gid_tbl_len; ++i) {
>
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: 0E572FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-09-03 17:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-18 9:22 [patch] IB/core: missing curly braces in ib_find_gid() Dan Carpenter
2015-08-29 1:10 ` ira.weiny
[not found] ` <20150829011040.GA2713-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2015-08-29 4:02 ` Doug Ledford
2015-08-30 4:59 ` Or Gerlitz
2015-08-30 22:24 ` Doug Ledford
2015-09-03 17:39 ` Doug Ledford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).