* [PATCH] net/mlx4: fix spelling mistake: "Inrerface" -> "Interface"
@ 2018-05-22 8:37 Colin King
2018-05-22 15:21 ` Tariq Toukan
0 siblings, 1 reply; 4+ messages in thread
From: Colin King @ 2018-05-22 8:37 UTC (permalink / raw)
To: Tariq Toukan, David S . Miller, netdev, linux-rdma
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Trivial fix to spelling mistake in mlx4_dbg debug message
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/mellanox/mlx4/intf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/intf.c b/drivers/net/ethernet/mellanox/mlx4/intf.c
index 2edcce98ab2d..6bd4103265d2 100644
--- a/drivers/net/ethernet/mellanox/mlx4/intf.c
+++ b/drivers/net/ethernet/mellanox/mlx4/intf.c
@@ -172,7 +172,7 @@ int mlx4_do_bond(struct mlx4_dev *dev, bool enable)
list_add_tail(&dev_ctx->list, &priv->ctx_list);
spin_unlock_irqrestore(&priv->ctx_lock, flags);
- mlx4_dbg(dev, "Inrerface for protocol %d restarted with when bonded mode is %s\n",
+ mlx4_dbg(dev, "Interface for protocol %d restarted with when bonded mode is %s\n",
dev_ctx->intf->protocol, enable ?
"enabled" : "disabled");
}
--
2.17.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net/mlx4: fix spelling mistake: "Inrerface" -> "Interface"
2018-05-22 8:37 [PATCH] net/mlx4: fix spelling mistake: "Inrerface" -> "Interface" Colin King
@ 2018-05-22 15:21 ` Tariq Toukan
2018-05-22 15:23 ` Colin Ian King
0 siblings, 1 reply; 4+ messages in thread
From: Tariq Toukan @ 2018-05-22 15:21 UTC (permalink / raw)
To: Colin King, Tariq Toukan, David S . Miller, netdev, linux-rdma
Cc: kernel-janitors, linux-kernel
On 22/05/2018 11:37 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Trivial fix to spelling mistake in mlx4_dbg debug message
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/ethernet/mellanox/mlx4/intf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/intf.c b/drivers/net/ethernet/mellanox/mlx4/intf.c
> index 2edcce98ab2d..6bd4103265d2 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/intf.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/intf.c
> @@ -172,7 +172,7 @@ int mlx4_do_bond(struct mlx4_dev *dev, bool enable)
> list_add_tail(&dev_ctx->list, &priv->ctx_list);
> spin_unlock_irqrestore(&priv->ctx_lock, flags);
>
> - mlx4_dbg(dev, "Inrerface for protocol %d restarted with when bonded mode is %s\n",
> + mlx4_dbg(dev, "Interface for protocol %d restarted with when bonded mode is %s\n",
Thanks Colin.
I think there's one more thing to fix here.
It is redundant to say "with when", it was probably done by mistake.
Let's rephrase, maybe this way?
restarted with bonded mode %s
> dev_ctx->intf->protocol, enable ?
> "enabled" : "disabled");
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net/mlx4: fix spelling mistake: "Inrerface" -> "Interface"
2018-05-22 15:21 ` Tariq Toukan
@ 2018-05-22 15:23 ` Colin Ian King
2018-05-22 15:25 ` Tariq Toukan
0 siblings, 1 reply; 4+ messages in thread
From: Colin Ian King @ 2018-05-22 15:23 UTC (permalink / raw)
To: Tariq Toukan, David S . Miller, netdev, linux-rdma
Cc: kernel-janitors, linux-kernel
On 22/05/18 16:21, Tariq Toukan wrote:
>
>
> On 22/05/2018 11:37 AM, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Trivial fix to spelling mistake in mlx4_dbg debug message
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/net/ethernet/mellanox/mlx4/intf.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/mellanox/mlx4/intf.c
>> b/drivers/net/ethernet/mellanox/mlx4/intf.c
>> index 2edcce98ab2d..6bd4103265d2 100644
>> --- a/drivers/net/ethernet/mellanox/mlx4/intf.c
>> +++ b/drivers/net/ethernet/mellanox/mlx4/intf.c
>> @@ -172,7 +172,7 @@ int mlx4_do_bond(struct mlx4_dev *dev, bool enable)
>> list_add_tail(&dev_ctx->list, &priv->ctx_list);
>> spin_unlock_irqrestore(&priv->ctx_lock, flags);
>> - mlx4_dbg(dev, "Inrerface for protocol %d restarted with
>> when bonded mode is %s\n",
>> + mlx4_dbg(dev, "Interface for protocol %d restarted with when
>> bonded mode is %s\n",
>
> Thanks Colin.
> I think there's one more thing to fix here.
> It is redundant to say "with when", it was probably done by mistake.
> Let's rephrase, maybe this way?
>
> restarted with bonded mode %s
Sounds like a good idea, do you want me to send V2 of the patch with
this fix?
>
>> dev_ctx->intf->protocol, enable ?
>> "enabled" : "disabled");
>> }
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe
> kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net/mlx4: fix spelling mistake: "Inrerface" -> "Interface"
2018-05-22 15:23 ` Colin Ian King
@ 2018-05-22 15:25 ` Tariq Toukan
0 siblings, 0 replies; 4+ messages in thread
From: Tariq Toukan @ 2018-05-22 15:25 UTC (permalink / raw)
To: Colin Ian King, Tariq Toukan, David S . Miller, netdev, linux-rdma
Cc: kernel-janitors, linux-kernel
On 22/05/2018 6:23 PM, Colin Ian King wrote:
> On 22/05/18 16:21, Tariq Toukan wrote:
>>
>>
>> On 22/05/2018 11:37 AM, Colin King wrote:
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> Trivial fix to spelling mistake in mlx4_dbg debug message
>>>
>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>> ---
>>> drivers/net/ethernet/mellanox/mlx4/intf.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/ethernet/mellanox/mlx4/intf.c
>>> b/drivers/net/ethernet/mellanox/mlx4/intf.c
>>> index 2edcce98ab2d..6bd4103265d2 100644
>>> --- a/drivers/net/ethernet/mellanox/mlx4/intf.c
>>> +++ b/drivers/net/ethernet/mellanox/mlx4/intf.c
>>> @@ -172,7 +172,7 @@ int mlx4_do_bond(struct mlx4_dev *dev, bool enable)
>>> list_add_tail(&dev_ctx->list, &priv->ctx_list);
>>> spin_unlock_irqrestore(&priv->ctx_lock, flags);
>>> - mlx4_dbg(dev, "Inrerface for protocol %d restarted with
>>> when bonded mode is %s\n",
>>> + mlx4_dbg(dev, "Interface for protocol %d restarted with when
>>> bonded mode is %s\n",
>>
>> Thanks Colin.
>> I think there's one more thing to fix here.
>> It is redundant to say "with when", it was probably done by mistake.
>> Let's rephrase, maybe this way?
>>
>> restarted with bonded mode %s
>
> Sounds like a good idea, do you want me to send V2 of the patch with
> this fix?
>
Yes please.
>>
>>> dev_ctx->intf->protocol, enable ?
>>> "enabled" : "disabled");
>>> }
>>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe
>> kernel-janitors" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-22 15:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-22 8:37 [PATCH] net/mlx4: fix spelling mistake: "Inrerface" -> "Interface" Colin King
2018-05-22 15:21 ` Tariq Toukan
2018-05-22 15:23 ` Colin Ian King
2018-05-22 15:25 ` Tariq Toukan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).