* [PATCH net-next] net/mlx5: Fix header guard in rsc_dump.h
@ 2020-02-21 5:24 Nathan Chancellor
2020-02-21 13:30 ` Jason Gunthorpe
2020-02-21 18:37 ` Saeed Mahameed
0 siblings, 2 replies; 3+ messages in thread
From: Nathan Chancellor @ 2020-02-21 5:24 UTC (permalink / raw)
To: Saeed Mahameed, Leon Romanovsky
Cc: Aya Levin, Moshe Shemesh, Jiri Pirko, netdev, linux-rdma,
linux-kernel, clang-built-linux, Nathan Chancellor
Clang warns:
In file included from
../drivers/net/ethernet/mellanox/mlx5/core/main.c:73:
../drivers/net/ethernet/mellanox/mlx5/core/diag/rsc_dump.h:4:9: warning:
'__MLX5_RSC_DUMP_H' is used as a header guard here, followed by #define
of a different macro [-Wheader-guard]
#ifndef __MLX5_RSC_DUMP_H
^~~~~~~~~~~~~~~~~
../drivers/net/ethernet/mellanox/mlx5/core/diag/rsc_dump.h:5:9: note:
'__MLX5_RSC_DUMP__H' is defined here; did you mean '__MLX5_RSC_DUMP_H'?
#define __MLX5_RSC_DUMP__H
^~~~~~~~~~~~~~~~~~
__MLX5_RSC_DUMP_H
1 warning generated.
Make them match to get the intended behavior and remove the warning.
Fixes: 12206b17235a ("net/mlx5: Add support for resource dump")
Link: https://github.com/ClangBuiltLinux/linux/issues/897
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
drivers/net/ethernet/mellanox/mlx5/core/diag/rsc_dump.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/diag/rsc_dump.h b/drivers/net/ethernet/mellanox/mlx5/core/diag/rsc_dump.h
index 3b7573461a45..148270073e71 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/diag/rsc_dump.h
+++ b/drivers/net/ethernet/mellanox/mlx5/core/diag/rsc_dump.h
@@ -2,7 +2,7 @@
/* Copyright (c) 2019 Mellanox Technologies. */
#ifndef __MLX5_RSC_DUMP_H
-#define __MLX5_RSC_DUMP__H
+#define __MLX5_RSC_DUMP_H
#include <linux/mlx5/driver.h>
#include "mlx5_core.h"
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net/mlx5: Fix header guard in rsc_dump.h
2020-02-21 5:24 [PATCH net-next] net/mlx5: Fix header guard in rsc_dump.h Nathan Chancellor
@ 2020-02-21 13:30 ` Jason Gunthorpe
2020-02-21 18:37 ` Saeed Mahameed
1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2020-02-21 13:30 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Saeed Mahameed, Leon Romanovsky, Aya Levin, Moshe Shemesh,
Jiri Pirko, netdev, linux-rdma, linux-kernel, clang-built-linux
On Thu, Feb 20, 2020 at 10:24:37PM -0700, Nathan Chancellor wrote:
> Clang warns:
>
> In file included from
> ../drivers/net/ethernet/mellanox/mlx5/core/main.c:73:
> ../drivers/net/ethernet/mellanox/mlx5/core/diag/rsc_dump.h:4:9: warning:
> '__MLX5_RSC_DUMP_H' is used as a header guard here, followed by #define
> of a different macro [-Wheader-guard]
> #ifndef __MLX5_RSC_DUMP_H
> ^~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/mellanox/mlx5/core/diag/rsc_dump.h:5:9: note:
> '__MLX5_RSC_DUMP__H' is defined here; did you mean '__MLX5_RSC_DUMP_H'?
> #define __MLX5_RSC_DUMP__H
> ^~~~~~~~~~~~~~~~~~
> __MLX5_RSC_DUMP_H
> 1 warning generated.
Wow, that is a neat warning
Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net/mlx5: Fix header guard in rsc_dump.h
2020-02-21 5:24 [PATCH net-next] net/mlx5: Fix header guard in rsc_dump.h Nathan Chancellor
2020-02-21 13:30 ` Jason Gunthorpe
@ 2020-02-21 18:37 ` Saeed Mahameed
1 sibling, 0 replies; 3+ messages in thread
From: Saeed Mahameed @ 2020-02-21 18:37 UTC (permalink / raw)
To: natechancellor, leon
Cc: Jiri Pirko, Aya Levin, clang-built-linux, netdev, linux-rdma,
Moshe Shemesh, linux-kernel
On Thu, 2020-02-20 at 22:24 -0700, Nathan Chancellor wrote:
> Clang warns:
>
> In file included from
> ../drivers/net/ethernet/mellanox/mlx5/core/main.c:73:
> ../drivers/net/ethernet/mellanox/mlx5/core/diag/rsc_dump.h:4:9:
> warning:
> '__MLX5_RSC_DUMP_H' is used as a header guard here, followed by
> #define
> of a different macro [-Wheader-guard]
> #ifndef __MLX5_RSC_DUMP_H
> ^~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/mellanox/mlx5/core/diag/rsc_dump.h:5:9:
> note:
> '__MLX5_RSC_DUMP__H' is defined here; did you mean
> '__MLX5_RSC_DUMP_H'?
> #define __MLX5_RSC_DUMP__H
> ^~~~~~~~~~~~~~~~~~
> __MLX5_RSC_DUMP_H
> 1 warning generated.
>
> Make them match to get the intended behavior and remove the warning.
Applied to net-next-mlx5
Thanks !
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-21 18:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-21 5:24 [PATCH net-next] net/mlx5: Fix header guard in rsc_dump.h Nathan Chancellor
2020-02-21 13:30 ` Jason Gunthorpe
2020-02-21 18:37 ` Saeed Mahameed
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).