Re: mmotm 2020-07-09-21-00 uploaded (drivers/net/ethernet/mellanox/mlx5/core/en_main.c)

Re: mmotm 2020-07-09-21-00 uploaded (drivers/net/ethernet/mellanox/mlx5/core/en_main.c)

[Randy Dunlap]

On 7/9/20 9:00 PM, Andrew Morton wrote:
> The mm-of-the-moment snapshot 2020-07-09-21-00 has been uploaded to
> 
>    http://www.ozlabs.org/~akpm/mmotm/
> 
> mmotm-readme.txt says
> 
> README for mm-of-the-moment:
> 
> http://www.ozlabs.org/~akpm/mmotm/
> 
> This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
> more than once a week.
> 
> You will need quilt to apply these patches to the latest Linus release (5.x
> or 5.x-rcY).  The series file is in broken-out.tar.gz and is duplicated in
> http://ozlabs.org/~akpm/mmotm/series
> 

on i386:

In file included from ../drivers/net/ethernet/mellanox/mlx5/core/en_main.c:49:0:
../drivers/net/ethernet/mellanox/mlx5/core/en_accel/en_accel.h: In function ‘mlx5e_accel_sk_get_rxq’:
../drivers/net/ethernet/mellanox/mlx5/core/en_accel/en_accel.h:153:12: error: implicit declaration of function ‘sk_rx_queue_get’; did you mean ‘sk_rx_queue_set’? [-Werror=implicit-function-declaration]
  int rxq = sk_rx_queue_get(sk);
            ^~~~~~~~~~~~~~~
            sk_rx_queue_set



-- 
~Randy
Reported-by: Randy Dunlap <rdunlap@infradead.org>

Re: mmotm 2020-07-09-21-00 uploaded (drivers/net/ethernet/mellanox/mlx5/core/en_main.c)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 802 bytes --]

Hi Randy,

On Fri, 10 Jul 2020 10:40:29 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
>
> on i386:
> 
> In file included from ../drivers/net/ethernet/mellanox/mlx5/core/en_main.c:49:0:
> ../drivers/net/ethernet/mellanox/mlx5/core/en_accel/en_accel.h: In function ‘mlx5e_accel_sk_get_rxq’:
> ../drivers/net/ethernet/mellanox/mlx5/core/en_accel/en_accel.h:153:12: error: implicit declaration of function ‘sk_rx_queue_get’; did you mean ‘sk_rx_queue_set’? [-Werror=implicit-function-declaration]
>   int rxq = sk_rx_queue_get(sk);
>             ^~~~~~~~~~~~~~~
>             sk_rx_queue_set

Caused by commit

  1182f3659357 ("net/mlx5e: kTLS, Add kTLS RX HW offload support")

from the net-next tree.  Presumably CONFIG_XPS is not set.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: mmotm 2020-07-09-21-00 uploaded (drivers/net/ethernet/mellanox/mlx5/core/en_main.c)

[Randy Dunlap]

On 7/12/20 9:02 PM, Stephen Rothwell wrote:
> Hi Randy,
> 
> On Fri, 10 Jul 2020 10:40:29 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> on i386:
>>
>> In file included from ../drivers/net/ethernet/mellanox/mlx5/core/en_main.c:49:0:
>> ../drivers/net/ethernet/mellanox/mlx5/core/en_accel/en_accel.h: In function ‘mlx5e_accel_sk_get_rxq’:
>> ../drivers/net/ethernet/mellanox/mlx5/core/en_accel/en_accel.h:153:12: error: implicit declaration of function ‘sk_rx_queue_get’; did you mean ‘sk_rx_queue_set’? [-Werror=implicit-function-declaration]
>>   int rxq = sk_rx_queue_get(sk);
>>             ^~~~~~~~~~~~~~~
>>             sk_rx_queue_set
> 
> Caused by commit
> 
>   1182f3659357 ("net/mlx5e: kTLS, Add kTLS RX HW offload support")
> 
> from the net-next tree.  Presumably CONFIG_XPS is not set.

Yes, that's correct.

-- 
~Randy

Re: mmotm 2020-07-09-21-00 uploaded (drivers/net/ethernet/mellanox/mlx5/core/en_main.c)

[Saeed Mahameed]

On Sun, 2020-07-12 at 21:17 -0700, Randy Dunlap wrote:
> On 7/12/20 9:02 PM, Stephen Rothwell wrote:
> > Hi Randy,
> > 
> > On Fri, 10 Jul 2020 10:40:29 -0700 Randy Dunlap <
> > rdunlap@infradead.org> wrote:
> > > on i386:
> > > 
> > > In file included from
> > > ../drivers/net/ethernet/mellanox/mlx5/core/en_main.c:49:0:
> > > ../drivers/net/ethernet/mellanox/mlx5/core/en_accel/en_accel.h:
> > > In function ‘mlx5e_accel_sk_get_rxq’:
> > > ../drivers/net/ethernet/mellanox/mlx5/core/en_accel/en_accel.h:15
> > > 3:12: error: implicit declaration of function ‘sk_rx_queue_get’;
> > > did you mean ‘sk_rx_queue_set’? [-Werror=implicit-function-
> > > declaration]
> > >   int rxq = sk_rx_queue_get(sk);
> > >             ^~~~~~~~~~~~~~~
> > >             sk_rx_queue_set
> > 
> > Caused by commit
> > 
> >   1182f3659357 ("net/mlx5e: kTLS, Add kTLS RX HW offload support")
> > 
> > from the net-next tree.  Presumably CONFIG_XPS is not set.
> 
> Yes, that's correct.
> 

Thanks for the report, we will handle and submit a patch to net-next.