From: Jonathan Toppins <jtoppins@redhat.com>
To: Jason Gunthorpe <jgg@mellanox.com>, Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
Leon Romanovsky <leonro@mellanox.com>,
RDMA mailing list <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH rdma-core] kernel-boot: Tighten check if device is virtual
Date: Thu, 26 Sep 2019 13:58:38 -0400 [thread overview]
Message-ID: <9c582ae3-8214-f9b8-d403-cf443b70284e@redhat.com> (raw)
In-Reply-To: <20190926123427.GD19509@mellanox.com>
On 09/26/2019 08:34 AM, Jason Gunthorpe wrote:
> On Thu, Sep 26, 2019 at 12:42:53PM +0300, Leon Romanovsky wrote:
>> From: Leon Romanovsky <leonro@mellanox.com>
>>
>> Virtual devices like SIW or RXE don't set FW version because
>> they don't have one, use that fact to rely on having empty
>> fw_ver file to sense such virtual devices.
>
> Have you checked that every physical device does set fw version?
>
> Seems hacky
agreed, how are tuntap devices handled, is there a similar handling that
can be applied here?
next prev parent reply other threads:[~2019-09-26 17:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 9:42 [PATCH rdma-core] kernel-boot: Tighten check if device is virtual Leon Romanovsky
2019-09-26 12:29 ` Leon Romanovsky
2019-09-26 12:34 ` Jason Gunthorpe
2019-09-26 12:42 ` Leon Romanovsky
2019-09-26 17:58 ` Jonathan Toppins [this message]
2019-09-28 16:54 ` Leon Romanovsky
2019-10-03 16:31 ` Jason Gunthorpe
2019-10-05 6:12 ` Leon Romanovsky
2019-10-02 11:47 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c582ae3-8214-f9b8-d403-cf443b70284e@redhat.com \
--to=jtoppins@redhat.com \
--cc=dledford@redhat.com \
--cc=jgg@mellanox.com \
--cc=leon@kernel.org \
--cc=leonro@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).