* [PATCH] RDMA/cma: add missed unregister_pernet_subsys in init failure
@ 2019-12-05 16:06 Chuhong Yuan
2019-12-05 18:49 ` Parav Pandit
0 siblings, 1 reply; 2+ messages in thread
From: Chuhong Yuan @ 2019-12-05 16:06 UTC (permalink / raw)
Cc: Doug Ledford, Jason Gunthorpe, linux-rdma, linux-kernel, Chuhong Yuan
The driver forgets to call unregister_pernet_subsys() in the error path
of cma_init().
Add the missed call to fix it.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
drivers/infiniband/core/cma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
index 25f2b70fd8ef..43a6f07e0afe 100644
--- a/drivers/infiniband/core/cma.c
+++ b/drivers/infiniband/core/cma.c
@@ -4763,6 +4763,7 @@ static int __init cma_init(void)
err:
unregister_netdevice_notifier(&cma_nb);
ib_sa_unregister_client(&sa_client);
+ unregister_pernet_subsys(&cma_pernet_operations);
err_wq:
destroy_workqueue(cma_wq);
return ret;
--
2.24.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] RDMA/cma: add missed unregister_pernet_subsys in init failure
2019-12-05 16:06 [PATCH] RDMA/cma: add missed unregister_pernet_subsys in init failure Chuhong Yuan
@ 2019-12-05 18:49 ` Parav Pandit
0 siblings, 0 replies; 2+ messages in thread
From: Parav Pandit @ 2019-12-05 18:49 UTC (permalink / raw)
To: Chuhong Yuan; +Cc: Doug Ledford, Jason Gunthorpe, linux-rdma, linux-kernel
> From: linux-kernel-owner@vger.kernel.org <linux-kernel-
> owner@vger.kernel.org> On Behalf Of Chuhong Yuan
> Sent: Thursday, December 5, 2019 10:07 AM
> The driver forgets to call unregister_pernet_subsys() in the error path of
> cma_init().
> Add the missed call to fix it.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---
> drivers/infiniband/core/cma.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
> index 25f2b70fd8ef..43a6f07e0afe 100644
> --- a/drivers/infiniband/core/cma.c
> +++ b/drivers/infiniband/core/cma.c
> @@ -4763,6 +4763,7 @@ static int __init cma_init(void)
> err:
> unregister_netdevice_notifier(&cma_nb);
> ib_sa_unregister_client(&sa_client);
> + unregister_pernet_subsys(&cma_pernet_operations);
> err_wq:
> destroy_workqueue(cma_wq);
> return ret;
> --
> 2.24.0
Please add to commit log.
Fixes: 4be74b42a6d0 ("IB/cma: Separate port allocation to network namespaces ")
Reviewed-by: Parav Pandit <parav@mellanox.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-05 18:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-05 16:06 [PATCH] RDMA/cma: add missed unregister_pernet_subsys in init failure Chuhong Yuan
2019-12-05 18:49 ` Parav Pandit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).