From: Selvin Xavier <selvin.xavier@broadcom.com>
To: Kamal Heib <kamalheib1@gmail.com>
Cc: linux-rdma@vger.kernel.org, Jason Gunthorpe <jgg@ziepe.ca>,
Doug Ledford <dledford@redhat.com>,
Devesh Sharma <devesh.sharma@broadcom.com>
Subject: Re: [PATCH for-rc] RDMA/bnxt_re: Set queue pair state when being queried
Date: Fri, 23 Oct 2020 17:38:04 +0530 [thread overview]
Message-ID: <CA+sbYW0hBMGqebUsYMDTyJeka67cRBh55PJYDpEwXbZwL=XbXQ@mail.gmail.com> (raw)
In-Reply-To: <20201021114952.38876-1-kamalheib1@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]
On Wed, Oct 21, 2020 at 5:20 PM Kamal Heib <kamalheib1@gmail.com> wrote:
>
> The API for ib_query_qp requires the driver to set cur_qp_state
> on return, add the missing set.
>
> Fixes: 1ac5a4047975 ("RDMA/bnxt_re: Add bnxt_re RoCE driver")
> Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
Acked-by: Selvin Xavier <selvin.xavier@broadcom.com>
Thanks
> ---
> drivers/infiniband/hw/bnxt_re/ib_verbs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
> index cf3db9628397..f9c999d5ba28 100644
> --- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c
> +++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
> @@ -2078,6 +2078,7 @@ int bnxt_re_query_qp(struct ib_qp *ib_qp, struct ib_qp_attr *qp_attr,
> goto out;
> }
> qp_attr->qp_state = __to_ib_qp_state(qplib_qp->state);
> + qp_attr->cur_qp_state = __to_ib_qp_state(qplib_qp->cur_qp_state);
> qp_attr->en_sqd_async_notify = qplib_qp->en_sqd_async_notify ? 1 : 0;
> qp_attr->qp_access_flags = __to_ib_access_flags(qplib_qp->access);
> qp_attr->pkey_index = qplib_qp->pkey_index;
> --
> 2.26.2
>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4181 bytes --]
next prev parent reply other threads:[~2020-10-23 12:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 11:49 [PATCH for-rc] RDMA/bnxt_re: Set queue pair state when being queried Kamal Heib
2020-10-23 12:08 ` Selvin Xavier [this message]
2020-10-26 22:25 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+sbYW0hBMGqebUsYMDTyJeka67cRBh55PJYDpEwXbZwL=XbXQ@mail.gmail.com' \
--to=selvin.xavier@broadcom.com \
--cc=devesh.sharma@broadcom.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kamalheib1@gmail.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).