* [PATCH for-rc] RDMA/bnxt_re: Set queue pair state when being queried
@ 2020-10-21 11:49 Kamal Heib
2020-10-23 12:08 ` Selvin Xavier
2020-10-26 22:25 ` Jason Gunthorpe
0 siblings, 2 replies; 3+ messages in thread
From: Kamal Heib @ 2020-10-21 11:49 UTC (permalink / raw)
To: linux-rdma
Cc: Jason Gunthorpe, Doug Ledford, Devesh Sharma, Selvin Xavier, Kamal Heib
The API for ib_query_qp requires the driver to set cur_qp_state
on return, add the missing set.
Fixes: 1ac5a4047975 ("RDMA/bnxt_re: Add bnxt_re RoCE driver")
Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
---
drivers/infiniband/hw/bnxt_re/ib_verbs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
index cf3db9628397..f9c999d5ba28 100644
--- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c
+++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
@@ -2078,6 +2078,7 @@ int bnxt_re_query_qp(struct ib_qp *ib_qp, struct ib_qp_attr *qp_attr,
goto out;
}
qp_attr->qp_state = __to_ib_qp_state(qplib_qp->state);
+ qp_attr->cur_qp_state = __to_ib_qp_state(qplib_qp->cur_qp_state);
qp_attr->en_sqd_async_notify = qplib_qp->en_sqd_async_notify ? 1 : 0;
qp_attr->qp_access_flags = __to_ib_access_flags(qplib_qp->access);
qp_attr->pkey_index = qplib_qp->pkey_index;
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH for-rc] RDMA/bnxt_re: Set queue pair state when being queried
2020-10-21 11:49 [PATCH for-rc] RDMA/bnxt_re: Set queue pair state when being queried Kamal Heib
@ 2020-10-23 12:08 ` Selvin Xavier
2020-10-26 22:25 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Selvin Xavier @ 2020-10-23 12:08 UTC (permalink / raw)
To: Kamal Heib; +Cc: linux-rdma, Jason Gunthorpe, Doug Ledford, Devesh Sharma
[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]
On Wed, Oct 21, 2020 at 5:20 PM Kamal Heib <kamalheib1@gmail.com> wrote:
>
> The API for ib_query_qp requires the driver to set cur_qp_state
> on return, add the missing set.
>
> Fixes: 1ac5a4047975 ("RDMA/bnxt_re: Add bnxt_re RoCE driver")
> Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
Acked-by: Selvin Xavier <selvin.xavier@broadcom.com>
Thanks
> ---
> drivers/infiniband/hw/bnxt_re/ib_verbs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
> index cf3db9628397..f9c999d5ba28 100644
> --- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c
> +++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
> @@ -2078,6 +2078,7 @@ int bnxt_re_query_qp(struct ib_qp *ib_qp, struct ib_qp_attr *qp_attr,
> goto out;
> }
> qp_attr->qp_state = __to_ib_qp_state(qplib_qp->state);
> + qp_attr->cur_qp_state = __to_ib_qp_state(qplib_qp->cur_qp_state);
> qp_attr->en_sqd_async_notify = qplib_qp->en_sqd_async_notify ? 1 : 0;
> qp_attr->qp_access_flags = __to_ib_access_flags(qplib_qp->access);
> qp_attr->pkey_index = qplib_qp->pkey_index;
> --
> 2.26.2
>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4181 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH for-rc] RDMA/bnxt_re: Set queue pair state when being queried
2020-10-21 11:49 [PATCH for-rc] RDMA/bnxt_re: Set queue pair state when being queried Kamal Heib
2020-10-23 12:08 ` Selvin Xavier
@ 2020-10-26 22:25 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2020-10-26 22:25 UTC (permalink / raw)
To: Kamal Heib; +Cc: linux-rdma, Doug Ledford, Devesh Sharma, Selvin Xavier
On Wed, Oct 21, 2020 at 02:49:52PM +0300, Kamal Heib wrote:
> The API for ib_query_qp requires the driver to set cur_qp_state
> on return, add the missing set.
>
> Fixes: 1ac5a4047975 ("RDMA/bnxt_re: Add bnxt_re RoCE driver")
> Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
> Acked-by: Selvin Xavier <selvin.xavier@broadcom.com>
> ---
> drivers/infiniband/hw/bnxt_re/ib_verbs.c | 1 +
> 1 file changed, 1 insertion(+)
Can't see why this would be for -rc since it has been broken forever
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-26 22:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-21 11:49 [PATCH for-rc] RDMA/bnxt_re: Set queue pair state when being queried Kamal Heib
2020-10-23 12:08 ` Selvin Xavier
2020-10-26 22:25 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).