* [PATCH rdma-next] RDMA/qedr: Fix rdma_type initialization
@ 2017-09-19 17:38 Michal Kalderon
[not found] ` <1505842717-26646-1-git-send-email-Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Michal Kalderon @ 2017-09-19 17:38 UTC (permalink / raw)
To: dledford-H+wXaHxf7aLQT0dZR+AlfA
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Michal Kalderon, Ariel Elior
Initialize the rdma_type (iWARP or RoCE) which is set according to
device configuration in qed.
Signed-off-by: Michal Kalderon <Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
Signed-off-by: Ariel Elior <Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
---
drivers/infiniband/hw/qedr/main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/infiniband/hw/qedr/main.c b/drivers/infiniband/hw/qedr/main.c
index ca93171..1afc267 100644
--- a/drivers/infiniband/hw/qedr/main.c
+++ b/drivers/infiniband/hw/qedr/main.c
@@ -870,6 +870,7 @@ static struct qedr_dev *qedr_add(struct qed_dev *cdev, struct pci_dev *pdev,
goto init_err;
dev->user_dpm_enabled = dev_info.user_dpm_enabled;
+ dev->rdma_type = dev_info.rdma_type;
dev->num_hwfns = dev_info.common.num_hwfns;
dev->rdma_ctx = dev->ops->rdma_get_rdma_ctx(cdev);
--
1.8.3.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH rdma-next] RDMA/qedr: Fix rdma_type initialization
[not found] ` <1505842717-26646-1-git-send-email-Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
@ 2017-09-19 17:47 ` Leon Romanovsky
[not found] ` <20170919174721.GL5788-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Leon Romanovsky @ 2017-09-19 17:47 UTC (permalink / raw)
To: Michal Kalderon
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA,
linux-rdma-u79uwXL29TY76Z2rM5mHXA, Ariel Elior
[-- Attachment #1: Type: text/plain, Size: 374 bytes --]
On Tue, Sep 19, 2017 at 08:38:37PM +0300, Michal Kalderon wrote:
> Initialize the rdma_type (iWARP or RoCE) which is set according to
> device configuration in qed.
>
> Signed-off-by: Michal Kalderon <Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Ariel Elior <Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
> ---
Please add Fixes.
Thanks
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH rdma-next] RDMA/qedr: Fix rdma_type initialization
[not found] ` <20170919174721.GL5788-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
@ 2017-09-20 5:42 ` Kalderon, Michal
[not found] ` <CY1PR0701MB2012B48FC05034ED663DB1D188610-UpKza+2NMNLHMJvQ0dyT705OhdzP3rhOnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Kalderon, Michal @ 2017-09-20 5:42 UTC (permalink / raw)
To: Leon Romanovsky
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA,
linux-rdma-u79uwXL29TY76Z2rM5mHXA, Elior, Ariel
From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Sent: Tuesday, September 19, 2017 8:47 PM
On Tue, Sep 19, 2017 at 08:38:37PM +0300, Michal Kalderon wrote:
>> Initialize the rdma_type (iWARP or RoCE) which is set according to
>> device configuration in qed.
>>
>> Signed-off-by: Michal Kalderon <Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
>> Signed-off-by: Ariel Elior <Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
>> ---
>
>Please add Fixes.
>
>Thanks
sure, i'll send v1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH rdma-next] RDMA/qedr: Fix rdma_type initialization
[not found] ` <CY1PR0701MB2012B48FC05034ED663DB1D188610-UpKza+2NMNLHMJvQ0dyT705OhdzP3rhOnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
@ 2017-09-25 12:29 ` Dennis Dalessandro
[not found] ` <1a07af53-0729-956e-129c-2c914e0e3d0c-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Dennis Dalessandro @ 2017-09-25 12:29 UTC (permalink / raw)
To: Kalderon, Michal, Leon Romanovsky
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA,
linux-rdma-u79uwXL29TY76Z2rM5mHXA, Elior, Ariel
On 9/20/2017 1:42 AM, Kalderon, Michal wrote:
> From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Sent: Tuesday, September 19, 2017 8:47 PM
>
> On Tue, Sep 19, 2017 at 08:38:37PM +0300, Michal Kalderon wrote:
>>> Initialize the rdma_type (iWARP or RoCE) which is set according to
>>> device configuration in qed.
>>>
>>> Signed-off-by: Michal Kalderon <Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
>>> Signed-off-by: Ariel Elior <Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
>>> ---
>>
>> Please add Fixes.
>>
>> Thanks
> sure, i'll send v1
Does just responding with a "Fixes" tag get appended automagically by
Patchworks?
-Denny
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH rdma-next] RDMA/qedr: Fix rdma_type initialization
[not found] ` <1a07af53-0729-956e-129c-2c914e0e3d0c-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
@ 2017-09-26 6:10 ` Leon Romanovsky
[not found] ` <20170926061005.GD1230-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Leon Romanovsky @ 2017-09-26 6:10 UTC (permalink / raw)
To: Dennis Dalessandro
Cc: Kalderon, Michal, dledford-H+wXaHxf7aLQT0dZR+AlfA,
linux-rdma-u79uwXL29TY76Z2rM5mHXA, Elior, Ariel
[-- Attachment #1: Type: text/plain, Size: 1014 bytes --]
On Mon, Sep 25, 2017 at 08:29:58AM -0400, Dennis Dalessandro wrote:
> On 9/20/2017 1:42 AM, Kalderon, Michal wrote:
> > From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> > Sent: Tuesday, September 19, 2017 8:47 PM
> >
> > On Tue, Sep 19, 2017 at 08:38:37PM +0300, Michal Kalderon wrote:
> > > > Initialize the rdma_type (iWARP or RoCE) which is set according to
> > > > device configuration in qed.
> > > >
> > > > Signed-off-by: Michal Kalderon <Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
> > > > Signed-off-by: Ariel Elior <Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
> > > > ---
> > >
> > > Please add Fixes.
> > >
> > > Thanks
> > sure, i'll send v1
>
> Does just responding with a "Fixes" tag get appended automagically by
> Patchworks?
I don't think so, but let's check with fixes line from v1.
Fixes: e6a38c54faf ("RDMA/qedr: Add support for registering an iWARP device")
The v0 patch is here https://patchwork.kernel.org/patch/9959815/
Thanks
>
> -Denny
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH rdma-next] RDMA/qedr: Fix rdma_type initialization
[not found] ` <20170926061005.GD1230-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
@ 2017-09-27 13:23 ` Doug Ledford
0 siblings, 0 replies; 6+ messages in thread
From: Doug Ledford @ 2017-09-27 13:23 UTC (permalink / raw)
To: Leon Romanovsky, Dennis Dalessandro
Cc: Kalderon, Michal, linux-rdma-u79uwXL29TY76Z2rM5mHXA, Elior, Ariel
On Tue, 2017-09-26 at 09:10 +0300, Leon Romanovsky wrote:
> On Mon, Sep 25, 2017 at 08:29:58AM -0400, Dennis Dalessandro wrote:
> > On 9/20/2017 1:42 AM, Kalderon, Michal wrote:
> > > From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> > > Sent: Tuesday, September 19, 2017 8:47 PM
> > >
> > > On Tue, Sep 19, 2017 at 08:38:37PM +0300, Michal Kalderon wrote:
> > > > > Initialize the rdma_type (iWARP or RoCE) which is set
> > > > > according to
> > > > > device configuration in qed.
> > > > >
> > > > > Signed-off-by: Michal Kalderon <Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
> > > > > Signed-off-by: Ariel Elior <Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
> > > > > ---
> > > >
> > > > Please add Fixes.
> > > >
> > > > Thanks
> > >
> > > sure, i'll send v1
> >
> > Does just responding with a "Fixes" tag get appended automagically
> > by
> > Patchworks?
>
> I don't think so, but let's check with fixes line from v1.
> Fixes: e6a38c54faf ("RDMA/qedr: Add support for registering an iWARP
> device")
Patchworks does, in fact, add the Fixes: line (although not in the
format we normally tell people to use as there is empty space between
the Fixes: line and the start of the Signed-off-by: lines).
However, that's all irrelevant, as this patch breaks the build for me.
Is there a prerequisite patch in net-next for this?
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-09-27 13:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-19 17:38 [PATCH rdma-next] RDMA/qedr: Fix rdma_type initialization Michal Kalderon
[not found] ` <1505842717-26646-1-git-send-email-Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
2017-09-19 17:47 ` Leon Romanovsky
[not found] ` <20170919174721.GL5788-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-09-20 5:42 ` Kalderon, Michal
[not found] ` <CY1PR0701MB2012B48FC05034ED663DB1D188610-UpKza+2NMNLHMJvQ0dyT705OhdzP3rhOnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2017-09-25 12:29 ` Dennis Dalessandro
[not found] ` <1a07af53-0729-956e-129c-2c914e0e3d0c-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-09-26 6:10 ` Leon Romanovsky
[not found] ` <20170926061005.GD1230-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-09-27 13:23 ` Doug Ledford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).