RE: Re: Re: [PATCH v3] RDMA/siw: Pass a pointer to virt_to_page()

RE: Re: Re: [PATCH v3] RDMA/siw: Pass a pointer to virt_to_page()

[Bernard Metzler]

> -----Original Message-----
> From: Linus Walleij <linus.walleij@linaro.org>
> Sent: Monday, 5 September 2022 14:08
> To: Bernard Metzler <BMT@zurich.ibm.com>
> Cc: Leon Romanovsky <leonro@nvidia.com>; Jason Gunthorpe
> <jgg@nvidia.com>; linux-rdma@vger.kernel.org
> Subject: [EXTERNAL] Re: Re: [PATCH v3] RDMA/siw: Pass a pointer to
> virt_to_page()
> 
> On Mon, Sep 5, 2022 at 2:02 PM Bernard Metzler <BMT@zurich.ibm.com>
> wrote:
> 
> > Can we easily fix the two line wraps introduced by this
> > patch? Without sending an explicit patch on top --
> 
> Yeah Lean can just augment it when applying.
> 
> > I'd
> > suggest adding just two line breaks to it. I'd be happy
> > to see siw code continues to adhere to the 80 char's
> > per line style.
> 
> You will be fighting an uphill battle since checkpatch (which is
> what we use to check syntax) now accepts 100 chars/line.
> commit bdc48fa11e46f867ea4d75fa59ee87a7f48be144
> "checkpatch/coding-style: deprecate 80-column warning"
> 
> If there is infiniband consensus to stay with 80 chars per
> line, you should send a patch to checkpatch so that it
> warns for this for patches to drivers/rdma.
> 


Right, we discussed that at the list before.
So far, we have that rdma subsystem internal consensus to
stay below 80 chars. Asking for an exception for checkpatch
may be even worse of an uphill battle.

Cheers,
Bernard.

> Yours,
> Linus Walleij