From: Alok Prasad <palok@marvell.com>
To: Jason Gunthorpe <jgg@nvidia.com>, Kamal Heib <kheib@redhat.com>
Cc: Michal Kalderon <mkalderon@marvell.com>,
Ariel Elior <aelior@marvell.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Shai Malin <smalin@marvell.com>, Ariel Elior <aelior@marvell.com>,
"alok.prasad7@gmail.com" <alok.prasad7@gmail.com>,
Michal Kalderon <mkalderon@marvell.com>,
"dledford@redhat.com" <dledford@redhat.com>
Subject: RE: [EXT] Re: [v2,for-rc] RDMA/qedr: qedr crash while running rdma-tool
Date: Wed, 27 Oct 2021 18:45:51 +0000 [thread overview]
Message-ID: <SJ0PR18MB39004E6B2255723159D74CEBA1859@SJ0PR18MB3900.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20211027170059.GA644717@nvidia.com>
> -----Original Message-----
> From: Jason Gunthorpe <jgg@nvidia.com>
> Sent: 27 October 2021 22:31
> To: Kamal Heib <kheib@redhat.com>
> Cc: Alok Prasad <palok@marvell.com>; Michal Kalderon <mkalderon@marvell.com>; Ariel Elior
> <aelior@marvell.com>; linux-rdma@vger.kernel.org; Shai Malin <smalin@marvell.com>; Ariel
> Elior <aelior@marvell.com>; alok.prasad7@gmail.com; Michal Kalderon
> <mkalderon@marvell.com>; dledford@redhat.com
> Subject: [EXT] Re: [v2,for-rc] RDMA/qedr: qedr crash while running rdma-tool
>
> External Email
>
> ----------------------------------------------------------------------
> On Sun, Oct 24, 2021 at 01:46:03PM +0300, Kamal Heib wrote:
>
> > > diff --git a/drivers/infiniband/hw/qedr/verbs.c b/drivers/infiniband/hw/qedr/verbs.c
> > > index dcb3653db72d..85baa4f730df 100644
> > > +++ b/drivers/infiniband/hw/qedr/verbs.c
> > > @@ -2744,15 +2744,20 @@ int qedr_query_qp(struct ib_qp *ibqp,
> > > int rc = 0;
> > > memset(¶ms, 0, sizeof(params));
> > > + memset(qp_attr, 0, sizeof(*qp_attr));
> > > + memset(qp_init_attr, 0, sizeof(*qp_init_attr));
> > > - rc = dev->ops->rdma_query_qp(dev->rdma_ctx, qp->qed_qp, ¶ms);
> > > + if (qp->qed_qp)
> >
> > I suggest to use "if (qp->qp_type != IB_QPT_GSI)" to match the handling of
> > GSI QPs in the QEDR driver.
>
> Alok? Time is closing to get this in before the merge window.
>
> Jason
Done now with v3, Sorry for delaying on this.
- Alok
prev parent reply other threads:[~2021-10-27 18:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-23 16:45 [v2,for-rc] RDMA/qedr: qedr crash while running rdma-tool Alok Prasad
2021-10-24 10:46 ` Kamal Heib
2021-10-27 17:00 ` Jason Gunthorpe
2021-10-27 18:45 ` Alok Prasad [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR18MB39004E6B2255723159D74CEBA1859@SJ0PR18MB3900.namprd18.prod.outlook.com \
--to=palok@marvell.com \
--cc=aelior@marvell.com \
--cc=alok.prasad7@gmail.com \
--cc=dledford@redhat.com \
--cc=jgg@nvidia.com \
--cc=kheib@redhat.com \
--cc=linux-rdma@vger.kernel.org \
--cc=mkalderon@marvell.com \
--cc=smalin@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).