* [PATCH 2/2] IB/rdmavt: don't use rdmavt for UML
@ 2022-11-30 20:09 Randy Dunlap
2022-12-01 9:22 ` Leon Romanovsky
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2022-11-30 20:09 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Jason Gunthorpe, Leon Romanovsky,
Dennis Dalessandro, linux-rdma, Jeff Dike, Richard Weinberger,
Anton Ivanov, Johannes Berg, linux-um
When building rdmavt for ARCH=um, qp.c has a build error on a reference
to the x86-specific cpuinfo field 'x86_cache_size'.
Fix the build errors by making this driver depend on !UML.
Prevents these build errors:
../drivers/infiniband/sw/rdmavt/qp.c: In function ‘rvt_wss_llc_size’:
../drivers/infiniband/sw/rdmavt/qp.c:88:29: error: ‘struct cpuinfo_um’ has no member named ‘x86_cache_size’
88 | return boot_cpu_data.x86_cache_size;
../drivers/infiniband/sw/rdmavt/qp.c: In function ‘cacheless_memcpy’:
../drivers/infiniband/sw/rdmavt/qp.c:100:9: error: implicit declaration of function ‘__copy_user_nocache’; did you mean ‘copy_user_page’? [-Werror=implicit-function-declaration]
100 | __copy_user_nocache(dst, (void __user *)src, n, 0);
../drivers/infiniband/sw/rdmavt/qp.c: In function ‘rvt_wss_llc_size’:
../drivers/infiniband/sw/rdmavt/qp.c:89:1: error: control reaches end of non-void function [-Werror=return-type]
89 | }
Fixes: 68f5d3f3b654 ("um: add PCI over virtio emulation driver")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Jason Gunthorpe <jgg@nvidia.com>
Cc: Leon Romanovsky <leon@kernel.org>
Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Cc: linux-rdma@vger.kernel.org
Cc: Jeff Dike <jdike@addtoit.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com>
Cc: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-um@lists.infradead.org
---
v2: rebase & resend
drivers/infiniband/sw/rdmavt/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -- a/drivers/infiniband/sw/rdmavt/Kconfig b/drivers/infiniband/sw/rdmavt/Kconfig
--- a/drivers/infiniband/sw/rdmavt/Kconfig
+++ b/drivers/infiniband/sw/rdmavt/Kconfig
@@ -2,7 +2,7 @@
config INFINIBAND_RDMAVT
tristate "RDMA verbs transport library"
depends on INFINIBAND_VIRT_DMA
- depends on X86_64
+ depends on X86_64 && !UML
depends on PCI
help
This is a common software verbs provider for RDMA networks.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] IB/rdmavt: don't use rdmavt for UML
2022-11-30 20:09 [PATCH 2/2] IB/rdmavt: don't use rdmavt for UML Randy Dunlap
@ 2022-12-01 9:22 ` Leon Romanovsky
0 siblings, 0 replies; 2+ messages in thread
From: Leon Romanovsky @ 2022-12-01 9:22 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Jason Gunthorpe, Dennis Dalessandro, linux-rdma,
Jeff Dike, Richard Weinberger, Anton Ivanov, Johannes Berg,
linux-um
On Wed, Nov 30, 2022 at 12:09:58PM -0800, Randy Dunlap wrote:
> When building rdmavt for ARCH=um, qp.c has a build error on a reference
> to the x86-specific cpuinfo field 'x86_cache_size'.
>
> Fix the build errors by making this driver depend on !UML.
>
> Prevents these build errors:
>
> ../drivers/infiniband/sw/rdmavt/qp.c: In function ‘rvt_wss_llc_size’:
> ../drivers/infiniband/sw/rdmavt/qp.c:88:29: error: ‘struct cpuinfo_um’ has no member named ‘x86_cache_size’
> 88 | return boot_cpu_data.x86_cache_size;
> ../drivers/infiniband/sw/rdmavt/qp.c: In function ‘cacheless_memcpy’:
> ../drivers/infiniband/sw/rdmavt/qp.c:100:9: error: implicit declaration of function ‘__copy_user_nocache’; did you mean ‘copy_user_page’? [-Werror=implicit-function-declaration]
> 100 | __copy_user_nocache(dst, (void __user *)src, n, 0);
> ../drivers/infiniband/sw/rdmavt/qp.c: In function ‘rvt_wss_llc_size’:
> ../drivers/infiniband/sw/rdmavt/qp.c:89:1: error: control reaches end of non-void function [-Werror=return-type]
> 89 | }
>
> Fixes: 68f5d3f3b654 ("um: add PCI over virtio emulation driver")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Jason Gunthorpe <jgg@nvidia.com>
> Cc: Leon Romanovsky <leon@kernel.org>
> Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
> Cc: linux-rdma@vger.kernel.org
> Cc: Jeff Dike <jdike@addtoit.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com>
> Cc: Johannes Berg <johannes@sipsolutions.net>
> Cc: linux-um@lists.infradead.org
> ---
> v2: rebase & resend
>
> drivers/infiniband/sw/rdmavt/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -- a/drivers/infiniband/sw/rdmavt/Kconfig b/drivers/infiniband/sw/rdmavt/Kconfig
> --- a/drivers/infiniband/sw/rdmavt/Kconfig
> +++ b/drivers/infiniband/sw/rdmavt/Kconfig
> @@ -2,7 +2,7 @@
> config INFINIBAND_RDMAVT
> tristate "RDMA verbs transport library"
> depends on INFINIBAND_VIRT_DMA
> - depends on X86_64
> + depends on X86_64 && !UML
Same comment as for patch #1.
> depends on PCI
> help
> This is a common software verbs provider for RDMA networks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-01 9:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-30 20:09 [PATCH 2/2] IB/rdmavt: don't use rdmavt for UML Randy Dunlap
2022-12-01 9:22 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).