* [PATCH] RDMA/ipoib: print a message if only child interface is UP
@ 2021-04-08 8:34 Jack Wang
2021-04-08 9:10 ` Leon Romanovsky
0 siblings, 1 reply; 3+ messages in thread
From: Jack Wang @ 2021-04-08 8:34 UTC (permalink / raw)
To: linux-rdma; +Cc: bvanassche, leon, dledford, jgg
When "enhanced IPoIB" enabled for CX-5 devices, it requires
the parent device to be UP, otherwise the child devices won't
work.[1]
This add a debug message to give admin a hint, if only child interface
is UP, but parent interface is not.
[1]https://lore.kernel.org/linux-rdma/CAMGffE=3YYxv9i7_qQr3-Uv-NGr-7VsnMk8DTjR0YbX1vJBzXQ@mail.gmail.com/T/#u
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
---
drivers/infiniband/ulp/ipoib/ipoib_main.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
index e16b40c09f82..782b792985b8 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
@@ -164,8 +164,12 @@ int ipoib_open(struct net_device *dev)
dev_change_flags(cpriv->dev, flags | IFF_UP, NULL);
}
up_read(&priv->vlan_rwsem);
- }
+ } else if (priv->parent) {
+ struct ipoib_dev_priv *ppriv = ipoib_priv(priv->parent);
+ if (!test_bit(IPOIB_FLAG_ADMIN_UP, &ppriv->flags))
+ ipoib_dbg(priv, "parent deivce %s is not up, so child may be not functioning.\n", ((struct ipoib_dev_priv *) ppriv)->dev->name);
+ }
netif_start_queue(dev);
return 0;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] RDMA/ipoib: print a message if only child interface is UP
2021-04-08 8:34 [PATCH] RDMA/ipoib: print a message if only child interface is UP Jack Wang
@ 2021-04-08 9:10 ` Leon Romanovsky
2021-04-08 9:31 ` Jinpu Wang
0 siblings, 1 reply; 3+ messages in thread
From: Leon Romanovsky @ 2021-04-08 9:10 UTC (permalink / raw)
To: Jack Wang; +Cc: linux-rdma, bvanassche, dledford, jgg
On Thu, Apr 08, 2021 at 10:34:35AM +0200, Jack Wang wrote:
> When "enhanced IPoIB" enabled for CX-5 devices, it requires
> the parent device to be UP, otherwise the child devices won't
> work.[1]
>
> This add a debug message to give admin a hint, if only child interface
> is UP, but parent interface is not.
>
> [1]https://lore.kernel.org/linux-rdma/CAMGffE=3YYxv9i7_qQr3-Uv-NGr-7VsnMk8DTjR0YbX1vJBzXQ@mail.gmail.com/T/#u
> Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
> ---
> drivers/infiniband/ulp/ipoib/ipoib_main.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> index e16b40c09f82..782b792985b8 100644
> --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
> +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> @@ -164,8 +164,12 @@ int ipoib_open(struct net_device *dev)
> dev_change_flags(cpriv->dev, flags | IFF_UP, NULL);
> }
> up_read(&priv->vlan_rwsem);
> - }
> + } else if (priv->parent) {
> + struct ipoib_dev_priv *ppriv = ipoib_priv(priv->parent);
>
> + if (!test_bit(IPOIB_FLAG_ADMIN_UP, &ppriv->flags))
> + ipoib_dbg(priv, "parent deivce %s is not up, so child may be not functioning.\n", ((struct ipoib_dev_priv *) ppriv)->dev->name);
Why do you need extra casting? "ppriv" is already "struct ipoib_dev_priv *".
Thanks
> + }
> netif_start_queue(dev);
>
> return 0;
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] RDMA/ipoib: print a message if only child interface is UP
2021-04-08 9:10 ` Leon Romanovsky
@ 2021-04-08 9:31 ` Jinpu Wang
0 siblings, 0 replies; 3+ messages in thread
From: Jinpu Wang @ 2021-04-08 9:31 UTC (permalink / raw)
To: Leon Romanovsky
Cc: linux-rdma, Bart Van Assche, Doug Ledford, Jason Gunthorpe
On Thu, Apr 8, 2021 at 11:10 AM Leon Romanovsky <leon@kernel.org> wrote:
>
> On Thu, Apr 08, 2021 at 10:34:35AM +0200, Jack Wang wrote:
> > When "enhanced IPoIB" enabled for CX-5 devices, it requires
> > the parent device to be UP, otherwise the child devices won't
> > work.[1]
> >
> > This add a debug message to give admin a hint, if only child interface
> > is UP, but parent interface is not.
> >
> > [1]https://lore.kernel.org/linux-rdma/CAMGffE=3YYxv9i7_qQr3-Uv-NGr-7VsnMk8DTjR0YbX1vJBzXQ@mail.gmail.com/T/#u
> > Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
> > ---
> > drivers/infiniband/ulp/ipoib/ipoib_main.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> > index e16b40c09f82..782b792985b8 100644
> > --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
> > +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> > @@ -164,8 +164,12 @@ int ipoib_open(struct net_device *dev)
> > dev_change_flags(cpriv->dev, flags | IFF_UP, NULL);
> > }
> > up_read(&priv->vlan_rwsem);
> > - }
> > + } else if (priv->parent) {
> > + struct ipoib_dev_priv *ppriv = ipoib_priv(priv->parent);
> >
> > + if (!test_bit(IPOIB_FLAG_ADMIN_UP, &ppriv->flags))
> > + ipoib_dbg(priv, "parent deivce %s is not up, so child may be not functioning.\n", ((struct ipoib_dev_priv *) ppriv)->dev->name);
>
> Why do you need extra casting? "ppriv" is already "struct ipoib_dev_priv *".
Indeed, will remove that.
Thanks
>
> Thanks
>
> > + }
> > netif_start_queue(dev);
> >
> > return 0;
> > --
> > 2.25.1
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-08 9:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08 8:34 [PATCH] RDMA/ipoib: print a message if only child interface is UP Jack Wang
2021-04-08 9:10 ` Leon Romanovsky
2021-04-08 9:31 ` Jinpu Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).