* [PATCH for-next] IB/core: Add xrc opcodes to ib_pack.h
@ 2021-07-26 23:10 Bob Pearson
2021-07-27 10:43 ` Leon Romanovsky
0 siblings, 1 reply; 4+ messages in thread
From: Bob Pearson @ 2021-07-26 23:10 UTC (permalink / raw)
To: jgg, zyjzyj2000, linux-rdma; +Cc: Bob Pearson
ib_pack.h defines enums for all the RDMA opcodes except for the XRC
opcodes. This patch adds those opcodes.
Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com>
---
include/rdma/ib_pack.h | 28 +++++++++++++++++++++++++++-
1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/include/rdma/ib_pack.h b/include/rdma/ib_pack.h
index a9162f25beaf..afbf78a6669e 100644
--- a/include/rdma/ib_pack.h
+++ b/include/rdma/ib_pack.h
@@ -56,6 +56,7 @@ enum {
IB_OPCODE_UD = 0x60,
/* per IBTA 1.3 vol 1 Table 38, A10.3.2 */
IB_OPCODE_CNP = 0x80,
+ IB_OPCODE_XRC = 0xa0,
/* Manufacturer specific */
IB_OPCODE_MSP = 0xe0,
@@ -152,7 +153,32 @@ enum {
/* UD */
IB_OPCODE(UD, SEND_ONLY),
- IB_OPCODE(UD, SEND_ONLY_WITH_IMMEDIATE)
+ IB_OPCODE(UD, SEND_ONLY_WITH_IMMEDIATE),
+
+ /* XRC */
+ IB_OPCODE(XRC, SEND_FIRST),
+ IB_OPCODE(XRC, SEND_MIDDLE),
+ IB_OPCODE(XRC, SEND_LAST),
+ IB_OPCODE(XRC, SEND_LAST_WITH_IMMEDIATE),
+ IB_OPCODE(XRC, SEND_ONLY),
+ IB_OPCODE(XRC, SEND_ONLY_WITH_IMMEDIATE),
+ IB_OPCODE(XRC, RDMA_WRITE_FIRST),
+ IB_OPCODE(XRC, RDMA_WRITE_MIDDLE),
+ IB_OPCODE(XRC, RDMA_WRITE_LAST),
+ IB_OPCODE(XRC, RDMA_WRITE_LAST_WITH_IMMEDIATE),
+ IB_OPCODE(XRC, RDMA_WRITE_ONLY),
+ IB_OPCODE(XRC, RDMA_WRITE_ONLY_WITH_IMMEDIATE),
+ IB_OPCODE(XRC, RDMA_READ_REQUEST),
+ IB_OPCODE(XRC, RDMA_READ_RESPONSE_FIRST),
+ IB_OPCODE(XRC, RDMA_READ_RESPONSE_MIDDLE),
+ IB_OPCODE(XRC, RDMA_READ_RESPONSE_LAST),
+ IB_OPCODE(XRC, RDMA_READ_RESPONSE_ONLY),
+ IB_OPCODE(XRC, ACKNOWLEDGE),
+ IB_OPCODE(XRC, ATOMIC_ACKNOWLEDGE),
+ IB_OPCODE(XRC, COMPARE_SWAP),
+ IB_OPCODE(XRC, FETCH_ADD),
+ IB_OPCODE(XRC, SEND_LAST_WITH_INVALIDATE),
+ IB_OPCODE(XRC, SEND_ONLY_WITH_INVALIDATE)
};
enum {
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH for-next] IB/core: Add xrc opcodes to ib_pack.h
2021-07-26 23:10 [PATCH for-next] IB/core: Add xrc opcodes to ib_pack.h Bob Pearson
@ 2021-07-27 10:43 ` Leon Romanovsky
2021-07-27 11:23 ` Bob Pearson
0 siblings, 1 reply; 4+ messages in thread
From: Leon Romanovsky @ 2021-07-27 10:43 UTC (permalink / raw)
To: Bob Pearson; +Cc: jgg, zyjzyj2000, linux-rdma
On Mon, Jul 26, 2021 at 06:10:10PM -0500, Bob Pearson wrote:
> ib_pack.h defines enums for all the RDMA opcodes except for the XRC
> opcodes. This patch adds those opcodes.
Why do we need such patch? What does it fix? What didn't work before?
Thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH for-next] IB/core: Add xrc opcodes to ib_pack.h
2021-07-27 10:43 ` Leon Romanovsky
@ 2021-07-27 11:23 ` Bob Pearson
2021-07-27 12:02 ` Leon Romanovsky
0 siblings, 1 reply; 4+ messages in thread
From: Bob Pearson @ 2021-07-27 11:23 UTC (permalink / raw)
To: Leon Romanovsky; +Cc: jgg, zyjzyj2000, linux-rdma
On 7/27/21 5:43 AM, Leon Romanovsky wrote:
> On Mon, Jul 26, 2021 at 06:10:10PM -0500, Bob Pearson wrote:
>> ib_pack.h defines enums for all the RDMA opcodes except for the XRC
>> opcodes. This patch adds those opcodes.
>
> Why do we need such patch? What does it fix? What didn't work before?
>
> Thanks
>
I'm working on implementing xrc for rxe. It uses the opcodes from ib_pack.h. So I have to either add the
opcodes to ib_pack.h or redefine all the opcodes in the rxe driver.
This seems like the better solution of the two.
Bob
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH for-next] IB/core: Add xrc opcodes to ib_pack.h
2021-07-27 11:23 ` Bob Pearson
@ 2021-07-27 12:02 ` Leon Romanovsky
0 siblings, 0 replies; 4+ messages in thread
From: Leon Romanovsky @ 2021-07-27 12:02 UTC (permalink / raw)
To: Bob Pearson; +Cc: jgg, zyjzyj2000, linux-rdma
On Tue, Jul 27, 2021 at 06:23:48AM -0500, Bob Pearson wrote:
> On 7/27/21 5:43 AM, Leon Romanovsky wrote:
> > On Mon, Jul 26, 2021 at 06:10:10PM -0500, Bob Pearson wrote:
> >> ib_pack.h defines enums for all the RDMA opcodes except for the XRC
> >> opcodes. This patch adds those opcodes.
> >
> > Why do we need such patch? What does it fix? What didn't work before?
> >
> > Thanks
> >
> I'm working on implementing xrc for rxe. It uses the opcodes from ib_pack.h. So I have to either add the
> opcodes to ib_pack.h or redefine all the opcodes in the rxe driver.
> This seems like the better solution of the two.
So please submit it together with your XRC series.
Thanks
>
> Bob
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-07-27 12:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-26 23:10 [PATCH for-next] IB/core: Add xrc opcodes to ib_pack.h Bob Pearson
2021-07-27 10:43 ` Leon Romanovsky
2021-07-27 11:23 ` Bob Pearson
2021-07-27 12:02 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).