* [PATCH 02/20] net/mlx5e: drop useless LIST_HEAD
2018-12-23 8:56 [PATCH 00/20] drop useless LIST_HEAD Julia Lawall
@ 2018-12-23 8:56 ` Julia Lawall
2018-12-23 9:40 ` Leon Romanovsky
2018-12-23 8:57 ` [PATCH 06/20] IB/ipoib: " Julia Lawall
` (3 subsequent siblings)
4 siblings, 1 reply; 14+ messages in thread
From: Julia Lawall @ 2018-12-23 8:56 UTC (permalink / raw)
To: Saeed Mahameed
Cc: kernel-janitors, Leon Romanovsky, David S. Miller, netdev,
linux-rdma, linux-kernel
Drop LIST_HEAD where the variable it declares is never used.
These became useless in 244cd96adb5f ("net_sched: remove list_head
from tc_action")
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier x;
@@
- LIST_HEAD(x);
... when != x
// </smpl>
Fixes: 244cd96adb5f ("net_sched: remove list_head from tc_action")
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
Successfully 0-day tested on 151 configurations.
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
index 4d6c9757afad..cae6c6d48984 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
@@ -2183,7 +2183,6 @@ static bool modify_header_match_supported(struct mlx5_flow_spec *spec,
{
const struct tc_action *a;
bool modify_ip_header;
- LIST_HEAD(actions);
u8 htype, ip_proto;
void *headers_v;
u16 ethertype;
@@ -2272,7 +2271,6 @@ static int parse_tc_nic_actions(struct mlx5e_priv *priv, struct tcf_exts *exts,
{
struct mlx5_nic_flow_attr *attr = flow->nic_attr;
const struct tc_action *a;
- LIST_HEAD(actions);
u32 action = 0;
int err, i;
@@ -2511,7 +2509,6 @@ static int parse_tc_fdb_actions(struct mlx5e_priv *priv, struct tcf_exts *exts,
struct mlx5e_rep_priv *rpriv = priv->ppriv;
struct ip_tunnel_info *info = NULL;
const struct tc_action *a;
- LIST_HEAD(actions);
bool encap = false;
u32 action = 0;
int err, i;
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 02/20] net/mlx5e: drop useless LIST_HEAD
2018-12-23 8:56 ` [PATCH 02/20] net/mlx5e: " Julia Lawall
@ 2018-12-23 9:40 ` Leon Romanovsky
0 siblings, 0 replies; 14+ messages in thread
From: Leon Romanovsky @ 2018-12-23 9:40 UTC (permalink / raw)
To: Julia Lawall
Cc: Saeed Mahameed, kernel-janitors, David S. Miller, netdev,
linux-rdma, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 583 bytes --]
On Sun, Dec 23, 2018 at 09:56:57AM +0100, Julia Lawall wrote:
> Drop LIST_HEAD where the variable it declares is never used.
>
> These became useless in 244cd96adb5f ("net_sched: remove list_head
> from tc_action")
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> identifier x;
> @@
> - LIST_HEAD(x);
> ... when != x
> // </smpl>
>
> Fixes: 244cd96adb5f ("net_sched: remove list_head from tc_action")
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 06/20] IB/ipoib: drop useless LIST_HEAD
2018-12-23 8:56 [PATCH 00/20] drop useless LIST_HEAD Julia Lawall
2018-12-23 8:56 ` [PATCH 02/20] net/mlx5e: " Julia Lawall
@ 2018-12-23 8:57 ` Julia Lawall
2018-12-23 9:41 ` Leon Romanovsky
2019-01-02 22:48 ` Jason Gunthorpe
2018-12-23 8:57 ` [PATCH 19/20] net/mlx4_core: " Julia Lawall
` (2 subsequent siblings)
4 siblings, 2 replies; 14+ messages in thread
From: Julia Lawall @ 2018-12-23 8:57 UTC (permalink / raw)
To: Doug Ledford; +Cc: kernel-janitors, Jason Gunthorpe, linux-rdma, linux-kernel
Drop LIST_HEAD where the variable it declares is never used.
Commit 31c02e215700 ("IPoIB: Avoid using stale last_send counter
when reaping AHs") removed the uses, but not the declaration.
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier x;
@@
- LIST_HEAD(x);
... when != x
// </smpl>
Fixes: 31c02e215700 ("IPoIB: Avoid using stale last_send counter when reaping AHs")
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
Successfully 0-day tested on 151 configurations.
drivers/infiniband/ulp/ipoib/ipoib_ib.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_ib.c b/drivers/infiniband/ulp/ipoib/ipoib_ib.c
index 6d35570092d6..78fa777c87b1 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_ib.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_ib.c
@@ -669,7 +669,6 @@ static void __ipoib_reap_ah(struct net_device *dev)
{
struct ipoib_dev_priv *priv = ipoib_priv(dev);
struct ipoib_ah *ah, *tah;
- LIST_HEAD(remove_list);
unsigned long flags;
netif_tx_lock_bh(dev);
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 06/20] IB/ipoib: drop useless LIST_HEAD
2018-12-23 8:57 ` [PATCH 06/20] IB/ipoib: " Julia Lawall
@ 2018-12-23 9:41 ` Leon Romanovsky
2019-01-02 22:48 ` Jason Gunthorpe
1 sibling, 0 replies; 14+ messages in thread
From: Leon Romanovsky @ 2018-12-23 9:41 UTC (permalink / raw)
To: Julia Lawall
Cc: Doug Ledford, kernel-janitors, Jason Gunthorpe, linux-rdma, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 643 bytes --]
On Sun, Dec 23, 2018 at 09:57:01AM +0100, Julia Lawall wrote:
> Drop LIST_HEAD where the variable it declares is never used.
>
> Commit 31c02e215700 ("IPoIB: Avoid using stale last_send counter
> when reaping AHs") removed the uses, but not the declaration.
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> identifier x;
> @@
> - LIST_HEAD(x);
> ... when != x
> // </smpl>
>
> Fixes: 31c02e215700 ("IPoIB: Avoid using stale last_send counter when reaping AHs")
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 06/20] IB/ipoib: drop useless LIST_HEAD
2018-12-23 8:57 ` [PATCH 06/20] IB/ipoib: " Julia Lawall
2018-12-23 9:41 ` Leon Romanovsky
@ 2019-01-02 22:48 ` Jason Gunthorpe
1 sibling, 0 replies; 14+ messages in thread
From: Jason Gunthorpe @ 2019-01-02 22:48 UTC (permalink / raw)
To: Julia Lawall; +Cc: Doug Ledford, kernel-janitors, linux-rdma, linux-kernel
On Sun, Dec 23, 2018 at 09:57:01AM +0100, Julia Lawall wrote:
> Drop LIST_HEAD where the variable it declares is never used.
>
> Commit 31c02e215700 ("IPoIB: Avoid using stale last_send counter
> when reaping AHs") removed the uses, but not the declaration.
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> identifier x;
> @@
> - LIST_HEAD(x);
> ... when != x
> // </smpl>
>
> Fixes: 31c02e215700 ("IPoIB: Avoid using stale last_send counter when reaping AHs")
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
> ---
> Successfully 0-day tested on 151 configurations.
>
> drivers/infiniband/ulp/ipoib/ipoib_ib.c | 1 -
> 1 file changed, 1 deletion(-)
Applied to rdma for-next thanks
Jason
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 19/20] net/mlx4_core: drop useless LIST_HEAD
2018-12-23 8:56 [PATCH 00/20] drop useless LIST_HEAD Julia Lawall
2018-12-23 8:56 ` [PATCH 02/20] net/mlx5e: " Julia Lawall
2018-12-23 8:57 ` [PATCH 06/20] IB/ipoib: " Julia Lawall
@ 2018-12-23 8:57 ` Julia Lawall
2018-12-23 12:13 ` [PATCH 00/20] " SF Markus Elfring
2018-12-23 21:49 ` Tom Psyborg
4 siblings, 0 replies; 14+ messages in thread
From: Julia Lawall @ 2018-12-23 8:57 UTC (permalink / raw)
To: Tariq Toukan
Cc: kernel-janitors, David S. Miller, netdev, linux-rdma, linux-kernel
Drop LIST_HEAD where the variable it declares has never
been used.
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier x;
@@
- LIST_HEAD(x);
... when != x
// </smpl>
Fixes: c82e9aa0a8bc ("mlx4_core: resource tracking for HCA resources used by guests")
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
Successfully 0-day tested on 151 configurations.
drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c
index 31bd56727022..eb13d3618162 100644
--- a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c
+++ b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c
@@ -4729,7 +4729,6 @@ static void rem_slave_srqs(struct mlx4_dev *dev, int slave)
struct res_srq *tmp;
int state;
u64 in_param;
- LIST_HEAD(tlist);
int srqn;
int err;
@@ -4795,7 +4794,6 @@ static void rem_slave_cqs(struct mlx4_dev *dev, int slave)
struct res_cq *tmp;
int state;
u64 in_param;
- LIST_HEAD(tlist);
int cqn;
int err;
@@ -4858,7 +4856,6 @@ static void rem_slave_mrs(struct mlx4_dev *dev, int slave)
struct res_mpt *tmp;
int state;
u64 in_param;
- LIST_HEAD(tlist);
int mptn;
int err;
@@ -4926,7 +4923,6 @@ static void rem_slave_mtts(struct mlx4_dev *dev, int slave)
struct res_mtt *mtt;
struct res_mtt *tmp;
int state;
- LIST_HEAD(tlist);
int base;
int err;
@@ -5115,7 +5111,6 @@ static void rem_slave_eqs(struct mlx4_dev *dev, int slave)
struct res_eq *tmp;
int err;
int state;
- LIST_HEAD(tlist);
int eqn;
err = move_all_busy(dev, slave, RES_EQ);
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 00/20] drop useless LIST_HEAD
2018-12-23 8:56 [PATCH 00/20] drop useless LIST_HEAD Julia Lawall
` (2 preceding siblings ...)
2018-12-23 8:57 ` [PATCH 19/20] net/mlx4_core: " Julia Lawall
@ 2018-12-23 12:13 ` SF Markus Elfring
2018-12-23 21:49 ` Tom Psyborg
4 siblings, 0 replies; 14+ messages in thread
From: SF Markus Elfring @ 2018-12-23 12:13 UTC (permalink / raw)
To: Julia Lawall, kernel-janitors
Cc: linux-nfs, Stefano Stabellini, linux-scsi, linux-rdma, netdev,
linux-wireless, linux-kernel, linux-xfs, linux-arm-kernel,
dmaengine, xen-devel, Dan Williams, Andy Shevchenko, linux-btrfs
> Drop LIST_HEAD where the variable it declares is never used.
Do you know any more places where calls of other macros can be deleted?
Regards,
Markus
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 00/20] drop useless LIST_HEAD
2018-12-23 8:56 [PATCH 00/20] drop useless LIST_HEAD Julia Lawall
` (3 preceding siblings ...)
2018-12-23 12:13 ` [PATCH 00/20] " SF Markus Elfring
@ 2018-12-23 21:49 ` Tom Psyborg
2018-12-23 22:06 ` Julia Lawall
4 siblings, 1 reply; 14+ messages in thread
From: Tom Psyborg @ 2018-12-23 21:49 UTC (permalink / raw)
To: Julia Lawall
Cc: Andy Shevchenko, kernel-janitors, dmaengine, linux-arm-kernel,
Dan Williams, linux-scsi, linux-nfs, linux-kernel, netdev,
linux-rdma, linux-xfs, linux-btrfs, Stefano Stabellini,
xen-devel, linux-wireless
Why do you CC this to so many lists?
On 23/12/2018, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> Drop LIST_HEAD where the variable it declares is never used.
>
> ---
>
> drivers/dma/at_hdmac.c | 5 -----
> drivers/dma/dw/core.c | 1 -
> drivers/dma/pl330.c | 1 -
> drivers/dma/sa11x0-dma.c | 2 --
> drivers/dma/st_fdma.c | 3 ---
> drivers/infiniband/ulp/ipoib/ipoib_ib.c | 1 -
> drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | 5 -----
> drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 3 ---
> drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 1 -
> drivers/net/wireless/st/cw1200/queue.c | 1 -
> drivers/scsi/lpfc/lpfc_nvme.c | 2 --
> drivers/scsi/lpfc/lpfc_scsi.c | 2 --
> drivers/scsi/lpfc/lpfc_sli.c | 1 -
> drivers/scsi/qla2xxx/qla_init.c | 1 -
> drivers/xen/xenbus/xenbus_dev_frontend.c | 2 --
> fs/btrfs/relocation.c | 1 -
> fs/nfs/nfs4client.c | 1 -
> fs/nfsd/nfs4layouts.c | 1 -
> fs/xfs/xfs_buf.c | 1 -
> fs/xfs/xfs_fsops.c | 1 -
> 20 files changed, 36 deletions(-)
>
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 00/20] drop useless LIST_HEAD
2018-12-23 21:49 ` Tom Psyborg
@ 2018-12-23 22:06 ` Julia Lawall
2018-12-25 22:12 ` Tom Psyborg
0 siblings, 1 reply; 14+ messages in thread
From: Julia Lawall @ 2018-12-23 22:06 UTC (permalink / raw)
To: Tom Psyborg
Cc: Julia Lawall, Andy Shevchenko, kernel-janitors, dmaengine,
linux-arm-kernel, Dan Williams, linux-scsi, linux-nfs,
linux-kernel, netdev, linux-rdma, linux-xfs, linux-btrfs,
Stefano Stabellini, xen-devel, linux-wireless
On Sun, 23 Dec 2018, Tom Psyborg wrote:
> Why do you CC this to so many lists?
Because the different files are in different subsystems. The cover letter
goes to a list for each file, or to a person if there is no list. The
patches go to the people and lists associated with the affected files.
julia
>
> On 23/12/2018, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> > Drop LIST_HEAD where the variable it declares is never used.
> >
> > ---
> >
> > drivers/dma/at_hdmac.c | 5 -----
> > drivers/dma/dw/core.c | 1 -
> > drivers/dma/pl330.c | 1 -
> > drivers/dma/sa11x0-dma.c | 2 --
> > drivers/dma/st_fdma.c | 3 ---
> > drivers/infiniband/ulp/ipoib/ipoib_ib.c | 1 -
> > drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | 5 -----
> > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 3 ---
> > drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 1 -
> > drivers/net/wireless/st/cw1200/queue.c | 1 -
> > drivers/scsi/lpfc/lpfc_nvme.c | 2 --
> > drivers/scsi/lpfc/lpfc_scsi.c | 2 --
> > drivers/scsi/lpfc/lpfc_sli.c | 1 -
> > drivers/scsi/qla2xxx/qla_init.c | 1 -
> > drivers/xen/xenbus/xenbus_dev_frontend.c | 2 --
> > fs/btrfs/relocation.c | 1 -
> > fs/nfs/nfs4client.c | 1 -
> > fs/nfsd/nfs4layouts.c | 1 -
> > fs/xfs/xfs_buf.c | 1 -
> > fs/xfs/xfs_fsops.c | 1 -
> > 20 files changed, 36 deletions(-)
> >
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 00/20] drop useless LIST_HEAD
2018-12-23 22:06 ` Julia Lawall
@ 2018-12-25 22:12 ` Tom Psyborg
2018-12-27 13:40 ` Dan Carpenter
0 siblings, 1 reply; 14+ messages in thread
From: Tom Psyborg @ 2018-12-25 22:12 UTC (permalink / raw)
To: Julia Lawall
Cc: Andy Shevchenko, kernel-janitors-u79uwXL29TY76Z2rM5mHXA,
dmaengine-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Dan Williams,
linux-scsi-u79uwXL29TY76Z2rM5mHXA,
linux-nfs-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA, linux-rdma-u79uwXL29TY76Z2rM5mHXA,
linux-xfs-u79uwXL29TY76Z2rM5mHXA,
linux-btrfs-u79uwXL29TY76Z2rM5mHXA, Stefano Stabellini,
xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b,
linux-wireless-u79uwXL29TY76Z2rM5mHXA
there was discussion about this just some days ago. CC 4-5 lists is
more than enough
On 23/12/2018, Julia Lawall <julia.lawall-L2FTfq7BK8M@public.gmane.org> wrote:
>
>
> On Sun, 23 Dec 2018, Tom Psyborg wrote:
>
>> Why do you CC this to so many lists?
>
> Because the different files are in different subsystems. The cover letter
> goes to a list for each file, or to a person if there is no list. The
> patches go to the people and lists associated with the affected files.
>
> julia
>
>>
>> On 23/12/2018, Julia Lawall <Julia.Lawall-L2FTfq7BK8M@public.gmane.org> wrote:
>> > Drop LIST_HEAD where the variable it declares is never used.
>> >
>> > ---
>> >
>> > drivers/dma/at_hdmac.c | 5 -----
>> > drivers/dma/dw/core.c | 1 -
>> > drivers/dma/pl330.c | 1 -
>> > drivers/dma/sa11x0-dma.c | 2 --
>> > drivers/dma/st_fdma.c | 3 ---
>> > drivers/infiniband/ulp/ipoib/ipoib_ib.c | 1 -
>> > drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | 5 -----
>> > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 3 ---
>> > drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 1 -
>> > drivers/net/wireless/st/cw1200/queue.c | 1 -
>> > drivers/scsi/lpfc/lpfc_nvme.c | 2 --
>> > drivers/scsi/lpfc/lpfc_scsi.c | 2 --
>> > drivers/scsi/lpfc/lpfc_sli.c | 1 -
>> > drivers/scsi/qla2xxx/qla_init.c | 1 -
>> > drivers/xen/xenbus/xenbus_dev_frontend.c | 2 --
>> > fs/btrfs/relocation.c | 1 -
>> > fs/nfs/nfs4client.c | 1 -
>> > fs/nfsd/nfs4layouts.c | 1 -
>> > fs/xfs/xfs_buf.c | 1 -
>> > fs/xfs/xfs_fsops.c | 1 -
>> > 20 files changed, 36 deletions(-)
>> >
>>
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 00/20] drop useless LIST_HEAD
2018-12-25 22:12 ` Tom Psyborg
@ 2018-12-27 13:40 ` Dan Carpenter
2018-12-29 5:25 ` Darrick J. Wong
0 siblings, 1 reply; 14+ messages in thread
From: Dan Carpenter @ 2018-12-27 13:40 UTC (permalink / raw)
To: Tom Psyborg
Cc: linux-wireless, linux-nfs, Stefano Stabellini, linux-scsi,
linux-rdma, netdev, kernel-janitors, linux-kernel, linux-xfs,
Julia Lawall, linux-btrfs, dmaengine, xen-devel, Dan Williams,
Andy Shevchenko, linux-arm-kernel
On Tue, Dec 25, 2018 at 11:12:20PM +0100, Tom Psyborg wrote:
> there was discussion about this just some days ago. CC 4-5 lists is
> more than enough
>
I don't know who you were discussing this with...
You should CC the 0th patch to all the mailinglists. That much is a
clear rule.
For the rest, Julia's position is the more conservative one. I was in
a conversation in RL and they were like, "CC everyone for all the
patches". It depends on the context, of course. If the patches are
dependent on each other then you *have* to CC everyone for everything.
If we really have other clear rules, then it should be encoded into
get_maintainer.pl so that it's automatic.
My other question is why do the linux-arm-kernel@lists.infradead.org
people feel like they need to be CC'd about every driver??? I always
remove them from the CC list unless it's an arch/arm issue.
regards,
dan carpenter
PS: Please, no more top posting.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 00/20] drop useless LIST_HEAD
2018-12-27 13:40 ` Dan Carpenter
@ 2018-12-29 5:25 ` Darrick J. Wong
2018-12-29 6:19 ` Julia Lawall
0 siblings, 1 reply; 14+ messages in thread
From: Darrick J. Wong @ 2018-12-29 5:25 UTC (permalink / raw)
To: Dan Carpenter
Cc: linux-wireless, linux-nfs, Stefano Stabellini, linux-scsi,
linux-rdma, netdev, kernel-janitors, linux-kernel, linux-xfs,
Julia Lawall, linux-btrfs, dmaengine, xen-devel, Dan Williams,
Andy Shevchenko, Tom Psyborg, linux-arm-kernel
On Thu, Dec 27, 2018 at 04:40:55PM +0300, Dan Carpenter wrote:
> On Tue, Dec 25, 2018 at 11:12:20PM +0100, Tom Psyborg wrote:
> > there was discussion about this just some days ago. CC 4-5 lists is
> > more than enough
> >
>
> I don't know who you were discussing this with...
>
> You should CC the 0th patch to all the mailinglists. That much is a
> clear rule.
>
> For the rest, Julia's position is the more conservative one. I was in
> a conversation in RL and they were like, "CC everyone for all the
> patches". It depends on the context, of course. If the patches are
> dependent on each other then you *have* to CC everyone for everything.
Agreed. Ms. Lawall, sending "Cover letter + all relevant XFS patches"
(as you did) was exactly the right thing for us xfs types. :)
For that matter, we prefer to receive through linux-xfs more patches
than necessary (one can send the entire series if one is unsure) than to
go wanting for more context.
--D
> If we really have other clear rules, then it should be encoded into
> get_maintainer.pl so that it's automatic.
>
> My other question is why do the linux-arm-kernel@lists.infradead.org
> people feel like they need to be CC'd about every driver??? I always
> remove them from the CC list unless it's an arch/arm issue.
>
> regards,
> dan carpenter
>
> PS: Please, no more top posting.
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 00/20] drop useless LIST_HEAD
2018-12-29 5:25 ` Darrick J. Wong
@ 2018-12-29 6:19 ` Julia Lawall
0 siblings, 0 replies; 14+ messages in thread
From: Julia Lawall @ 2018-12-29 6:19 UTC (permalink / raw)
To: Darrick J. Wong
Cc: Dan Carpenter, Tom Psyborg, Julia Lawall, Andy Shevchenko,
kernel-janitors, dmaengine, linux-arm-kernel, Dan Williams,
linux-scsi, linux-nfs, linux-kernel, netdev, linux-rdma,
linux-xfs, linux-btrfs, Stefano Stabellini, xen-devel,
linux-wireless
On Fri, 28 Dec 2018, Darrick J. Wong wrote:
> On Thu, Dec 27, 2018 at 04:40:55PM +0300, Dan Carpenter wrote:
> > On Tue, Dec 25, 2018 at 11:12:20PM +0100, Tom Psyborg wrote:
> > > there was discussion about this just some days ago. CC 4-5 lists is
> > > more than enough
> > >
> >
> > I don't know who you were discussing this with...
> >
> > You should CC the 0th patch to all the mailinglists. That much is a
> > clear rule.
> >
> > For the rest, Julia's position is the more conservative one. I was in
> > a conversation in RL and they were like, "CC everyone for all the
> > patches". It depends on the context, of course. If the patches are
> > dependent on each other then you *have* to CC everyone for everything.
>
> Agreed. Ms. Lawall, sending "Cover letter + all relevant XFS patches"
> (as you did) was exactly the right thing for us xfs types. :)
>
> For that matter, we prefer to receive through linux-xfs more patches
> than necessary (one can send the entire series if one is unsure) than to
> go wanting for more context.
Thanks for the confirmation. I was planning to ignore the 4-5 advice,
because there is no way in this case to make a meaningful 4-5 list
suggestion - it's either all or nothing. But 20 patches at once is
perhaps a lot as well. In this case, I just wanted to get rid of the
whole issue at once.
julia
^ permalink raw reply [flat|nested] 14+ messages in thread