From: Markus Elfring <Markus.Elfring@web.de>
To: Divya Indi <divya.indi@oracle.com>, linux-rdma@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
"Doug Ledford" <dledford@redhat.com>,
"Gerd Rausch" <gerd.rausch@oracle.com>,
"Håkon Bugge" <haakon.bugge@oracle.com>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Kaike Wan" <kaike.wan@intel.com>,
"Rama Nichanamatlu" <rama.nichanamatlu@oracle.com>,
"Srinivas Eeda" <srinivas.eeda@oracle.com>
Subject: Re: [PATCH] IB/sa: Fix use-after-free in ib_nl_send_msg()
Date: Fri, 15 May 2020 18:25:51 +0200 [thread overview]
Message-ID: <b4b66f61-d49e-fd87-87a5-7f5bfff6fd7f@web.de> (raw)
> This patch fixes commit -
> commit 3ebd2fd0d011 ("IB/sa: Put netlink request into the request list before sending")'
>
> Above commit adds the query to the request list before ib_nl_snd_msg.
I suggest to improve also this change description.
The query to the request list was added before ib_nl_snd_msg()
by the commit 3ebd2fd0d011 ("…").
> This flag Indicates …
… indicates …
> To handle the case where a response is received before we could set this
> flag, the response handler waits for the flag to be
> set before proceeding with the query.
Please reconsider the word wrapping.
To handle the case where a response is received before we could set
this flag, the response handler waits for the flag to be set
before proceeding with the query.
Would you like to add the tag “Fixes” to the commit message?
Regards,
Markus
next reply other threads:[~2020-05-15 16:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 16:25 Markus Elfring [this message]
2020-05-19 23:27 ` [PATCH] IB/sa: Fix use-after-free in ib_nl_send_msg() Divya Indi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4b66f61-d49e-fd87-87a5-7f5bfff6fd7f@web.de \
--to=markus.elfring@web.de \
--cc=divya.indi@oracle.com \
--cc=dledford@redhat.com \
--cc=gerd.rausch@oracle.com \
--cc=haakon.bugge@oracle.com \
--cc=jgg@ziepe.ca \
--cc=kaike.wan@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=rama.nichanamatlu@oracle.com \
--cc=srinivas.eeda@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).