* Re: [PATCH] IB/sa: Fix use-after-free in ib_nl_send_msg()
@ 2020-05-15 16:25 Markus Elfring
2020-05-19 23:27 ` Divya Indi
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2020-05-15 16:25 UTC (permalink / raw)
To: Divya Indi, linux-rdma
Cc: kernel-janitors, linux-kernel, Doug Ledford, Gerd Rausch,
Håkon Bugge, Jason Gunthorpe, Kaike Wan, Rama Nichanamatlu,
Srinivas Eeda
> This patch fixes commit -
> commit 3ebd2fd0d011 ("IB/sa: Put netlink request into the request list before sending")'
>
> Above commit adds the query to the request list before ib_nl_snd_msg.
I suggest to improve also this change description.
The query to the request list was added before ib_nl_snd_msg()
by the commit 3ebd2fd0d011 ("…").
> This flag Indicates …
… indicates …
> To handle the case where a response is received before we could set this
> flag, the response handler waits for the flag to be
> set before proceeding with the query.
Please reconsider the word wrapping.
To handle the case where a response is received before we could set
this flag, the response handler waits for the flag to be set
before proceeding with the query.
Would you like to add the tag “Fixes” to the commit message?
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] IB/sa: Fix use-after-free in ib_nl_send_msg()
2020-05-15 16:25 [PATCH] IB/sa: Fix use-after-free in ib_nl_send_msg() Markus Elfring
@ 2020-05-19 23:27 ` Divya Indi
0 siblings, 0 replies; 2+ messages in thread
From: Divya Indi @ 2020-05-19 23:27 UTC (permalink / raw)
To: Markus Elfring, linux-rdma
Cc: kernel-janitors, linux-kernel, Doug Ledford, Gerd Rausch,
Håkon Bugge, Jason Gunthorpe, Kaike Wan, Rama Nichanamatlu,
Srinivas Eeda
Hi Markus,
Thanks for taking the time to review.
On 5/15/20 9:25 AM, Markus Elfring wrote:
>> This patch fixes commit -
>> commit 3ebd2fd0d011 ("IB/sa: Put netlink request into the request list before sending")'
>>
>> Above commit adds the query to the request list before ib_nl_snd_msg.
> I suggest to improve also this change description.
>
> The query to the request list was added before ib_nl_snd_msg()
> by the commit 3ebd2fd0d011 ("…").
Noted, will make this change.
>
>> This flag Indicates …
> … indicates …
Noted.
>
>> To handle the case where a response is received before we could set this
>> flag, the response handler waits for the flag to be
>> set before proceeding with the query.
> Please reconsider the word wrapping.
>
> To handle the case where a response is received before we could set
> this flag, the response handler waits for the flag to be set
> before proceeding with the query.
>
>
> Would you like to add the tag “Fixes” to the commit message?
Noted!
Thanks,
Divya
>
> Regards,
> Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-19 23:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-15 16:25 [PATCH] IB/sa: Fix use-after-free in ib_nl_send_msg() Markus Elfring
2020-05-19 23:27 ` Divya Indi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).