linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RFC PATCH stable] RDMA/qedr: qedr_iw_load_qp() can be static
       [not found] <202006130434.950ZY2zY%lkp@intel.com>
@ 2020-06-12 20:19 ` kernel test robot
  2020-06-19  0:26   ` Jason Gunthorpe
  0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2020-06-12 20:19 UTC (permalink / raw)
  To: Michal Kalderon
  Cc: kbuild-all, Greg Kroah-Hartman, Ariel Elior, Jason Gunthorpe,
	Sasha Levin, Doug Ledford, linux-rdma, linux-kernel


Fixes: 8a69220b659c ("RDMA/qedr: Fix synchronization methods and memory leaks in qedr")
Signed-off-by: kernel test robot <lkp@intel.com>
---
 qedr_iw_cm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/qedr/qedr_iw_cm.c b/drivers/infiniband/hw/qedr/qedr_iw_cm.c
index 5e9732990be5c..a98002018f0ce 100644
--- a/drivers/infiniband/hw/qedr/qedr_iw_cm.c
+++ b/drivers/infiniband/hw/qedr/qedr_iw_cm.c
@@ -506,7 +506,7 @@ qedr_addr6_resolve(struct qedr_dev *dev,
 	return rc;
 }
 
-struct qedr_qp *qedr_iw_load_qp(struct qedr_dev *dev, u32 qpn)
+static struct qedr_qp *qedr_iw_load_qp(struct qedr_dev *dev, u32 qpn)
 {
 	struct qedr_qp *qp;
 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RFC PATCH stable] RDMA/qedr: qedr_iw_load_qp() can be static
  2020-06-12 20:19 ` [RFC PATCH stable] RDMA/qedr: qedr_iw_load_qp() can be static kernel test robot
@ 2020-06-19  0:26   ` Jason Gunthorpe
  2020-06-28  1:02     ` [kbuild-all] " Chen, Rong A
  0 siblings, 1 reply; 3+ messages in thread
From: Jason Gunthorpe @ 2020-06-19  0:26 UTC (permalink / raw)
  To: kernel test robot
  Cc: Michal Kalderon, kbuild-all, Greg Kroah-Hartman, Ariel Elior,
	Sasha Levin, Doug Ledford, linux-rdma, linux-kernel

On Sat, Jun 13, 2020 at 04:19:03AM +0800, kernel test robot wrote:
> 
> Fixes: 8a69220b659c ("RDMA/qedr: Fix synchronization methods and memory leaks in qedr")
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
>  qedr_iw_cm.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

What is this report??

commit 9a5407d74c22821f7944e2be4209bdfc5faf8143
Author: Kamal Heib <kamalheib1@gmail.com>
Date:   Sun Nov 10 13:36:45 2019 +0200

    RDMA/qedr: Make qedr_iw_load_qp() static
    
    The function qedr_iw_load_qp() is only used in qedr_iw_cm.c


Jason

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [kbuild-all] Re: [RFC PATCH stable] RDMA/qedr: qedr_iw_load_qp() can be static
  2020-06-19  0:26   ` Jason Gunthorpe
@ 2020-06-28  1:02     ` Chen, Rong A
  0 siblings, 0 replies; 3+ messages in thread
From: Chen, Rong A @ 2020-06-28  1:02 UTC (permalink / raw)
  To: Jason Gunthorpe, kernel test robot
  Cc: Michal Kalderon, kbuild-all, Greg Kroah-Hartman, Ariel Elior,
	Sasha Levin, Doug Ledford, linux-rdma, linux-kernel



On 6/19/2020 8:26 AM, Jason Gunthorpe wrote:
> On Sat, Jun 13, 2020 at 04:19:03AM +0800, kernel test robot wrote:
>> Fixes: 8a69220b659c ("RDMA/qedr: Fix synchronization methods and memory leaks in qedr")
>> Signed-off-by: kernel test robot <lkp@intel.com>
>> ---
>>   qedr_iw_cm.c |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> What is this report??

Hi Jason,

The report was lost and it should be:

tree:https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git  linux-5.4.y
head:   5e3c511539228fa03c8d00d61b5b5f32333ed0b0
commit: 8a69220b659c31ccd481538193220d732814b324 [5532/5583] RDMA/qedr: Fix synchronization methods and memory leaks in qedr
config: ia64-randconfig-s031-20200612 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce:
         # apt-get install sparse
         # sparse version: v0.6.1-250-g42323db3-dirty
         git checkout 8a69220b659c31ccd481538193220d732814b324
         # save the attached .config to linux build tree
         make W=1 C=1 ARCH=ia64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot<lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

    ./arch/ia64/include/generated/uapi/asm/unistd_64.h:348:39: sparse: sparse: no newline at end of file

>> drivers/infiniband/hw/qedr/qedr_iw_cm.c:509:16: sparse: sparse: symbol 'qedr_iw_load_qp' was not declared. Should it be static?

We'll fix the problem recently.

Best Regards,
Rong Chen

>
> commit 9a5407d74c22821f7944e2be4209bdfc5faf8143
> Author: Kamal Heib <kamalheib1@gmail.com>
> Date:   Sun Nov 10 13:36:45 2019 +0200
>
>      RDMA/qedr: Make qedr_iw_load_qp() static
>      
>      The function qedr_iw_load_qp() is only used in qedr_iw_cm.c
>
>
> Jason
> _______________________________________________
> kbuild-all mailing list -- kbuild-all@lists.01.org
> To unsubscribe send an email to kbuild-all-leave@lists.01.org


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-06-28  1:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <202006130434.950ZY2zY%lkp@intel.com>
2020-06-12 20:19 ` [RFC PATCH stable] RDMA/qedr: qedr_iw_load_qp() can be static kernel test robot
2020-06-19  0:26   ` Jason Gunthorpe
2020-06-28  1:02     ` [kbuild-all] " Chen, Rong A

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).