* [PATCH] RDMA/rxe: goto error handling when detecting invalid opcode
@ 2022-05-19 8:30 Chengguang Xu
2022-05-19 9:20 ` lizhijian
0 siblings, 1 reply; 3+ messages in thread
From: Chengguang Xu @ 2022-05-19 8:30 UTC (permalink / raw)
To: zyjzyj2000, jgg, leon; +Cc: linux-rdma, Chengguang Xu
Currently in rxe_requester() we just skip further operation
instead of going error handling when detecting invalid opcode.
IMO, it should goto error handling just like other errors.
Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
drivers/infiniband/sw/rxe/rxe_req.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c
index ae5fbc79dd5c..8a1cff80a68e 100644
--- a/drivers/infiniband/sw/rxe/rxe_req.c
+++ b/drivers/infiniband/sw/rxe/rxe_req.c
@@ -661,7 +661,7 @@ int rxe_requester(void *arg)
opcode = next_opcode(qp, wqe, wqe->wr.opcode);
if (unlikely(opcode < 0)) {
wqe->status = IB_WC_LOC_QP_OP_ERR;
- goto exit;
+ goto err;
}
mask = rxe_opcode[opcode].mask;
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] RDMA/rxe: goto error handling when detecting invalid opcode
2022-05-19 8:30 [PATCH] RDMA/rxe: goto error handling when detecting invalid opcode Chengguang Xu
@ 2022-05-19 9:20 ` lizhijian
2022-05-19 14:42 ` Chengguang Xu
0 siblings, 1 reply; 3+ messages in thread
From: lizhijian @ 2022-05-19 9:20 UTC (permalink / raw)
To: Chengguang Xu, zyjzyj2000, jgg, leon; +Cc: linux-rdma
looks it's duplicated with
https://patchwork.kernel.org/project/linux-rdma/patch/20220410113513.27537-1-yangx.jy@fujitsu.com/
and it was already applied.
On 19/05/2022 16:30, Chengguang Xu wrote:
> Currently in rxe_requester() we just skip further operation
> instead of going error handling when detecting invalid opcode.
>
> IMO, it should goto error handling just like other errors.
>
> Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
> ---
> drivers/infiniband/sw/rxe/rxe_req.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c
> index ae5fbc79dd5c..8a1cff80a68e 100644
> --- a/drivers/infiniband/sw/rxe/rxe_req.c
> +++ b/drivers/infiniband/sw/rxe/rxe_req.c
> @@ -661,7 +661,7 @@ int rxe_requester(void *arg)
> opcode = next_opcode(qp, wqe, wqe->wr.opcode);
> if (unlikely(opcode < 0)) {
> wqe->status = IB_WC_LOC_QP_OP_ERR;
> - goto exit;
> + goto err;
> }
>
> mask = rxe_opcode[opcode].mask;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] RDMA/rxe: goto error handling when detecting invalid opcode
2022-05-19 9:20 ` lizhijian
@ 2022-05-19 14:42 ` Chengguang Xu
0 siblings, 0 replies; 3+ messages in thread
From: Chengguang Xu @ 2022-05-19 14:42 UTC (permalink / raw)
To: lizhijian, zyjzyj2000, jgg, leon; +Cc: linux-rdma
在 2022/5/19 17:20, lizhijian@fujitsu.com 写道:
> looks it's duplicated with
>
> https://patchwork.kernel.org/project/linux-rdma/patch/20220410113513.27537-1-yangx.jy@fujitsu.com/
>
> and it was already applied.
Ah, it's my fault, please ignore this patch.
Thanks,
Chengguang
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-19 14:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-19 8:30 [PATCH] RDMA/rxe: goto error handling when detecting invalid opcode Chengguang Xu
2022-05-19 9:20 ` lizhijian
2022-05-19 14:42 ` Chengguang Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).