From: Gal Pressman <galpress@amazon.com>
To: "Saleem, Shiraz" <shiraz.saleem@intel.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
Doug Ledford <dledford@redhat.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"Alexander Matushevsky" <matua@amazon.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"Leybovich, Yossi" <sleybo@amazon.com>
Subject: Re: [PATCH for-rc] Revert "RDMA/efa: Use API to get contiguous memory blocks aligned to device supported page size"
Date: Wed, 22 Jan 2020 09:58:39 +0200 [thread overview]
Message-ID: <d118c957-90f2-18d4-9baf-9b0c9a8a972b@amazon.com> (raw)
In-Reply-To: <9DD61F30A802C4429A01CA4200E302A7C1E2A8D0@fmsmsx124.amr.corp.intel.com>
On 21/01/2020 18:39, Saleem, Shiraz wrote:
>> Subject: Re: [PATCH for-rc] Revert "RDMA/efa: Use API to get contiguous
>> memory blocks aligned to device supported page size"
>>
>> On 20/01/2020 16:10, Gal Pressman wrote:
>>> The cited commit leads to register MR failures and random hangs when
>>> running different MPI applications. The exact root cause for the issue
>>> is still not clear, this revert brings us back to a stable state.
>>>
>>> This reverts commit 40ddb3f020834f9afb7aab31385994811f4db259.
>>>
>>> Fixes: 40ddb3f02083 ("RDMA/efa: Use API to get contiguous memory
>>> blocks aligned to device supported page size")
>>> Cc: Shiraz Saleem <shiraz.saleem@intel.com>
>>> Cc: stable@vger.kernel.org # 5.3
>>> Signed-off-by: Gal Pressman <galpress@amazon.com>
>>
>> Shiraz, I think I found the root cause here.
>> I'm noticing a register MR of size 32k, which is constructed from two sges, the first
>> sge of size 12k and the second of 20k.
>>
>> ib_umem_find_best_pgsz returns page shift 13 in the following way:
>>
>> 0x103dcb2000 0x103dcb5000 0x103dd5d000 0x103dd62000
>> +----------+ +------------------+
>> | | | |
>> | 12k | | 20k |
>> +----------+ +------------------+
>>
>> +------+------+ +------+------+------+
>> | | | | | | |
>> | 8k | 8k | | 8k | 8k | 8k |
>> +------+------+ +------+------+------+
>> 0x103dcb2000 0x103dcb6000 0x103dd5c000 0x103dd62000
>>
>>
>
> Gal - would be useful to know the IOVA (virt) and umem->addr also for this MR in ib_umem_find_best_pgsz
I'll update my debug prints to include the iova and rerun the tests.
prev parent reply other threads:[~2020-01-22 7:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 14:10 [PATCH for-rc] Revert "RDMA/efa: Use API to get contiguous memory blocks aligned to device supported page size" Gal Pressman
2020-01-21 9:07 ` Gal Pressman
2020-01-21 16:24 ` Leon Romanovsky
2020-01-22 7:57 ` Gal Pressman
2020-01-23 14:24 ` Leon Romanovsky
2020-01-23 14:29 ` Gal Pressman
2020-01-24 0:40 ` Saleem, Shiraz
2020-01-24 2:52 ` Jason Gunthorpe
2020-01-28 12:32 ` Gal Pressman
2020-01-28 13:47 ` Leon Romanovsky
2020-01-21 16:39 ` Saleem, Shiraz
2020-01-22 7:58 ` Gal Pressman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d118c957-90f2-18d4-9baf-9b0c9a8a972b@amazon.com \
--to=galpress@amazon.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=matua@amazon.com \
--cc=shiraz.saleem@intel.com \
--cc=sleybo@amazon.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).