From: Gal Pressman <galpress@amazon.com>
To: Jason Gunthorpe <jgg@ziepe.ca>,
"Saleem, Shiraz" <shiraz.saleem@intel.com>,
Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Alexander Matushevsky <matua@amazon.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"Leybovich, Yossi" <sleybo@amazon.com>
Subject: Re: [PATCH for-rc] Revert "RDMA/efa: Use API to get contiguous memory blocks aligned to device supported page size"
Date: Tue, 28 Jan 2020 14:32:19 +0200 [thread overview]
Message-ID: <def88bd8-357f-54b4-90f7-ee0ab382aa95@amazon.com> (raw)
In-Reply-To: <20200124025221.GA16405@ziepe.ca>
On 24/01/2020 4:52, Jason Gunthorpe wrote:
> On Fri, Jan 24, 2020 at 12:40:18AM +0000, Saleem, Shiraz wrote:
>> It would be good to get the debug data to back this or prove it wrong.
>> But if this is indeed what's happening, then ORing in the sgl->length for the
>> first sge to restrict the page size might cut it. So something like,
>
> or'ing in the sgl length is a nonsense thing to do, the length has
> nothing to do with the restriction, which is entirely based on IOVA
> bits which can't be passed through.
The weekend runs passed with Leon's proposed patch.
Leon, can you please submit it so I can drop this revert?
Thanks
next prev parent reply other threads:[~2020-01-28 12:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 14:10 [PATCH for-rc] Revert "RDMA/efa: Use API to get contiguous memory blocks aligned to device supported page size" Gal Pressman
2020-01-21 9:07 ` Gal Pressman
2020-01-21 16:24 ` Leon Romanovsky
2020-01-22 7:57 ` Gal Pressman
2020-01-23 14:24 ` Leon Romanovsky
2020-01-23 14:29 ` Gal Pressman
2020-01-24 0:40 ` Saleem, Shiraz
2020-01-24 2:52 ` Jason Gunthorpe
2020-01-28 12:32 ` Gal Pressman [this message]
2020-01-28 13:47 ` Leon Romanovsky
2020-01-21 16:39 ` Saleem, Shiraz
2020-01-22 7:58 ` Gal Pressman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=def88bd8-357f-54b4-90f7-ee0ab382aa95@amazon.com \
--to=galpress@amazon.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matua@amazon.com \
--cc=shiraz.saleem@intel.com \
--cc=sleybo@amazon.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).