* [PATCH 1/2] remoteproc: remoteproc_core: Use 'gnu_printf' format notation
@ 2020-07-15 12:35 Lee Jones
2020-07-15 12:35 ` [PATCH 2/2] remoteproc: qcom_sysmon: Solve function header bitrot issues Lee Jones
2020-07-15 19:40 ` [PATCH 1/2] remoteproc: remoteproc_core: Use 'gnu_printf' format notation patchwork-bot+linux-remoteproc
0 siblings, 2 replies; 4+ messages in thread
From: Lee Jones @ 2020-07-15 12:35 UTC (permalink / raw)
To: bjorn.andersson, ohad
Cc: linux-arm-kernel, linux-kernel, linux-remoteproc, Lee Jones,
Brian Swetland, Mark Grosen, Guzman Lugo, Suman Anna,
Robert Tivy, De Leon
Fixes the following W=1 kernel build warning(s):
drivers/remoteproc/remoteproc_core.c: In function ‘rproc_find_carveout_by_name’:
drivers/remoteproc/remoteproc_core.c:257:2: warning: function ‘rproc_find_carveout_by_name’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
257 | vsnprintf(_name, sizeof(_name), name, args);
| ^~~~~~~~~
drivers/remoteproc/remoteproc_core.c: In function ‘rproc_mem_entry_init’:
drivers/remoteproc/remoteproc_core.c:993:2: warning: function ‘rproc_mem_entry_init’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
993 | vsnprintf(mem->name, sizeof(mem->name), name, args);
| ^~~~~~~~~
drivers/remoteproc/remoteproc_core.c: In function ‘rproc_of_resm_mem_entry_init’:
drivers/remoteproc/remoteproc_core.c:1029:2: warning: function ‘rproc_of_resm_mem_entry_init’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
1029 | vsnprintf(mem->name, sizeof(mem->name), name, args);
| ^~~~~~~~~
Cc: Brian Swetland <swetland@google.com>
Cc: Mark Grosen <mgrosen@ti.com>
Cc: Guzman Lugo <fernando.lugo@ti.com>
Cc: Suman Anna <s-anna@ti.com>
Cc: Robert Tivy <rtivy@ti.com>
Cc: De Leon <x0095078@ti.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/remoteproc/remoteproc_core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index 0f95e025ba030..e00dff425c96e 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -243,6 +243,7 @@ EXPORT_SYMBOL(rproc_da_to_va);
*
* Return: a valid pointer on carveout entry on success or NULL on failure.
*/
+__printf(2, 3)
struct rproc_mem_entry *
rproc_find_carveout_by_name(struct rproc *rproc, const char *name, ...)
{
@@ -966,6 +967,7 @@ EXPORT_SYMBOL(rproc_add_carveout);
* This function allocates a rproc_mem_entry struct and fill it with parameters
* provided by client.
*/
+__printf(8, 9)
struct rproc_mem_entry *
rproc_mem_entry_init(struct device *dev,
void *va, dma_addr_t dma, size_t len, u32 da,
@@ -1009,6 +1011,7 @@ EXPORT_SYMBOL(rproc_mem_entry_init);
* This function allocates a rproc_mem_entry struct and fill it with parameters
* provided by client.
*/
+__printf(5, 6)
struct rproc_mem_entry *
rproc_of_resm_mem_entry_init(struct device *dev, u32 of_resm_idx, size_t len,
u32 da, const char *name, ...)
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] remoteproc: qcom_sysmon: Solve function header bitrot issues
2020-07-15 12:35 [PATCH 1/2] remoteproc: remoteproc_core: Use 'gnu_printf' format notation Lee Jones
@ 2020-07-15 12:35 ` Lee Jones
2020-07-15 19:21 ` Bjorn Andersson
2020-07-15 19:40 ` [PATCH 1/2] remoteproc: remoteproc_core: Use 'gnu_printf' format notation patchwork-bot+linux-remoteproc
1 sibling, 1 reply; 4+ messages in thread
From: Lee Jones @ 2020-07-15 12:35 UTC (permalink / raw)
To: bjorn.andersson, ohad
Cc: linux-arm-kernel, linux-kernel, linux-remoteproc, Lee Jones,
Andy Gross, linux-arm-msm
Looks as though 'name' has now been moved into 'struct sysmod_event'
which is passed in instead. However, the parameter descriptions were
not updated at the same time. Let's do that now.
Fixes the following W=1 kernel build warning(s):
drivers/remoteproc/qcom_sysmon.c:78: warning: Function parameter or member 'event' not described in 'sysmon_send_event'
drivers/remoteproc/qcom_sysmon.c:78: warning: Excess function parameter 'name' description in 'sysmon_send_event'
drivers/remoteproc/qcom_sysmon.c:350: warning: Function parameter or member 'event' not described in 'ssctl_send_event'
drivers/remoteproc/qcom_sysmon.c:350: warning: Excess function parameter 'name' description in 'ssctl_send_event'
Cc: Andy Gross <agross@kernel.org>
Cc: linux-arm-msm@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/remoteproc/qcom_sysmon.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/remoteproc/qcom_sysmon.c b/drivers/remoteproc/qcom_sysmon.c
index 8d8996d714f07..9eb2f6bccea63 100644
--- a/drivers/remoteproc/qcom_sysmon.c
+++ b/drivers/remoteproc/qcom_sysmon.c
@@ -71,7 +71,7 @@ static LIST_HEAD(sysmon_list);
/**
* sysmon_send_event() - send notification of other remote's SSR event
* @sysmon: sysmon context
- * @name: other remote's name
+ * @event: sysmon event context
*/
static void sysmon_send_event(struct qcom_sysmon *sysmon,
const struct sysmon_event *event)
@@ -343,7 +343,7 @@ static void ssctl_request_shutdown(struct qcom_sysmon *sysmon)
/**
* ssctl_send_event() - send notification of other remote's SSR event
* @sysmon: sysmon context
- * @name: other remote's name
+ * @event: sysmon event context
*/
static void ssctl_send_event(struct qcom_sysmon *sysmon,
const struct sysmon_event *event)
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] remoteproc: qcom_sysmon: Solve function header bitrot issues
2020-07-15 12:35 ` [PATCH 2/2] remoteproc: qcom_sysmon: Solve function header bitrot issues Lee Jones
@ 2020-07-15 19:21 ` Bjorn Andersson
0 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2020-07-15 19:21 UTC (permalink / raw)
To: Lee Jones
Cc: ohad, linux-arm-kernel, linux-kernel, linux-remoteproc,
Andy Gross, linux-arm-msm
On Wed 15 Jul 05:35 PDT 2020, Lee Jones wrote:
> Looks as though 'name' has now been moved into 'struct sysmod_event'
> which is passed in instead. However, the parameter descriptions were
> not updated at the same time. Let's do that now.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/remoteproc/qcom_sysmon.c:78: warning: Function parameter or member 'event' not described in 'sysmon_send_event'
> drivers/remoteproc/qcom_sysmon.c:78: warning: Excess function parameter 'name' description in 'sysmon_send_event'
> drivers/remoteproc/qcom_sysmon.c:350: warning: Function parameter or member 'event' not described in 'ssctl_send_event'
> drivers/remoteproc/qcom_sysmon.c:350: warning: Excess function parameter 'name' description in 'ssctl_send_event'
>
> Cc: Andy Gross <agross@kernel.org>
> Cc: linux-arm-msm@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Thanks Lee, both patches applied.
Regards,
Bjorn
> ---
> drivers/remoteproc/qcom_sysmon.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/remoteproc/qcom_sysmon.c b/drivers/remoteproc/qcom_sysmon.c
> index 8d8996d714f07..9eb2f6bccea63 100644
> --- a/drivers/remoteproc/qcom_sysmon.c
> +++ b/drivers/remoteproc/qcom_sysmon.c
> @@ -71,7 +71,7 @@ static LIST_HEAD(sysmon_list);
> /**
> * sysmon_send_event() - send notification of other remote's SSR event
> * @sysmon: sysmon context
> - * @name: other remote's name
> + * @event: sysmon event context
> */
> static void sysmon_send_event(struct qcom_sysmon *sysmon,
> const struct sysmon_event *event)
> @@ -343,7 +343,7 @@ static void ssctl_request_shutdown(struct qcom_sysmon *sysmon)
> /**
> * ssctl_send_event() - send notification of other remote's SSR event
> * @sysmon: sysmon context
> - * @name: other remote's name
> + * @event: sysmon event context
> */
> static void ssctl_send_event(struct qcom_sysmon *sysmon,
> const struct sysmon_event *event)
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] remoteproc: remoteproc_core: Use 'gnu_printf' format notation
2020-07-15 12:35 [PATCH 1/2] remoteproc: remoteproc_core: Use 'gnu_printf' format notation Lee Jones
2020-07-15 12:35 ` [PATCH 2/2] remoteproc: qcom_sysmon: Solve function header bitrot issues Lee Jones
@ 2020-07-15 19:40 ` patchwork-bot+linux-remoteproc
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+linux-remoteproc @ 2020-07-15 19:40 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-remoteproc
Hello:
This series was applied to andersson/remoteproc.git (refs/heads/for-next).
On Wed, 15 Jul 2020 13:35:50 +0100 you wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/remoteproc/remoteproc_core.c: In function ‘rproc_find_carveout_by_name’:
> drivers/remoteproc/remoteproc_core.c:257:2: warning: function ‘rproc_find_carveout_by_name’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
> 257 | vsnprintf(_name, sizeof(_name), name, args);
> | ^~~~~~~~~
> drivers/remoteproc/remoteproc_core.c: In function ‘rproc_mem_entry_init’:
> drivers/remoteproc/remoteproc_core.c:993:2: warning: function ‘rproc_mem_entry_init’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
> 993 | vsnprintf(mem->name, sizeof(mem->name), name, args);
> | ^~~~~~~~~
> drivers/remoteproc/remoteproc_core.c: In function ‘rproc_of_resm_mem_entry_init’:
> drivers/remoteproc/remoteproc_core.c:1029:2: warning: function ‘rproc_of_resm_mem_entry_init’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
> 1029 | vsnprintf(mem->name, sizeof(mem->name), name, args);
> | ^~~~~~~~~
>
> [...]
Here is a summary with links:
- [1/2] remoteproc: remoteproc_core: Use 'gnu_printf' format notation
https://git.kernel.org/andersson/remoteproc/c/7e05c8de132308da0c2a5b17842b808d99a00ca8
- [2/2] remoteproc: qcom_sysmon: Solve function header bitrot issues
https://git.kernel.org/andersson/remoteproc/c/5b435ca38b2ce785b60b4d3c230f0a21121d6728
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/pwbot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-15 19:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-15 12:35 [PATCH 1/2] remoteproc: remoteproc_core: Use 'gnu_printf' format notation Lee Jones
2020-07-15 12:35 ` [PATCH 2/2] remoteproc: qcom_sysmon: Solve function header bitrot issues Lee Jones
2020-07-15 19:21 ` Bjorn Andersson
2020-07-15 19:40 ` [PATCH 1/2] remoteproc: remoteproc_core: Use 'gnu_printf' format notation patchwork-bot+linux-remoteproc
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).