linux-remoteproc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] rpmsg: qcom_glink_native: fix error return code of qcom_glink_rx_data()
@ 2021-03-06 13:36 Jia-Ju Bai
  2021-03-11 23:32 ` patchwork-bot+linux-remoteproc
  0 siblings, 1 reply; 2+ messages in thread
From: Jia-Ju Bai @ 2021-03-06 13:36 UTC (permalink / raw)
  To: agross, bjorn.andersson, ohad
  Cc: linux-arm-msm, linux-remoteproc, linux-kernel, Jia-Ju Bai

When idr_find() returns NULL to intent, no error return code of
qcom_glink_rx_data() is assigned.
To fix this bug, ret is assigned with -ENOENT in this case.

Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
---
 drivers/rpmsg/qcom_glink_native.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c
index 27a05167c18c..4840886532ff 100644
--- a/drivers/rpmsg/qcom_glink_native.c
+++ b/drivers/rpmsg/qcom_glink_native.c
@@ -857,6 +857,7 @@ static int qcom_glink_rx_data(struct qcom_glink *glink, size_t avail)
 			dev_err(glink->dev,
 				"no intent found for channel %s intent %d",
 				channel->name, liid);
+			ret = -ENOENT;
 			goto advance_rx;
 		}
 	}
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] rpmsg: qcom_glink_native: fix error return code of qcom_glink_rx_data()
  2021-03-06 13:36 [PATCH] rpmsg: qcom_glink_native: fix error return code of qcom_glink_rx_data() Jia-Ju Bai
@ 2021-03-11 23:32 ` patchwork-bot+linux-remoteproc
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+linux-remoteproc @ 2021-03-11 23:32 UTC (permalink / raw)
  To: Jia-Ju Bai; +Cc: linux-remoteproc

Hello:

This patch was applied to andersson/remoteproc.git (refs/heads/for-next):

On Sat,  6 Mar 2021 05:36:24 -0800 you wrote:
> When idr_find() returns NULL to intent, no error return code of
> qcom_glink_rx_data() is assigned.
> To fix this bug, ret is assigned with -ENOENT in this case.
> 
> Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
> 
> [...]

Here is the summary with links:
  - rpmsg: qcom_glink_native: fix error return code of qcom_glink_rx_data()
    https://git.kernel.org/andersson/remoteproc/c/d9a69846241c

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-03-11 23:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-06 13:36 [PATCH] rpmsg: qcom_glink_native: fix error return code of qcom_glink_rx_data() Jia-Ju Bai
2021-03-11 23:32 ` patchwork-bot+linux-remoteproc

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).